From 52bc3afd6bddccc41465a6596bb4c8dd4c9dc894 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C5=81ukasz=20Mierzwa?= <l.mierzwa@gmail.com>
Date: Tue, 29 Dec 2020 19:29:50 +0000
Subject: [PATCH] fix(backend): strip labels from alert group when configured

Fixes #2585
---
 CHANGELOG.md                   |  7 ++++
 cmd/karma/api_test.go          | 70 ++++++++++++++++++++++++++++++++++
 internal/alertmanager/dedup.go |  1 +
 3 files changed, 78 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 175a80d0f..e125662fd 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,12 @@
 # Changelog
 
+## [Unreleased]
+
+### Fixed
+
+- Not all labels were stripped when using `lables:keep` or `labels:strip`
+  option #2585.
+
 ## v0.78
 
 ### Fixed
diff --git a/cmd/karma/api_test.go b/cmd/karma/api_test.go
index 4767c986d..cf51021f3 100644
--- a/cmd/karma/api_test.go
+++ b/cmd/karma/api_test.go
@@ -1288,3 +1288,73 @@ func TestSortOrder(t *testing.T) {
 		}
 	}
 }
+
+func verifyStrippedLabels(t *testing.T, labels map[string]string, keep, strip []string) {
+	for _, l := range strip {
+		if val, ok := labels[l]; ok {
+			t.Errorf("Found stripped label %s=%s on %v", l, val, labels)
+		}
+	}
+	if len(keep) > 0 && len(strip) == 0 {
+		for k, v := range labels {
+			ok := false
+			for _, l := range keep {
+				if k == l {
+					ok = true
+				}
+			}
+			if !ok {
+				t.Errorf("Found label %s=%s that's not on the keep list: %v", k, v, keep)
+			}
+		}
+	}
+}
+
+func TestStripLabels(t *testing.T) {
+	type testCaseT struct {
+		keep  []string
+		strip []string
+	}
+
+	testCases := []testCaseT{
+		{keep: []string{}, strip: []string{}},
+		{keep: []string{}, strip: []string{"alertname"}},
+		{keep: []string{"alertname"}, strip: []string{}},
+	}
+
+	mockConfig()
+	for _, version := range mock.ListAllMocks() {
+		t.Logf("Testing API using mock files from Alertmanager %s", version)
+		mockAlerts(version)
+		r := testRouter()
+		setupRouter(r)
+
+		for _, testCase := range testCases {
+			config.Config.Labels.Keep = testCase.keep
+			config.Config.Labels.Strip = testCase.strip
+			apiCache.Flush()
+			req := httptest.NewRequest("GET", "/alerts.json", nil)
+			resp := httptest.NewRecorder()
+			r.ServeHTTP(resp, req)
+			if resp.Code != http.StatusOK {
+				t.Errorf("GET /alerts.json returned status %d", resp.Code)
+			}
+
+			ur := models.AlertsResponse{}
+			err := json.Unmarshal(resp.Body.Bytes(), &ur)
+			if err != nil {
+				t.Errorf("Failed to unmarshal response: %s", err)
+			}
+
+			for _, grid := range ur.Grids {
+				for _, ag := range grid.AlertGroups {
+					for _, alert := range ag.Alerts {
+						verifyStrippedLabels(t, alert.Labels, testCase.keep, testCase.strip)
+					}
+					verifyStrippedLabels(t, ag.Labels, testCase.keep, testCase.strip)
+					verifyStrippedLabels(t, ag.Shared.Labels, testCase.keep, testCase.strip)
+				}
+			}
+		}
+	}
+}
diff --git a/internal/alertmanager/dedup.go b/internal/alertmanager/dedup.go
index 4e4b1bcdd..2b75c87bb 100644
--- a/internal/alertmanager/dedup.go
+++ b/internal/alertmanager/dedup.go
@@ -66,6 +66,7 @@ func DedupAlerts() []models.AlertGroup {
 			continue
 		}
 		ag := models.AlertGroup(agList[0])
+		ag.Labels = transform.StripLables(config.Config.Labels.Keep, config.Config.Labels.Strip, ag.Labels)
 		ag.Alerts = make(models.AlertList, 0, len(alerts))
 		for _, alert := range alerts {
 			alert := alert // scopelint pin