From 3ab6d149fb1d1d05d588544c1ca978e0f3bf6b8e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mierzwa?= Date: Sun, 23 Dec 2018 08:11:26 +0000 Subject: [PATCH 1/3] fix(ci): drop go module tidy check from travis go modules leave checksums of old releases which gets removed when tidy is run, so the diff check is likely to pick us something every time a go module was bumped. Can't have it on CI this way as it will keep failing jobs --- .travis.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 6fe51a0b2..64a8a25ac 100644 --- a/.travis.yml +++ b/.travis.yml @@ -77,8 +77,6 @@ jobs: - export GO111MODULE=on # compile assets via webpack and build those into bindata_assetfs.go file - make bindata_assetfs.go - # tidy module deps to ensure we only have what we needed (git diff will pick it up) - - go mod tidy -v # verify that there are no uncommited changes from (re)compiling sass # assets - git diff --exit-code From 221cd87dd90d0e4ac6130bbe2ef0587f6c4ce411 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mierzwa?= Date: Sun, 23 Dec 2018 08:13:30 +0000 Subject: [PATCH 2/3] chore(renovate): bump renovate PR limit to 3 1 blocks new PRs if there's one that can't be merged quickly --- renovate.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/renovate.json b/renovate.json index 2bfe99dcf..eb95468d8 100644 --- a/renovate.json +++ b/renovate.json @@ -1,5 +1,5 @@ { "extends": ["config:base"], - "prConcurrentLimit": 1, + "prConcurrentLimit": 3, "rebaseStalePrs": false } From d4a11d19e94f7fa1bccbfa430bb70b441a66edd9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mierzwa?= Date: Sun, 23 Dec 2018 08:29:56 +0000 Subject: [PATCH 3/3] fix(ci): pre-download go modules before running concurrent jobs Go modules can run into races when concurrently downloading packages --- .travis.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.travis.yml b/.travis.yml index 64a8a25ac..92d47b697 100644 --- a/.travis.yml +++ b/.travis.yml @@ -42,6 +42,8 @@ jobs: - DESC="Lint Go code" before_script: - make mock-assets + # https://github.com/golang/go/issues/26794 + - GO111MODULE=on go mod download script: make lint-go - stage: Lint @@ -75,6 +77,8 @@ jobs: - nvm install $(< .nvmrc) script: - export GO111MODULE=on + # https://github.com/golang/go/issues/26794 + - go mod download # compile assets via webpack and build those into bindata_assetfs.go file - make bindata_assetfs.go # verify that there are no uncommited changes from (re)compiling sass