From a9a7d8fc8dd0092fd723a3a68ed47de2c84eb687 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mierzwa?= Date: Fri, 6 Dec 2019 15:30:07 +0000 Subject: [PATCH] fix(backend): move version logging to include upstream name --- internal/alertmanager/models.go | 1 + internal/verprobe/verprobe.go | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/internal/alertmanager/models.go b/internal/alertmanager/models.go index 21e8807e4..b9b2db984 100644 --- a/internal/alertmanager/models.go +++ b/internal/alertmanager/models.go @@ -80,6 +80,7 @@ func (am *Alertmanager) probeVersion() string { if err != nil { return fakeVersion } + log.Infof("[%s] Upstream version: %s", am.Name, version) if version == "0.17.0" || version == "0.18.0" { log.Warningf("Alertmanager %s might return incomplete list of alert groups in the API, please upgrade to >=0.19.0, see https://github.com/prymitive/karma/issues/812", version) diff --git a/internal/verprobe/verprobe.go b/internal/verprobe/verprobe.go index 9e4bf7a8a..789b8f0a4 100644 --- a/internal/verprobe/verprobe.go +++ b/internal/verprobe/verprobe.go @@ -4,8 +4,6 @@ import ( "io" "github.com/prometheus/common/expfmt" - - log "github.com/sirupsen/logrus" ) const ( @@ -29,7 +27,6 @@ func Detect(r io.Reader) (string, error) { for _, l := range v.Label { if l.GetName() == versionLabel { version = l.GetValue() - log.Infof("Upstream version: %s", version) break } }