From 2c68967928cfcd1414a2d677f9101ccd04501356 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C5=81ukasz=20Mierzwa?= <l.mierzwa@gmail.com>
Date: Sat, 30 May 2020 16:11:18 +0100
Subject: [PATCH] fix(ui): use alert fingerprint instead of labels hash

---
 ui/src/Components/Grid/AlertGrid/AlertGroup/index.js | 4 +---
 ui/src/Models/API.js                                 | 1 +
 ui/src/__mocks__/Alerts.js                           | 1 +
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/ui/src/Components/Grid/AlertGrid/AlertGroup/index.js b/ui/src/Components/Grid/AlertGrid/AlertGroup/index.js
index b8a458402..be577ec8b 100644
--- a/ui/src/Components/Grid/AlertGrid/AlertGroup/index.js
+++ b/ui/src/Components/Grid/AlertGrid/AlertGroup/index.js
@@ -4,8 +4,6 @@ import PropTypes from "prop-types";
 import { observer } from "mobx-react";
 import { observable, action, toJS } from "mobx";
 
-import hash from "object-hash";
-
 import { Fade } from "react-reveal";
 
 import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
@@ -260,7 +258,7 @@ const AlertGroup = observer(
                       .slice(0, this.renderConfig.alertsToRender)
                       .map((alert) => (
                         <Alert
-                          key={hash(alert.labels)}
+                          key={alert.id}
                           group={group}
                           alert={alert}
                           showAlertmanagers={
diff --git a/ui/src/Models/API.js b/ui/src/Models/API.js
index d803ffd6c..7b5082a46 100644
--- a/ui/src/Models/API.js
+++ b/ui/src/Models/API.js
@@ -20,6 +20,7 @@ const APIAlertAlertmanagerState = PropTypes.exact({
 });
 
 const APIAlert = PropTypes.exact({
+  id: PropTypes.string.isRequired,
   annotations: PropTypes.arrayOf(Annotation).isRequired,
   labels: PropTypes.object.isRequired,
   startsAt: PropTypes.string.isRequired,
diff --git a/ui/src/__mocks__/Alerts.js b/ui/src/__mocks__/Alerts.js
index 454d811c7..550d9c032 100644
--- a/ui/src/__mocks__/Alerts.js
+++ b/ui/src/__mocks__/Alerts.js
@@ -6,6 +6,7 @@ const MockAnnotation = (name, value, visible, isLink) => ({
 });
 
 const MockAlert = (annotations, labels, state) => ({
+  id: Math.random().toString(36),
   annotations: annotations,
   labels: labels,
   startsAt: "2018-08-14T17:36:40.017867056Z",