From 24097ce04166d932c6852b305db30333b800f263 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mierzwa?= Date: Wed, 29 Aug 2018 23:52:43 +0100 Subject: [PATCH] fix(ui): always require a label All code using Duration component is passing label prop, no need to make it optional --- ui/src/Components/SilenceModal/DateTimeSelect/Duration.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui/src/Components/SilenceModal/DateTimeSelect/Duration.js b/ui/src/Components/SilenceModal/DateTimeSelect/Duration.js index c98c57e7c..40362413b 100644 --- a/ui/src/Components/SilenceModal/DateTimeSelect/Duration.js +++ b/ui/src/Components/SilenceModal/DateTimeSelect/Duration.js @@ -11,7 +11,7 @@ const Duration = observer( class Duration extends Component { static propTypes = { value: PropTypes.number.isRequired, - label: PropTypes.string, + label: PropTypes.string.isRequired, onInc: PropTypes.func.isRequired, onDec: PropTypes.func.isRequired }; @@ -40,9 +40,7 @@ const Duration = observer(

{value}

- {label ? ( - {label} - ) : null} + {label}