diff --git a/CHANGELOG.md b/CHANGELOG.md index 733cb1f5a..d63a69573 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,7 @@ ### Changed - Refactored internal APIs. +- Overview modal won't show label name for every value to save screen space. ## v0.92 diff --git a/ui/src/Components/Labels/LabelWithPercent/__snapshots__/index.test.tsx.snap b/ui/src/Components/Labels/LabelWithPercent/__snapshots__/index.test.tsx.snap index f1e07b125..6d8cefb75 100644 --- a/ui/src/Components/Labels/LabelWithPercent/__snapshots__/index.test.tsx.snap +++ b/ui/src/Components/Labels/LabelWithPercent/__snapshots__/index.test.tsx.snap @@ -8,9 +8,6 @@ exports[` matches snapshot with isActive=true 1`] = ` 25 - - foo: - bar @@ -56,9 +53,6 @@ exports[` matches snapshot with offset=0 1`] = ` 25 - - foo: - bar @@ -87,9 +81,6 @@ exports[` matches snapshot with offset=25 1`] = ` 25 - - foo: - bar diff --git a/ui/src/Components/Labels/LabelWithPercent/index.tsx b/ui/src/Components/Labels/LabelWithPercent/index.tsx index ab8d95975..8779105d6 100644 --- a/ui/src/Components/Labels/LabelWithPercent/index.tsx +++ b/ui/src/Components/Labels/LabelWithPercent/index.tsx @@ -55,7 +55,6 @@ const LabelWithPercent: FC<{ {hits} - {name}:{" "} {value} {isActive ? ( diff --git a/ui/src/Components/OverviewModal/OverviewModalContent.test.tsx b/ui/src/Components/OverviewModal/OverviewModalContent.test.tsx index 8a0d35f91..b6c637a71 100644 --- a/ui/src/Components/OverviewModal/OverviewModalContent.test.tsx +++ b/ui/src/Components/OverviewModal/OverviewModalContent.test.tsx @@ -164,12 +164,12 @@ describe("", () => { expect(tree.find("span.components-label")).toHaveLength(2 + 1); // +1 for toggle icon expect(tree.find("span.components-label").at(0).text()).toBe("5foo"); - expect(tree.find("span.components-label").at(1).text()).toBe("5foo: bar"); + expect(tree.find("span.components-label").at(1).text()).toBe("5bar"); tree.find("span.badge.cursor-pointer.with-click").simulate("click"); expect(tree.find("span.components-label")).toHaveLength(4 + 1); // +1 for toggle icon expect(tree.find("span.components-label").at(3).text()).toBe("3bar"); - expect(tree.find("span.components-label").at(4).text()).toBe("3bar: foo"); + expect(tree.find("span.components-label").at(4).text()).toBe("3foo"); }); }); diff --git a/ui/src/Components/OverviewModal/OverviewModalContent.tsx b/ui/src/Components/OverviewModal/OverviewModalContent.tsx index db5aab280..ea4939cfe 100644 --- a/ui/src/Components/OverviewModal/OverviewModalContent.tsx +++ b/ui/src/Components/OverviewModal/OverviewModalContent.tsx @@ -48,7 +48,7 @@ const TableRows: FC<{ } /> ))} - {nameStats.values.length > 9 ? ( + {nameStats.values.length > 10 ? (
+{nameStats.values.length - 9} more
diff --git a/ui/src/Components/OverviewModal/__snapshots__/OverviewModalContent.test.tsx.snap b/ui/src/Components/OverviewModal/__snapshots__/OverviewModalContent.test.tsx.snap index daac29a07..cb55ccd9a 100644 --- a/ui/src/Components/OverviewModal/__snapshots__/OverviewModalContent.test.tsx.snap +++ b/ui/src/Components/OverviewModal/__snapshots__/OverviewModalContent.test.tsx.snap @@ -41,9 +41,6 @@ exports[` matches snapshot with labels to show 1`] = ` 8 - - foo: - bar1 @@ -67,9 +64,6 @@ exports[` matches snapshot with labels to show 1`] = ` 4 - - foo: - bar2 @@ -102,9 +96,6 @@ exports[` matches snapshot with labels to show 1`] = ` 4 - - foo: - bar3 @@ -155,9 +146,6 @@ exports[` matches snapshot with labels to show 1`] = ` 1 - - bar: - baz1 @@ -181,9 +169,6 @@ exports[` matches snapshot with labels to show 1`] = ` 1 - - bar: - baz2 @@ -216,9 +201,6 @@ exports[` matches snapshot with labels to show 1`] = ` 1 - - bar: - baz3 @@ -251,9 +233,6 @@ exports[` matches snapshot with labels to show 1`] = ` 1 - - bar: - baz4 @@ -286,9 +265,6 @@ exports[` matches snapshot with labels to show 1`] = ` 1 - - bar: - baz5 @@ -321,9 +297,6 @@ exports[` matches snapshot with labels to show 1`] = ` 1 - - bar: - baz6 @@ -356,9 +329,6 @@ exports[` matches snapshot with labels to show 1`] = ` 1 - - bar: - baz7 @@ -391,9 +361,6 @@ exports[` matches snapshot with labels to show 1`] = ` 1 - - bar: - baz8 @@ -426,9 +393,6 @@ exports[` matches snapshot with labels to show 1`] = ` 1 - - bar: - baz9 @@ -482,9 +446,6 @@ exports[` matches snapshot with labels to show 1`] = ` 5 - - alertname: - Host_Down