From 072d700b43d2d6919f48d56be5b8a3749959912e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mierzwa?= Date: Sat, 12 Oct 2019 10:50:54 +0100 Subject: [PATCH] fix(ci): expand silence payload preview on storybook --- ui/src/Components/SilenceModal/SilenceForm.js | 5 +---- ui/src/Components/SilenceModal/SilenceForm.test.js | 2 ++ ui/src/Components/SilenceModal/SilenceModalContent.js | 10 ++++++++-- ui/src/Components/SilenceModal/index.stories.js | 4 ++-- 4 files changed, 13 insertions(+), 8 deletions(-) diff --git a/ui/src/Components/SilenceModal/SilenceForm.js b/ui/src/Components/SilenceModal/SilenceForm.js index bf614a56d..5c96e39b2 100644 --- a/ui/src/Components/SilenceModal/SilenceForm.js +++ b/ui/src/Components/SilenceModal/SilenceForm.js @@ -62,10 +62,7 @@ const SilenceForm = observer( alertStore: PropTypes.instanceOf(AlertStore).isRequired, silenceFormStore: PropTypes.instanceOf(SilenceFormStore).isRequired, settingsStore: PropTypes.instanceOf(Settings).isRequired, - previewOpen: PropTypes.bool - }; - static defaultProps = { - previewOpen: false + previewOpen: PropTypes.bool.isRequired }; constructor(props) { diff --git a/ui/src/Components/SilenceModal/SilenceForm.test.js b/ui/src/Components/SilenceModal/SilenceForm.test.js index 667c255ad..810497a04 100644 --- a/ui/src/Components/SilenceModal/SilenceForm.test.js +++ b/ui/src/Components/SilenceModal/SilenceForm.test.js @@ -31,6 +31,7 @@ const ShallowSilenceForm = () => { alertStore={alertStore} silenceFormStore={silenceFormStore} settingsStore={settingsStore} + previewOpen={false} /> ); }; @@ -41,6 +42,7 @@ const MountedSilenceForm = () => { alertStore={alertStore} silenceFormStore={silenceFormStore} settingsStore={settingsStore} + previewOpen={false} /> ); }; diff --git a/ui/src/Components/SilenceModal/SilenceModalContent.js b/ui/src/Components/SilenceModal/SilenceModalContent.js index 24e5a081b..e42e6ae61 100644 --- a/ui/src/Components/SilenceModal/SilenceModalContent.js +++ b/ui/src/Components/SilenceModal/SilenceModalContent.js @@ -18,7 +18,11 @@ const SilenceModalContent = observer( alertStore: PropTypes.instanceOf(AlertStore).isRequired, silenceFormStore: PropTypes.instanceOf(SilenceFormStore).isRequired, settingsStore: PropTypes.instanceOf(Settings).isRequired, - onHide: PropTypes.func.isRequired + onHide: PropTypes.func.isRequired, + previewOpen: PropTypes.bool + }; + static defaultProps = { + previewOpen: false }; render() { @@ -26,7 +30,8 @@ const SilenceModalContent = observer( alertStore, silenceFormStore, settingsStore, - onHide + onHide, + previewOpen } = this.props; return ( @@ -54,6 +59,7 @@ const SilenceModalContent = observer( alertStore={alertStore} silenceFormStore={silenceFormStore} settingsStore={settingsStore} + previewOpen={previewOpen} /> ) : silenceFormStore.data.currentStage === SilenceFormStage.Preview ? ( diff --git a/ui/src/Components/SilenceModal/index.stories.js b/ui/src/Components/SilenceModal/index.stories.js index 80dc76488..e2dafdd1a 100644 --- a/ui/src/Components/SilenceModal/index.stories.js +++ b/ui/src/Components/SilenceModal/index.stories.js @@ -21,7 +21,7 @@ const MockMatcher = (name, values, isRegex) => { return matcher; }; -storiesOf("SilenceModalContent", module) +storiesOf("SilenceModal", module) .addDecorator(storyFn => (
@@ -29,7 +29,7 @@ storiesOf("SilenceModalContent", module)
)) - .add("SilenceModalContent", () => { + .add("Silence Form", () => { const alertStore = new AlertStore([]); const settingsStore = new Settings(); const silenceFormStore = new SilenceFormStore();