From 003e2d88acfccfe60e614297204b0fb120ac73fa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Mierzwa?= Date: Fri, 15 Mar 2019 13:27:03 +0000 Subject: [PATCH] fix(api): always sort shared silences Prevent different order between requests, which can also break random tests --- internal/models/api.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/internal/models/api.go b/internal/models/api.go index 1805da55d..6fa98ad15 100644 --- a/internal/models/api.go +++ b/internal/models/api.go @@ -2,6 +2,7 @@ package models import ( "fmt" + "sort" "github.com/prymitive/karma/internal/slices" ) @@ -179,6 +180,8 @@ func (ag *APIAlertGroup) dedupSilences() { ag.Shared.Silences[cluster] = []string{} } ag.Shared.Silences[cluster] = append(ag.Shared.Silences[cluster], silenceID) + // sort to have stable order of silences + sort.Strings(ag.Shared.Silences[cluster]) } } }