mirror of
https://github.com/rancher/k3k.git
synced 2026-08-18 20:07:06 +00:00
Enrico CandinoandGitHub
eb0955f666
* Add cluster deletion and completion enhancements - Implemented `--all` flag for deleting all clusters in a namespace. - Updated argument parsing to allow for maximum one cluster name. - Added completion functions for cluster names with namespace filtering. - Enhanced tests for cluster argument resolution and completion functions. * fix docs * Add log message for empty cluster deletion in specified namespace * Refactor context handling in command functions to use `cmd.Context()`
130 lines
3.6 KiB
Go
130 lines
3.6 KiB
Go
package cmds
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/spf13/cobra"
|
|
"github.com/stretchr/testify/assert"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
"sigs.k8s.io/controller-runtime/pkg/client/fake"
|
|
|
|
corev1 "k8s.io/api/core/v1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
clientgoscheme "k8s.io/client-go/kubernetes/scheme"
|
|
|
|
"github.com/rancher/k3k/pkg/apis/k3k.io/v1beta1"
|
|
)
|
|
|
|
func completionTestScheme(t *testing.T) *runtime.Scheme {
|
|
t.Helper()
|
|
|
|
scheme := runtime.NewScheme()
|
|
schemeBuilder := runtime.NewSchemeBuilder(
|
|
clientgoscheme.AddToScheme,
|
|
v1beta1.AddToScheme,
|
|
)
|
|
assert.NoError(t, schemeBuilder.AddToScheme(scheme))
|
|
|
|
return scheme
|
|
}
|
|
|
|
func namespace(name string) *corev1.Namespace {
|
|
return &corev1.Namespace{ObjectMeta: metav1.ObjectMeta{Name: name}}
|
|
}
|
|
|
|
func cluster(name, ns string) *v1beta1.Cluster {
|
|
return &v1beta1.Cluster{ObjectMeta: metav1.ObjectMeta{Name: name, Namespace: ns}}
|
|
}
|
|
|
|
func Test_completeNamespaces(t *testing.T) {
|
|
fakeClient := fake.NewClientBuilder().
|
|
WithScheme(completionTestScheme(t)).
|
|
WithObjects(
|
|
namespace("default"),
|
|
namespace("k3k-foo"),
|
|
namespace("k3k-bar"),
|
|
).
|
|
Build()
|
|
|
|
names, directive := namespaceCompletions(&cobra.Command{}, fakeClient)
|
|
|
|
assert.Equal(t, cobra.ShellCompDirectiveNoFileComp, directive)
|
|
assert.ElementsMatch(t, []string{"default", "k3k-foo", "k3k-bar"}, names)
|
|
}
|
|
|
|
func Test_completeNamespaces_excludesSelected(t *testing.T) {
|
|
fakeClient := fake.NewClientBuilder().
|
|
WithScheme(completionTestScheme(t)).
|
|
WithObjects(
|
|
namespace("default"),
|
|
namespace("k3k-foo"),
|
|
namespace("k3k-bar"),
|
|
).
|
|
Build()
|
|
|
|
cmd := &cobra.Command{}
|
|
cmd.Flags().StringSlice("namespace", nil, "")
|
|
assert.NoError(t, cmd.Flags().Set("namespace", "k3k-foo"))
|
|
|
|
names, directive := namespaceCompletions(cmd, fakeClient)
|
|
|
|
assert.Equal(t, cobra.ShellCompDirectiveNoFileComp, directive)
|
|
// already-selected "k3k-foo" is filtered out
|
|
assert.ElementsMatch(t, []string{"default", "k3k-bar"}, names)
|
|
}
|
|
|
|
func Test_completeClusterNamespaces(t *testing.T) {
|
|
fakeClient := fake.NewClientBuilder().
|
|
WithScheme(completionTestScheme(t)).
|
|
WithObjects(
|
|
namespace("default"),
|
|
namespace("k3k-foo"),
|
|
namespace("k3k-bar"),
|
|
cluster("foo", "k3k-foo"),
|
|
cluster("bar", "k3k-bar"),
|
|
// second cluster in the same namespace must be deduped
|
|
cluster("bar-2", "k3k-bar"),
|
|
).
|
|
Build()
|
|
|
|
names, directive := clusterNamespaceCompletions(t.Context(), fakeClient)
|
|
|
|
assert.Equal(t, cobra.ShellCompDirectiveNoFileComp, directive)
|
|
// only namespaces that contain a cluster, deduplicated; "default" is excluded
|
|
assert.ElementsMatch(t, []string{"k3k-foo", "k3k-bar"}, names)
|
|
}
|
|
|
|
func Test_completeClusterNames(t *testing.T) {
|
|
fakeClient := fake.NewClientBuilder().
|
|
WithScheme(completionTestScheme(t)).
|
|
WithObjects(
|
|
cluster("foo", "k3k-foo"),
|
|
cluster("bar", "k3k-bar"),
|
|
cluster("bar-2", "k3k-bar"),
|
|
).
|
|
Build()
|
|
|
|
names, directive := clusterNameCompletions(t.Context(), fakeClient, "")
|
|
|
|
assert.Equal(t, cobra.ShellCompDirectiveNoFileComp, directive)
|
|
// clusters across all namespaces, in "namespace/name" form
|
|
assert.ElementsMatch(t, []string{"k3k-foo/foo", "k3k-bar/bar", "k3k-bar/bar-2"}, names)
|
|
}
|
|
|
|
func Test_completeClusterNames_filtersNamespace(t *testing.T) {
|
|
fakeClient := fake.NewClientBuilder().
|
|
WithScheme(completionTestScheme(t)).
|
|
WithObjects(
|
|
cluster("foo", "k3k-foo"),
|
|
cluster("bar", "k3k-bar"),
|
|
cluster("bar-2", "k3k-bar"),
|
|
).
|
|
Build()
|
|
|
|
names, directive := clusterNameCompletions(t.Context(), fakeClient, "k3k-bar")
|
|
|
|
assert.Equal(t, cobra.ShellCompDirectiveNoFileComp, directive)
|
|
// only the clusters in the requested namespace
|
|
assert.ElementsMatch(t, []string{"k3k-bar/bar", "k3k-bar/bar-2"}, names)
|
|
}
|