diff --git a/.golangci.yml b/.golangci.yml index 2da35ec8..73c776b4 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -4,3 +4,24 @@ linters: enable: - misspell - wsl_v5 + +formatters: + enable: + - gci + - gofmt + - gofumpt + settings: + gci: + # The default order is `standard > default > custom > blank > dot > alias > localmodule`. + custom-order: true + sections: + - standard + - default + - alias + - localmodule + - dot + - blank + gofmt: + rewrite-rules: + - pattern: 'interface{}' + replacement: 'any' diff --git a/Makefile b/Makefile index f8fb0834..1fd1c531 100644 --- a/Makefile +++ b/Makefile @@ -86,8 +86,12 @@ docs: ## Build the CRDs and CLI docs lint: ## Find any linting issues in the project $(GOLANGCI_LINT) run --timeout=5m +.PHONY: fmt +fmt: ## Find any linting issues in the project + $(GOLANGCI_LINT) fmt ./... + .PHONY: validate -validate: generate docs ## Validate the project checking for any dependency or doc mismatch +validate: generate docs fmt ## Validate the project checking for any dependency or doc mismatch $(GINKGO) unfocus go mod tidy git status --porcelain diff --git a/cli/cmds/cluster_create.go b/cli/cmds/cluster_create.go index b98c5b90..1bf37ad7 100644 --- a/cli/cmds/cluster_create.go +++ b/cli/cmds/cluster_create.go @@ -9,20 +9,22 @@ import ( "strings" "time" + "github.com/sirupsen/logrus" + "github.com/urfave/cli/v2" + "k8s.io/apimachinery/pkg/util/wait" + "k8s.io/client-go/util/retry" + "k8s.io/utils/ptr" + "sigs.k8s.io/controller-runtime/pkg/client" + + v1 "k8s.io/api/core/v1" + apierrors "k8s.io/apimachinery/pkg/api/errors" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + clientcmdapi "k8s.io/client-go/tools/clientcmd/api" + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" "github.com/rancher/k3k/pkg/controller" k3kcluster "github.com/rancher/k3k/pkg/controller/cluster" "github.com/rancher/k3k/pkg/controller/kubeconfig" - "github.com/sirupsen/logrus" - "github.com/urfave/cli/v2" - v1 "k8s.io/api/core/v1" - apierrors "k8s.io/apimachinery/pkg/api/errors" - metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" - "k8s.io/apimachinery/pkg/util/wait" - clientcmdapi "k8s.io/client-go/tools/clientcmd/api" - "k8s.io/client-go/util/retry" - "k8s.io/utils/ptr" - "sigs.k8s.io/controller-runtime/pkg/client" ) type CreateConfig struct { diff --git a/cli/cmds/cluster_create_flags.go b/cli/cmds/cluster_create_flags.go index 7249233a..f5d7c435 100644 --- a/cli/cmds/cluster_create_flags.go +++ b/cli/cmds/cluster_create_flags.go @@ -3,9 +3,10 @@ package cmds import ( "errors" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" "github.com/urfave/cli/v2" "k8s.io/apimachinery/pkg/api/resource" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" ) func newCreateFlags(config *CreateConfig) []cli.Flag { diff --git a/cli/cmds/cluster_delete.go b/cli/cmds/cluster_delete.go index 30d193d8..fd620897 100644 --- a/cli/cmds/cluster_delete.go +++ b/cli/cmds/cluster_delete.go @@ -4,17 +4,19 @@ import ( "context" "errors" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - k3kcluster "github.com/rancher/k3k/pkg/controller/cluster" - "github.com/rancher/k3k/pkg/controller/cluster/agent" "github.com/sirupsen/logrus" "github.com/urfave/cli/v2" + "k8s.io/apimachinery/pkg/types" + "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil" + v1 "k8s.io/api/core/v1" apierrors "k8s.io/apimachinery/pkg/api/errors" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" - "k8s.io/apimachinery/pkg/types" ctrlclient "sigs.k8s.io/controller-runtime/pkg/client" - "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + k3kcluster "github.com/rancher/k3k/pkg/controller/cluster" + "github.com/rancher/k3k/pkg/controller/cluster/agent" ) var keepData bool diff --git a/cli/cmds/cluster_list.go b/cli/cmds/cluster_list.go index 57565363..b4abddd9 100644 --- a/cli/cmds/cluster_list.go +++ b/cli/cmds/cluster_list.go @@ -3,12 +3,14 @@ package cmds import ( "context" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" "github.com/urfave/cli/v2" - apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1" "k8s.io/apimachinery/pkg/types" "k8s.io/cli-runtime/pkg/printers" + + apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1" ctrlclient "sigs.k8s.io/controller-runtime/pkg/client" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" ) func NewClusterListCmd(appCtx *AppContext) *cli.Command { diff --git a/cli/cmds/kubeconfig.go b/cli/cmds/kubeconfig.go index 8a28e7e9..cd3ac507 100644 --- a/cli/cmds/kubeconfig.go +++ b/cli/cmds/kubeconfig.go @@ -8,18 +8,20 @@ import ( "strings" "time" + "github.com/sirupsen/logrus" + "github.com/urfave/cli/v2" + "k8s.io/apimachinery/pkg/types" + "k8s.io/apiserver/pkg/authentication/user" + "k8s.io/client-go/tools/clientcmd" + "k8s.io/client-go/util/retry" + + apierrors "k8s.io/apimachinery/pkg/api/errors" + clientcmdapi "k8s.io/client-go/tools/clientcmd/api" + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" "github.com/rancher/k3k/pkg/controller" "github.com/rancher/k3k/pkg/controller/certs" "github.com/rancher/k3k/pkg/controller/kubeconfig" - "github.com/sirupsen/logrus" - "github.com/urfave/cli/v2" - apierrors "k8s.io/apimachinery/pkg/api/errors" - "k8s.io/apimachinery/pkg/types" - "k8s.io/apiserver/pkg/authentication/user" - "k8s.io/client-go/tools/clientcmd" - clientcmdapi "k8s.io/client-go/tools/clientcmd/api" - "k8s.io/client-go/util/retry" ) var ( @@ -179,5 +181,5 @@ func writeKubeconfigFile(cluster *v1alpha1.Cluster, kubeconfig *clientcmdapi.Con return err } - return os.WriteFile(configName, kubeconfigData, 0644) + return os.WriteFile(configName, kubeconfigData, 0o644) } diff --git a/cli/cmds/policy_create.go b/cli/cmds/policy_create.go index 92d3f9db..4ba1ca6a 100644 --- a/cli/cmds/policy_create.go +++ b/cli/cmds/policy_create.go @@ -4,15 +4,17 @@ import ( "context" "errors" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - "github.com/rancher/k3k/pkg/controller/policy" "github.com/sirupsen/logrus" "github.com/urfave/cli/v2" + "k8s.io/apimachinery/pkg/types" + "sigs.k8s.io/controller-runtime/pkg/client" + v1 "k8s.io/api/core/v1" apierrors "k8s.io/apimachinery/pkg/api/errors" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" - "k8s.io/apimachinery/pkg/types" - "sigs.k8s.io/controller-runtime/pkg/client" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + "github.com/rancher/k3k/pkg/controller/policy" ) type VirtualClusterPolicyCreateConfig struct { diff --git a/cli/cmds/policy_delete.go b/cli/cmds/policy_delete.go index a081d6f2..b13f7502 100644 --- a/cli/cmds/policy_delete.go +++ b/cli/cmds/policy_delete.go @@ -3,10 +3,12 @@ package cmds import ( "context" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" "github.com/sirupsen/logrus" "github.com/urfave/cli/v2" + apierrors "k8s.io/apimachinery/pkg/api/errors" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" ) func NewPolicyDeleteCmd(appCtx *AppContext) *cli.Command { diff --git a/cli/cmds/policy_list.go b/cli/cmds/policy_list.go index c4fb8846..3e569537 100644 --- a/cli/cmds/policy_list.go +++ b/cli/cmds/policy_list.go @@ -3,11 +3,13 @@ package cmds import ( "context" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" "github.com/urfave/cli/v2" - apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1" "k8s.io/apimachinery/pkg/types" "k8s.io/cli-runtime/pkg/printers" + + apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" ) func NewPolicyListCmd(appCtx *AppContext) *cli.Command { diff --git a/cli/cmds/root.go b/cli/cmds/root.go index 8433b9c8..62128f5b 100644 --- a/cli/cmds/root.go +++ b/cli/cmds/root.go @@ -3,16 +3,18 @@ package cmds import ( "fmt" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - "github.com/rancher/k3k/pkg/buildinfo" "github.com/sirupsen/logrus" "github.com/urfave/cli/v2" - apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1" "k8s.io/apimachinery/pkg/runtime" - clientgoscheme "k8s.io/client-go/kubernetes/scheme" "k8s.io/client-go/rest" "k8s.io/client-go/tools/clientcmd" "sigs.k8s.io/controller-runtime/pkg/client" + + apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1" + clientgoscheme "k8s.io/client-go/kubernetes/scheme" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + "github.com/rancher/k3k/pkg/buildinfo" ) type AppContext struct { diff --git a/cli/cmds/table_printer.go b/cli/cmds/table_printer.go index 53f45656..1e9da0a9 100644 --- a/cli/cmds/table_printer.go +++ b/cli/cmds/table_printer.go @@ -1,10 +1,11 @@ package cmds import ( - apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1" - metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime" "k8s.io/client-go/util/jsonpath" + + apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" ) // createTable creates a table to print from the printerColumn defined in the CRD spec, plus the name at the beginning @@ -93,7 +94,7 @@ func buildRowCells(objMap map[string]any, printerColumns []apiextensionsv1.Custo } func toPointerSlice[T any](v []T) []*T { - var vPtr = make([]*T, len(v)) + vPtr := make([]*T, len(v)) for i := range v { vPtr[i] = &v[i] diff --git a/cli/main.go b/cli/main.go index 355dfcd2..558ad610 100644 --- a/cli/main.go +++ b/cli/main.go @@ -3,8 +3,9 @@ package main import ( "os" - "github.com/rancher/k3k/cli/cmds" "github.com/sirupsen/logrus" + + "github.com/rancher/k3k/cli/cmds" ) func main() { diff --git a/docs/cli/genclidoc.go b/docs/cli/genclidoc.go index 7fd6649d..e9952142 100644 --- a/docs/cli/genclidoc.go +++ b/docs/cli/genclidoc.go @@ -27,7 +27,7 @@ func main() { outputFile := path.Join(wd, "docs/cli/cli-docs.md") - err = os.WriteFile(outputFile, []byte(md), 0644) + err = os.WriteFile(outputFile, []byte(md), 0o644) if err != nil { fmt.Println("Error generating documentation:", err) os.Exit(1) diff --git a/k3k-kubelet/controller/configmap.go b/k3k-kubelet/controller/configmap.go index 78ff5008..2e7359ed 100644 --- a/k3k-kubelet/controller/configmap.go +++ b/k3k-kubelet/controller/configmap.go @@ -5,15 +5,17 @@ import ( "fmt" "sync" - "github.com/rancher/k3k/pkg/controller" - k3klog "github.com/rancher/k3k/pkg/log" - corev1 "k8s.io/api/core/v1" - apierrors "k8s.io/apimachinery/pkg/api/errors" "k8s.io/apimachinery/pkg/types" "k8s.io/apimachinery/pkg/util/sets" "k8s.io/client-go/util/retry" "sigs.k8s.io/controller-runtime/pkg/client" "sigs.k8s.io/controller-runtime/pkg/reconcile" + + corev1 "k8s.io/api/core/v1" + apierrors "k8s.io/apimachinery/pkg/api/errors" + + "github.com/rancher/k3k/pkg/controller" + k3klog "github.com/rancher/k3k/pkg/log" ) const ConfigMapSyncerName = "configmap-syncer" diff --git a/k3k-kubelet/controller/controller_suite_test.go b/k3k-kubelet/controller/controller_suite_test.go index eafbbcf7..0dbbd035 100644 --- a/k3k-kubelet/controller/controller_suite_test.go +++ b/k3k-kubelet/controller/controller_suite_test.go @@ -9,17 +9,18 @@ import ( "testing" "github.com/go-logr/zapr" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - "go.uber.org/zap" "k8s.io/apimachinery/pkg/runtime" "k8s.io/client-go/kubernetes" - clientgoscheme "k8s.io/client-go/kubernetes/scheme" - ctrl "sigs.k8s.io/controller-runtime" "sigs.k8s.io/controller-runtime/pkg/client" "sigs.k8s.io/controller-runtime/pkg/envtest" + + clientgoscheme "k8s.io/client-go/kubernetes/scheme" + ctrl "sigs.k8s.io/controller-runtime" metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server" + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + . "github.com/onsi/ginkgo/v2" . "github.com/onsi/gomega" ) @@ -77,7 +78,7 @@ func NewTestEnv() *TestEnv { tmpKubebuilderDir := path.Join(os.TempDir(), "kubebuilder") - if err := os.Mkdir(tmpKubebuilderDir, 0755); !errors.Is(err, os.ErrExist) { + if err := os.Mkdir(tmpKubebuilderDir, 0o755); !errors.Is(err, os.ErrExist) { Expect(err).NotTo(HaveOccurred()) } @@ -124,7 +125,6 @@ func buildScheme() *runtime.Scheme { } var _ = Describe("Kubelet Controller", func() { - var ( ctx context.Context cancel context.CancelFunc diff --git a/k3k-kubelet/controller/handler.go b/k3k-kubelet/controller/handler.go index 4a9c3a2a..5075f773 100644 --- a/k3k-kubelet/controller/handler.go +++ b/k3k-kubelet/controller/handler.go @@ -5,15 +5,17 @@ import ( "fmt" "sync" - "github.com/rancher/k3k/k3k-kubelet/translate" - k3klog "github.com/rancher/k3k/pkg/log" - v1 "k8s.io/api/core/v1" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime/schema" - ctrl "sigs.k8s.io/controller-runtime" "sigs.k8s.io/controller-runtime/pkg/client" "sigs.k8s.io/controller-runtime/pkg/manager" "sigs.k8s.io/controller-runtime/pkg/reconcile" + + v1 "k8s.io/api/core/v1" + ctrl "sigs.k8s.io/controller-runtime" + + "github.com/rancher/k3k/k3k-kubelet/translate" + k3klog "github.com/rancher/k3k/pkg/log" ) type ControllerHandler struct { @@ -61,9 +63,7 @@ func (c *ControllerHandler) AddResource(ctx context.Context, obj client.Object) // we need to manually lock/unlock since we intned on write locking to add a new controller c.RUnlock() - var ( - r updateableReconciler - ) + var r updateableReconciler switch obj.(type) { case *v1.Secret: diff --git a/k3k-kubelet/controller/persistentvolumeclaims.go b/k3k-kubelet/controller/persistentvolumeclaims.go index 603aa498..2d35bd87 100644 --- a/k3k-kubelet/controller/persistentvolumeclaims.go +++ b/k3k-kubelet/controller/persistentvolumeclaims.go @@ -3,17 +3,19 @@ package controller import ( "context" - "github.com/rancher/k3k/k3k-kubelet/translate" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - v1 "k8s.io/api/core/v1" - apierrors "k8s.io/apimachinery/pkg/api/errors" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/types" - ctrl "sigs.k8s.io/controller-runtime" - ctrlruntimeclient "sigs.k8s.io/controller-runtime/pkg/client" "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil" "sigs.k8s.io/controller-runtime/pkg/manager" "sigs.k8s.io/controller-runtime/pkg/reconcile" + + v1 "k8s.io/api/core/v1" + apierrors "k8s.io/apimachinery/pkg/api/errors" + ctrl "sigs.k8s.io/controller-runtime" + ctrlruntimeclient "sigs.k8s.io/controller-runtime/pkg/client" + + "github.com/rancher/k3k/k3k-kubelet/translate" + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" ) const ( diff --git a/k3k-kubelet/controller/pod.go b/k3k-kubelet/controller/pod.go index fe254359..43fef312 100644 --- a/k3k-kubelet/controller/pod.go +++ b/k3k-kubelet/controller/pod.go @@ -3,17 +3,19 @@ package controller import ( "context" - "github.com/rancher/k3k/k3k-kubelet/translate" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - v1 "k8s.io/api/core/v1" - metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/types" "k8s.io/component-helpers/storage/volume" - ctrl "sigs.k8s.io/controller-runtime" - ctrlruntimeclient "sigs.k8s.io/controller-runtime/pkg/client" "sigs.k8s.io/controller-runtime/pkg/manager" "sigs.k8s.io/controller-runtime/pkg/reconcile" + + v1 "k8s.io/api/core/v1" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + ctrl "sigs.k8s.io/controller-runtime" + ctrlruntimeclient "sigs.k8s.io/controller-runtime/pkg/client" + + "github.com/rancher/k3k/k3k-kubelet/translate" + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" ) const ( diff --git a/k3k-kubelet/controller/priority_class_test.go b/k3k-kubelet/controller/priority_class_test.go index 461567dd..b28290b4 100644 --- a/k3k-kubelet/controller/priority_class_test.go +++ b/k3k-kubelet/controller/priority_class_test.go @@ -5,22 +5,22 @@ import ( "fmt" "time" - "github.com/rancher/k3k/k3k-kubelet/controller" - "github.com/rancher/k3k/k3k-kubelet/translate" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + "sigs.k8s.io/controller-runtime/pkg/client" v1 "k8s.io/api/core/v1" schedulingv1 "k8s.io/api/scheduling/v1" apierrors "k8s.io/apimachinery/pkg/api/errors" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" - "sigs.k8s.io/controller-runtime/pkg/client" + + "github.com/rancher/k3k/k3k-kubelet/controller" + "github.com/rancher/k3k/k3k-kubelet/translate" + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" . "github.com/onsi/ginkgo/v2" . "github.com/onsi/gomega" ) var PriorityClassTests = func() { - var ( namespace string cluster v1alpha1.Cluster diff --git a/k3k-kubelet/controller/priorityclass.go b/k3k-kubelet/controller/priorityclass.go index e444c8bc..7949558d 100644 --- a/k3k-kubelet/controller/priorityclass.go +++ b/k3k-kubelet/controller/priorityclass.go @@ -4,19 +4,21 @@ import ( "context" "strings" - "github.com/rancher/k3k/k3k-kubelet/translate" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - schedulingv1 "k8s.io/api/scheduling/v1" - apierrors "k8s.io/apimachinery/pkg/api/errors" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/types" - ctrl "sigs.k8s.io/controller-runtime" - ctrlruntimeclient "sigs.k8s.io/controller-runtime/pkg/client" "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil" "sigs.k8s.io/controller-runtime/pkg/event" "sigs.k8s.io/controller-runtime/pkg/manager" "sigs.k8s.io/controller-runtime/pkg/predicate" "sigs.k8s.io/controller-runtime/pkg/reconcile" + + schedulingv1 "k8s.io/api/scheduling/v1" + apierrors "k8s.io/apimachinery/pkg/api/errors" + ctrl "sigs.k8s.io/controller-runtime" + ctrlruntimeclient "sigs.k8s.io/controller-runtime/pkg/client" + + "github.com/rancher/k3k/k3k-kubelet/translate" + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" ) const ( diff --git a/k3k-kubelet/controller/secret.go b/k3k-kubelet/controller/secret.go index 52ccccc3..fa94e7b4 100644 --- a/k3k-kubelet/controller/secret.go +++ b/k3k-kubelet/controller/secret.go @@ -5,15 +5,17 @@ import ( "fmt" "sync" - "github.com/rancher/k3k/pkg/controller" - k3klog "github.com/rancher/k3k/pkg/log" - corev1 "k8s.io/api/core/v1" - apierrors "k8s.io/apimachinery/pkg/api/errors" "k8s.io/apimachinery/pkg/types" "k8s.io/apimachinery/pkg/util/sets" "k8s.io/client-go/util/retry" "sigs.k8s.io/controller-runtime/pkg/client" "sigs.k8s.io/controller-runtime/pkg/reconcile" + + corev1 "k8s.io/api/core/v1" + apierrors "k8s.io/apimachinery/pkg/api/errors" + + "github.com/rancher/k3k/pkg/controller" + k3klog "github.com/rancher/k3k/pkg/log" ) const SecretSyncerName = "secret-syncer" diff --git a/k3k-kubelet/controller/service.go b/k3k-kubelet/controller/service.go index 0703434e..23034aac 100644 --- a/k3k-kubelet/controller/service.go +++ b/k3k-kubelet/controller/service.go @@ -3,17 +3,19 @@ package controller import ( "context" - "github.com/rancher/k3k/k3k-kubelet/translate" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - v1 "k8s.io/api/core/v1" - apierrors "k8s.io/apimachinery/pkg/api/errors" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/types" - ctrl "sigs.k8s.io/controller-runtime" - ctrlruntimeclient "sigs.k8s.io/controller-runtime/pkg/client" "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil" "sigs.k8s.io/controller-runtime/pkg/manager" "sigs.k8s.io/controller-runtime/pkg/reconcile" + + v1 "k8s.io/api/core/v1" + apierrors "k8s.io/apimachinery/pkg/api/errors" + ctrl "sigs.k8s.io/controller-runtime" + ctrlruntimeclient "sigs.k8s.io/controller-runtime/pkg/client" + + "github.com/rancher/k3k/k3k-kubelet/translate" + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" ) const ( diff --git a/k3k-kubelet/controller/webhook/pod.go b/k3k-kubelet/controller/webhook/pod.go index bea10da0..44a59ed3 100644 --- a/k3k-kubelet/controller/webhook/pod.go +++ b/k3k-kubelet/controller/webhook/pod.go @@ -7,18 +7,20 @@ import ( "strconv" "strings" - "github.com/rancher/k3k/pkg/controller/cluster/agent" - "github.com/rancher/k3k/pkg/log" + "k8s.io/apimachinery/pkg/runtime" + "k8s.io/apimachinery/pkg/types" + "k8s.io/utils/ptr" + "sigs.k8s.io/controller-runtime/pkg/manager" + admissionregistrationv1 "k8s.io/api/admissionregistration/v1" v1 "k8s.io/api/core/v1" apierrors "k8s.io/apimachinery/pkg/api/errors" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" - "k8s.io/apimachinery/pkg/runtime" - "k8s.io/apimachinery/pkg/types" - "k8s.io/utils/ptr" ctrl "sigs.k8s.io/controller-runtime" ctrlruntimeclient "sigs.k8s.io/controller-runtime/pkg/client" - "sigs.k8s.io/controller-runtime/pkg/manager" + + "github.com/rancher/k3k/pkg/controller/cluster/agent" + "github.com/rancher/k3k/pkg/log" ) const ( @@ -100,9 +102,7 @@ func (w *webhookHandler) Default(ctx context.Context, obj runtime.Object) error func (w *webhookHandler) configuration(ctx context.Context, hostClient ctrlruntimeclient.Client) (*admissionregistrationv1.MutatingWebhookConfiguration, error) { w.logger.Infow("extracting webhook tls from host cluster") - var ( - webhookTLSSecret v1.Secret - ) + var webhookTLSSecret v1.Secret if err := hostClient.Get(ctx, types.NamespacedName{Name: agent.WebhookSecretName(w.clusterName), Namespace: w.clusterNamespace}, &webhookTLSSecret); err != nil { return nil, err diff --git a/k3k-kubelet/kubelet.go b/k3k-kubelet/kubelet.go index 8b6a53f9..dc9677de 100644 --- a/k3k-kubelet/kubelet.go +++ b/k3k-kubelet/kubelet.go @@ -12,7 +12,29 @@ import ( "time" "github.com/go-logr/zapr" + "github.com/virtual-kubelet/virtual-kubelet/log" + "github.com/virtual-kubelet/virtual-kubelet/node" + "github.com/virtual-kubelet/virtual-kubelet/node/nodeutil" + "go.uber.org/zap" + "k8s.io/apimachinery/pkg/runtime" + "k8s.io/apimachinery/pkg/types" + "k8s.io/apiserver/pkg/authentication/user" + "k8s.io/client-go/kubernetes" + "k8s.io/client-go/rest" + "k8s.io/client-go/tools/clientcmd" + "k8s.io/client-go/util/retry" + "sigs.k8s.io/controller-runtime/pkg/cache" + "sigs.k8s.io/controller-runtime/pkg/manager" + "sigs.k8s.io/controller-runtime/pkg/webhook" + certutil "github.com/rancher/dynamiclistener/cert" + v1 "k8s.io/api/core/v1" + clientgoscheme "k8s.io/client-go/kubernetes/scheme" + clientcmdapi "k8s.io/client-go/tools/clientcmd/api" + ctrl "sigs.k8s.io/controller-runtime" + ctrlruntimeclient "sigs.k8s.io/controller-runtime/pkg/client" + ctrlserver "sigs.k8s.io/controller-runtime/pkg/metrics/server" + k3kkubeletcontroller "github.com/rancher/k3k/k3k-kubelet/controller" k3kwebhook "github.com/rancher/k3k/k3k-kubelet/controller/webhook" "github.com/rancher/k3k/k3k-kubelet/provider" @@ -22,26 +44,6 @@ import ( "github.com/rancher/k3k/pkg/controller/cluster/server" "github.com/rancher/k3k/pkg/controller/cluster/server/bootstrap" k3klog "github.com/rancher/k3k/pkg/log" - "github.com/virtual-kubelet/virtual-kubelet/log" - "github.com/virtual-kubelet/virtual-kubelet/node" - "github.com/virtual-kubelet/virtual-kubelet/node/nodeutil" - "go.uber.org/zap" - v1 "k8s.io/api/core/v1" - "k8s.io/apimachinery/pkg/runtime" - "k8s.io/apimachinery/pkg/types" - "k8s.io/apiserver/pkg/authentication/user" - "k8s.io/client-go/kubernetes" - clientgoscheme "k8s.io/client-go/kubernetes/scheme" - "k8s.io/client-go/rest" - "k8s.io/client-go/tools/clientcmd" - clientcmdapi "k8s.io/client-go/tools/clientcmd/api" - "k8s.io/client-go/util/retry" - ctrl "sigs.k8s.io/controller-runtime" - "sigs.k8s.io/controller-runtime/pkg/cache" - ctrlruntimeclient "sigs.k8s.io/controller-runtime/pkg/client" - "sigs.k8s.io/controller-runtime/pkg/manager" - ctrlserver "sigs.k8s.io/controller-runtime/pkg/metrics/server" - "sigs.k8s.io/controller-runtime/pkg/webhook" ) var ( diff --git a/k3k-kubelet/main.go b/k3k-kubelet/main.go index e2f4ff9d..e94cb97c 100644 --- a/k3k-kubelet/main.go +++ b/k3k-kubelet/main.go @@ -5,11 +5,13 @@ import ( "os" "github.com/go-logr/zapr" - "github.com/rancher/k3k/pkg/log" "github.com/sirupsen/logrus" "github.com/urfave/cli/v2" "go.uber.org/zap" + ctrlruntimelog "sigs.k8s.io/controller-runtime/pkg/log" + + "github.com/rancher/k3k/pkg/log" ) var ( diff --git a/k3k-kubelet/provider/configure.go b/k3k-kubelet/provider/configure.go index cad5f4dd..cfbe7de5 100644 --- a/k3k-kubelet/provider/configure.go +++ b/k3k-kubelet/provider/configure.go @@ -4,14 +4,16 @@ import ( "context" "time" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - k3klog "github.com/rancher/k3k/pkg/log" - corev1 "k8s.io/api/core/v1" - metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/labels" "k8s.io/apimachinery/pkg/types" - typedv1 "k8s.io/client-go/kubernetes/typed/core/v1" "sigs.k8s.io/controller-runtime/pkg/client" + + corev1 "k8s.io/api/core/v1" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + typedv1 "k8s.io/client-go/kubernetes/typed/core/v1" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + k3klog "github.com/rancher/k3k/pkg/log" ) func ConfigureNode(logger *k3klog.Logger, node *corev1.Node, hostname string, servicePort int, ip string, coreClient typedv1.CoreV1Interface, virtualClient client.Client, virtualCluster v1alpha1.Cluster, version string, mirrorHostNodes bool) { diff --git a/k3k-kubelet/provider/provider.go b/k3k-kubelet/provider/provider.go index 186adce5..86d74985 100644 --- a/k3k-kubelet/provider/provider.go +++ b/k3k-kubelet/provider/provider.go @@ -3,6 +3,7 @@ package provider import ( "context" "encoding/json" + "errors" "fmt" "io" "maps" @@ -12,7 +13,31 @@ import ( "time" "github.com/google/go-cmp/cmp" + "github.com/virtual-kubelet/virtual-kubelet/node/api" + "github.com/virtual-kubelet/virtual-kubelet/node/nodeutil" + "k8s.io/apimachinery/pkg/labels" + "k8s.io/apimachinery/pkg/selection" + "k8s.io/apimachinery/pkg/types" + "k8s.io/apimachinery/pkg/util/sets" + "k8s.io/apimachinery/pkg/util/wait" + "k8s.io/client-go/kubernetes/scheme" + "k8s.io/client-go/rest" + "k8s.io/client-go/tools/portforward" + "k8s.io/client-go/tools/remotecommand" + "k8s.io/client-go/transport/spdy" + "k8s.io/utils/ptr" + "sigs.k8s.io/controller-runtime/pkg/client" + "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil" + "sigs.k8s.io/controller-runtime/pkg/manager" + dto "github.com/prometheus/client_model/go" + corev1 "k8s.io/api/core/v1" + apierrors "k8s.io/apimachinery/pkg/api/errors" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + cv1 "k8s.io/client-go/kubernetes/typed/core/v1" + compbasemetrics "k8s.io/component-base/metrics" + stats "k8s.io/kubelet/pkg/apis/stats/v1alpha1" + "github.com/rancher/k3k/k3k-kubelet/controller" "github.com/rancher/k3k/k3k-kubelet/controller/webhook" "github.com/rancher/k3k/k3k-kubelet/provider/collectors" @@ -20,31 +45,6 @@ import ( "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" k3kcontroller "github.com/rancher/k3k/pkg/controller" k3klog "github.com/rancher/k3k/pkg/log" - "github.com/virtual-kubelet/virtual-kubelet/node/api" - "github.com/virtual-kubelet/virtual-kubelet/node/nodeutil" - corev1 "k8s.io/api/core/v1" - apierrors "k8s.io/apimachinery/pkg/api/errors" - metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" - "k8s.io/apimachinery/pkg/labels" - "k8s.io/apimachinery/pkg/selection" - "k8s.io/apimachinery/pkg/types" - "k8s.io/apimachinery/pkg/util/sets" - "k8s.io/apimachinery/pkg/util/wait" - "k8s.io/client-go/kubernetes/scheme" - cv1 "k8s.io/client-go/kubernetes/typed/core/v1" - stats "k8s.io/kubelet/pkg/apis/stats/v1alpha1" - "k8s.io/utils/ptr" - - "errors" - - "k8s.io/client-go/rest" - "k8s.io/client-go/tools/portforward" - "k8s.io/client-go/tools/remotecommand" - "k8s.io/client-go/transport/spdy" - compbasemetrics "k8s.io/component-base/metrics" - "sigs.k8s.io/controller-runtime/pkg/client" - "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil" - "sigs.k8s.io/controller-runtime/pkg/manager" ) // check at compile time if the Provider implements the nodeutil.Provider interface @@ -66,9 +66,7 @@ type Provider struct { logger *k3klog.Logger } -var ( - ErrRetryTimeout = errors.New("provider timed out") -) +var ErrRetryTimeout = errors.New("provider timed out") func New(hostConfig rest.Config, hostMgr, virtualMgr manager.Manager, logger *k3klog.Logger, namespace, name, serverIP, dnsIP string) (*Provider, error) { coreClient, err := cv1.NewForConfig(&hostConfig) diff --git a/k3k-kubelet/provider/token.go b/k3k-kubelet/provider/token.go index 9988a32c..878c7f64 100644 --- a/k3k-kubelet/provider/token.go +++ b/k3k-kubelet/provider/token.go @@ -5,12 +5,14 @@ import ( "fmt" "strings" - k3kcontroller "github.com/rancher/k3k/pkg/controller" + "k8s.io/apimachinery/pkg/types" + "k8s.io/utils/ptr" + corev1 "k8s.io/api/core/v1" apierrors "k8s.io/apimachinery/pkg/api/errors" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" - "k8s.io/apimachinery/pkg/types" - "k8s.io/utils/ptr" + + k3kcontroller "github.com/rancher/k3k/pkg/controller" ) const ( @@ -144,7 +146,7 @@ func removeKubeAccessVolume(pod *corev1.Pod) { } func addKubeAccessVolume(pod *corev1.Pod, hostSecretName string) { - var tokenVolumeName = k3kcontroller.SafeConcatNameWithPrefix(kubeAPIAccessPrefix) + tokenVolumeName := k3kcontroller.SafeConcatNameWithPrefix(kubeAPIAccessPrefix) pod.Spec.Volumes = append(pod.Spec.Volumes, corev1.Volume{ Name: tokenVolumeName, diff --git a/k3k-kubelet/translate/host.go b/k3k-kubelet/translate/host.go index ee0fef61..d9b88c0d 100644 --- a/k3k-kubelet/translate/host.go +++ b/k3k-kubelet/translate/host.go @@ -4,8 +4,9 @@ import ( "encoding/hex" "strings" - "github.com/rancher/k3k/pkg/controller" "sigs.k8s.io/controller-runtime/pkg/client" + + "github.com/rancher/k3k/pkg/controller" ) const ( diff --git a/main.go b/main.go index 0a81bf90..086c1805 100644 --- a/main.go +++ b/main.go @@ -8,6 +8,17 @@ import ( "os" "github.com/go-logr/zapr" + "github.com/urfave/cli/v2" + "go.uber.org/zap" + "k8s.io/apimachinery/pkg/runtime" + "k8s.io/client-go/tools/clientcmd" + "sigs.k8s.io/controller-runtime/pkg/manager" + + v1 "k8s.io/api/core/v1" + clientgoscheme "k8s.io/client-go/kubernetes/scheme" + ctrl "sigs.k8s.io/controller-runtime" + ctrlruntimelog "sigs.k8s.io/controller-runtime/pkg/log" + "github.com/rancher/k3k/cli/cmds" "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" "github.com/rancher/k3k/pkg/buildinfo" @@ -15,15 +26,6 @@ import ( "github.com/rancher/k3k/pkg/controller/cluster/agent" "github.com/rancher/k3k/pkg/controller/policy" "github.com/rancher/k3k/pkg/log" - "github.com/urfave/cli/v2" - "go.uber.org/zap" - v1 "k8s.io/api/core/v1" - "k8s.io/apimachinery/pkg/runtime" - clientgoscheme "k8s.io/client-go/kubernetes/scheme" - "k8s.io/client-go/tools/clientcmd" - ctrl "sigs.k8s.io/controller-runtime" - ctrlruntimelog "sigs.k8s.io/controller-runtime/pkg/log" - "sigs.k8s.io/controller-runtime/pkg/manager" ) var ( diff --git a/pkg/apis/k3k.io/register.go b/pkg/apis/k3k.io/register.go index 77daf78e..a776e53c 100644 --- a/pkg/apis/k3k.io/register.go +++ b/pkg/apis/k3k.io/register.go @@ -1,5 +1,3 @@ package k3k -var ( - GroupName = "k3k.io" -) +var GroupName = "k3k.io" diff --git a/pkg/apis/k3k.io/v1alpha1/register.go b/pkg/apis/k3k.io/v1alpha1/register.go index 2cfe03c5..d2346b4a 100644 --- a/pkg/apis/k3k.io/v1alpha1/register.go +++ b/pkg/apis/k3k.io/v1alpha1/register.go @@ -1,10 +1,12 @@ package v1alpha1 import ( - k3k "github.com/rancher/k3k/pkg/apis/k3k.io" - metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime/schema" + + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + + k3k "github.com/rancher/k3k/pkg/apis/k3k.io" ) var ( diff --git a/pkg/apis/k3k.io/v1alpha1/types.go b/pkg/apis/k3k.io/v1alpha1/types.go index 645c7757..424014c6 100644 --- a/pkg/apis/k3k.io/v1alpha1/types.go +++ b/pkg/apis/k3k.io/v1alpha1/types.go @@ -447,7 +447,6 @@ type VirtualClusterPolicy struct { // VirtualClusterPolicySpec defines the desired state of a VirtualClusterPolicy. type VirtualClusterPolicySpec struct { - // Quota specifies the resource limits for clusters within a clusterpolicy. // // +optional diff --git a/pkg/controller/cluster/agent/agent.go b/pkg/controller/cluster/agent/agent.go index 937f5b4b..5958e0fe 100644 --- a/pkg/controller/cluster/agent/agent.go +++ b/pkg/controller/cluster/agent/agent.go @@ -4,13 +4,15 @@ import ( "context" "fmt" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - "github.com/rancher/k3k/pkg/controller" - apierrors "k8s.io/apimachinery/pkg/api/errors" "k8s.io/apimachinery/pkg/runtime" + "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil" + + apierrors "k8s.io/apimachinery/pkg/api/errors" ctrl "sigs.k8s.io/controller-runtime" ctrlruntimeclient "sigs.k8s.io/controller-runtime/pkg/client" - "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + "github.com/rancher/k3k/pkg/controller" ) const ( diff --git a/pkg/controller/cluster/agent/ports.go b/pkg/controller/cluster/agent/ports.go index 649b688f..3f27e9ad 100644 --- a/pkg/controller/cluster/agent/ports.go +++ b/pkg/controller/cluster/agent/ports.go @@ -6,14 +6,15 @@ import ( "os" "gopkg.in/yaml.v2" - v1 "k8s.io/api/core/v1" - apierrors "k8s.io/apimachinery/pkg/api/errors" "k8s.io/apimachinery/pkg/types" "k8s.io/kubernetes/pkg/apis/core" "k8s.io/kubernetes/pkg/registry/core/service/portallocator" + "sigs.k8s.io/controller-runtime/pkg/manager" + + v1 "k8s.io/api/core/v1" + apierrors "k8s.io/apimachinery/pkg/api/errors" ctrl "sigs.k8s.io/controller-runtime" ctrlruntimeclient "sigs.k8s.io/controller-runtime/pkg/client" - "sigs.k8s.io/controller-runtime/pkg/manager" ) const ( diff --git a/pkg/controller/cluster/agent/shared.go b/pkg/controller/cluster/agent/shared.go index 09daad50..a0c8830e 100644 --- a/pkg/controller/cluster/agent/shared.go +++ b/pkg/controller/cluster/agent/shared.go @@ -8,18 +8,20 @@ import ( "fmt" "time" + "k8s.io/apimachinery/pkg/util/intstr" + certutil "github.com/rancher/dynamiclistener/cert" - "github.com/rancher/k3k/k3k-kubelet/translate" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - "github.com/rancher/k3k/pkg/controller" - "github.com/rancher/k3k/pkg/controller/certs" apps "k8s.io/api/apps/v1" v1 "k8s.io/api/core/v1" rbacv1 "k8s.io/api/rbac/v1" apierrors "k8s.io/apimachinery/pkg/api/errors" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" - "k8s.io/apimachinery/pkg/util/intstr" ctrlruntimeclient "sigs.k8s.io/controller-runtime/pkg/client" + + "github.com/rancher/k3k/k3k-kubelet/translate" + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + "github.com/rancher/k3k/pkg/controller" + "github.com/rancher/k3k/pkg/controller/certs" ) const ( diff --git a/pkg/controller/cluster/agent/shared_test.go b/pkg/controller/cluster/agent/shared_test.go index d07250a5..39260843 100644 --- a/pkg/controller/cluster/agent/shared_test.go +++ b/pkg/controller/cluster/agent/shared_test.go @@ -3,10 +3,12 @@ package agent import ( "testing" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" "github.com/stretchr/testify/assert" "gopkg.in/yaml.v2" + v1 "k8s.io/apimachinery/pkg/apis/meta/v1" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" ) func Test_sharedAgentData(t *testing.T) { diff --git a/pkg/controller/cluster/agent/virtual.go b/pkg/controller/cluster/agent/virtual.go index ddec2f73..ba9b475a 100644 --- a/pkg/controller/cluster/agent/virtual.go +++ b/pkg/controller/cluster/agent/virtual.go @@ -5,12 +5,14 @@ import ( "errors" "fmt" - "github.com/rancher/k3k/pkg/controller" + "k8s.io/utils/ptr" + apps "k8s.io/api/apps/v1" v1 "k8s.io/api/core/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" - "k8s.io/utils/ptr" ctrlruntimeclient "sigs.k8s.io/controller-runtime/pkg/client" + + "github.com/rancher/k3k/pkg/controller" ) const ( diff --git a/pkg/controller/cluster/cluster.go b/pkg/controller/cluster/cluster.go index b71debc5..51ebd8b8 100644 --- a/pkg/controller/cluster/cluster.go +++ b/pkg/controller/cluster/cluster.go @@ -5,11 +5,34 @@ import ( "errors" "fmt" "net" - "slices" "strings" "time" + "k8s.io/apimachinery/pkg/api/equality" + "k8s.io/apimachinery/pkg/api/meta" + "k8s.io/apimachinery/pkg/runtime" + "k8s.io/apimachinery/pkg/types" + "k8s.io/client-go/discovery" + "k8s.io/client-go/tools/clientcmd" + "k8s.io/client-go/tools/record" + "k8s.io/client-go/util/workqueue" + "sigs.k8s.io/controller-runtime/pkg/client" + "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil" + "sigs.k8s.io/controller-runtime/pkg/event" + "sigs.k8s.io/controller-runtime/pkg/handler" + "sigs.k8s.io/controller-runtime/pkg/manager" + "sigs.k8s.io/controller-runtime/pkg/reconcile" + + apps "k8s.io/api/apps/v1" + v1 "k8s.io/api/core/v1" + networkingv1 "k8s.io/api/networking/v1" + rbacv1 "k8s.io/api/rbac/v1" + apierrors "k8s.io/apimachinery/pkg/api/errors" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + ctrl "sigs.k8s.io/controller-runtime" + ctrlcontroller "sigs.k8s.io/controller-runtime/pkg/controller" + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" "github.com/rancher/k3k/pkg/controller" "github.com/rancher/k3k/pkg/controller/cluster/agent" @@ -17,29 +40,6 @@ import ( "github.com/rancher/k3k/pkg/controller/cluster/server/bootstrap" "github.com/rancher/k3k/pkg/controller/kubeconfig" "github.com/rancher/k3k/pkg/controller/policy" - apps "k8s.io/api/apps/v1" - v1 "k8s.io/api/core/v1" - networkingv1 "k8s.io/api/networking/v1" - rbacv1 "k8s.io/api/rbac/v1" - "k8s.io/apimachinery/pkg/api/equality" - apierrors "k8s.io/apimachinery/pkg/api/errors" - "k8s.io/apimachinery/pkg/api/meta" - metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" - - "k8s.io/apimachinery/pkg/runtime" - "k8s.io/apimachinery/pkg/types" - "k8s.io/client-go/discovery" - "k8s.io/client-go/tools/clientcmd" - "k8s.io/client-go/tools/record" - "k8s.io/client-go/util/workqueue" - ctrl "sigs.k8s.io/controller-runtime" - "sigs.k8s.io/controller-runtime/pkg/client" - ctrlcontroller "sigs.k8s.io/controller-runtime/pkg/controller" - "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil" - "sigs.k8s.io/controller-runtime/pkg/event" - "sigs.k8s.io/controller-runtime/pkg/handler" - "sigs.k8s.io/controller-runtime/pkg/manager" - "sigs.k8s.io/controller-runtime/pkg/reconcile" ) const ( diff --git a/pkg/controller/cluster/cluster_finalize.go b/pkg/controller/cluster/cluster_finalize.go index 67677aa6..78319c25 100644 --- a/pkg/controller/cluster/cluster_finalize.go +++ b/pkg/controller/cluster/cluster_finalize.go @@ -7,17 +7,18 @@ import ( "reflect" "slices" + "k8s.io/apimachinery/pkg/api/meta" + "k8s.io/apimachinery/pkg/types" + "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil" + "sigs.k8s.io/controller-runtime/pkg/reconcile" + + rbacv1 "k8s.io/api/rbac/v1" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + ctrl "sigs.k8s.io/controller-runtime" + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" "github.com/rancher/k3k/pkg/controller" "github.com/rancher/k3k/pkg/controller/cluster/agent" - - rbacv1 "k8s.io/api/rbac/v1" - "k8s.io/apimachinery/pkg/api/meta" - metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" - "k8s.io/apimachinery/pkg/types" - ctrl "sigs.k8s.io/controller-runtime" - "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil" - "sigs.k8s.io/controller-runtime/pkg/reconcile" ) func (c *ClusterReconciler) finalizeCluster(ctx context.Context, cluster *v1alpha1.Cluster) (reconcile.Result, error) { diff --git a/pkg/controller/cluster/cluster_suite_test.go b/pkg/controller/cluster/cluster_suite_test.go index 010d2087..3014477b 100644 --- a/pkg/controller/cluster/cluster_suite_test.go +++ b/pkg/controller/cluster/cluster_suite_test.go @@ -7,19 +7,20 @@ import ( "testing" "github.com/go-logr/zapr" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - "github.com/rancher/k3k/pkg/controller/cluster" - "github.com/rancher/k3k/pkg/controller/cluster/agent" - "go.uber.org/zap" "k8s.io/apimachinery/pkg/runtime" "k8s.io/client-go/kubernetes" - clientgoscheme "k8s.io/client-go/kubernetes/scheme" "k8s.io/client-go/tools/record" - ctrl "sigs.k8s.io/controller-runtime" "sigs.k8s.io/controller-runtime/pkg/client" "sigs.k8s.io/controller-runtime/pkg/envtest" + clientgoscheme "k8s.io/client-go/kubernetes/scheme" + ctrl "sigs.k8s.io/controller-runtime" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + "github.com/rancher/k3k/pkg/controller/cluster" + "github.com/rancher/k3k/pkg/controller/cluster/agent" + . "github.com/onsi/ginkgo/v2" . "github.com/onsi/gomega" ) @@ -38,7 +39,6 @@ var ( ) var _ = BeforeSuite(func() { - By("bootstrapping test environment") testEnv = &envtest.Environment{ CRDDirectoryPaths: []string{filepath.Join("..", "..", "..", "charts", "k3k", "crds")}, diff --git a/pkg/controller/cluster/cluster_test.go b/pkg/controller/cluster/cluster_test.go index 5f1b2842..1201b3b4 100644 --- a/pkg/controller/cluster/cluster_test.go +++ b/pkg/controller/cluster/cluster_test.go @@ -5,24 +5,23 @@ import ( "fmt" "time" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - k3kcontroller "github.com/rancher/k3k/pkg/controller" - "github.com/rancher/k3k/pkg/controller/cluster/server" + "k8s.io/utils/ptr" "sigs.k8s.io/controller-runtime/pkg/client" corev1 "k8s.io/api/core/v1" networkingv1 "k8s.io/api/networking/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" - "k8s.io/utils/ptr" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + k3kcontroller "github.com/rancher/k3k/pkg/controller" + "github.com/rancher/k3k/pkg/controller/cluster/server" . "github.com/onsi/ginkgo/v2" . "github.com/onsi/gomega" ) var _ = Describe("Cluster Controller", Label("controller"), Label("Cluster"), func() { - Context("creating a Cluster", func() { - var ( namespace string ctx context.Context @@ -38,7 +37,6 @@ var _ = Describe("Cluster Controller", Label("controller"), Label("Cluster"), fu }) When("creating a Cluster", func() { - It("will be created with some defaults", func() { cluster := &v1alpha1.Cluster{ ObjectMeta: metav1.ObjectMeta{ @@ -68,7 +66,6 @@ var _ = Describe("Cluster Controller", Label("controller"), Label("Cluster"), fu err := k8sClient.Get(ctx, client.ObjectKeyFromObject(cluster), cluster) Expect(err).To(Not(HaveOccurred())) return cluster.Status.HostVersion - }). WithTimeout(time.Second * 30). WithPolling(time.Second). @@ -217,7 +214,6 @@ var _ = Describe("Cluster Controller", Label("controller"), Label("Cluster"), fu Expect(serverPort.Port).To(BeEquivalentTo(443)) Expect(serverPort.TargetPort.IntValue()).To(BeEquivalentTo(6443)) }) - }) When("exposing the cluster with loadbalancer", func() { diff --git a/pkg/controller/cluster/pod.go b/pkg/controller/cluster/pod.go index db8cb4af..47f28399 100644 --- a/pkg/controller/cluster/pod.go +++ b/pkg/controller/cluster/pod.go @@ -9,27 +9,29 @@ import ( "net/url" "strings" - certutil "github.com/rancher/dynamiclistener/cert" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - k3kcontroller "github.com/rancher/k3k/pkg/controller" - "github.com/rancher/k3k/pkg/controller/certs" - "github.com/rancher/k3k/pkg/controller/cluster/server" - "github.com/rancher/k3k/pkg/controller/cluster/server/bootstrap" "go.etcd.io/etcd/api/v3/v3rpc/rpctypes" - clientv3 "go.etcd.io/etcd/client/v3" - apps "k8s.io/api/apps/v1" - v1 "k8s.io/api/core/v1" - apierrors "k8s.io/apimachinery/pkg/api/errors" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/types" "k8s.io/client-go/util/retry" - ctrl "sigs.k8s.io/controller-runtime" - ctrlruntimeclient "sigs.k8s.io/controller-runtime/pkg/client" "sigs.k8s.io/controller-runtime/pkg/controller" "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil" "sigs.k8s.io/controller-runtime/pkg/handler" "sigs.k8s.io/controller-runtime/pkg/manager" "sigs.k8s.io/controller-runtime/pkg/reconcile" + + certutil "github.com/rancher/dynamiclistener/cert" + clientv3 "go.etcd.io/etcd/client/v3" + apps "k8s.io/api/apps/v1" + v1 "k8s.io/api/core/v1" + apierrors "k8s.io/apimachinery/pkg/api/errors" + ctrl "sigs.k8s.io/controller-runtime" + ctrlruntimeclient "sigs.k8s.io/controller-runtime/pkg/client" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + k3kcontroller "github.com/rancher/k3k/pkg/controller" + "github.com/rancher/k3k/pkg/controller/certs" + "github.com/rancher/k3k/pkg/controller/cluster/server" + "github.com/rancher/k3k/pkg/controller/cluster/server/bootstrap" ) const ( diff --git a/pkg/controller/cluster/server/bootstrap/bootstrap.go b/pkg/controller/cluster/server/bootstrap/bootstrap.go index f49b69c7..76251700 100644 --- a/pkg/controller/cluster/server/bootstrap/bootstrap.go +++ b/pkg/controller/cluster/server/bootstrap/bootstrap.go @@ -11,11 +11,13 @@ import ( "syscall" "time" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - "github.com/rancher/k3k/pkg/controller" - v1 "k8s.io/api/core/v1" "k8s.io/apimachinery/pkg/types" "sigs.k8s.io/controller-runtime/pkg/client" + + v1 "k8s.io/api/core/v1" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + "github.com/rancher/k3k/pkg/controller" ) var ErrServerNotReady = errors.New("server not ready") @@ -96,7 +98,7 @@ func basicAuth(username, password string) string { } func decodeBootstrap(bootstrap *ControlRuntimeBootstrap) error { - //client-ca + // client-ca decoded, err := base64.StdEncoding.DecodeString(bootstrap.ClientCA.Content) if err != nil { return err @@ -104,7 +106,7 @@ func decodeBootstrap(bootstrap *ControlRuntimeBootstrap) error { bootstrap.ClientCA.Content = string(decoded) - //client-ca-key + // client-ca-key decoded, err = base64.StdEncoding.DecodeString(bootstrap.ClientCAKey.Content) if err != nil { return err @@ -112,7 +114,7 @@ func decodeBootstrap(bootstrap *ControlRuntimeBootstrap) error { bootstrap.ClientCAKey.Content = string(decoded) - //server-ca + // server-ca decoded, err = base64.StdEncoding.DecodeString(bootstrap.ServerCA.Content) if err != nil { return err @@ -120,7 +122,7 @@ func decodeBootstrap(bootstrap *ControlRuntimeBootstrap) error { bootstrap.ServerCA.Content = string(decoded) - //server-ca-key + // server-ca-key decoded, err = base64.StdEncoding.DecodeString(bootstrap.ServerCAKey.Content) if err != nil { return err @@ -128,7 +130,7 @@ func decodeBootstrap(bootstrap *ControlRuntimeBootstrap) error { bootstrap.ServerCAKey.Content = string(decoded) - //etcd-ca + // etcd-ca decoded, err = base64.StdEncoding.DecodeString(bootstrap.ETCDServerCA.Content) if err != nil { return err @@ -136,7 +138,7 @@ func decodeBootstrap(bootstrap *ControlRuntimeBootstrap) error { bootstrap.ETCDServerCA.Content = string(decoded) - //etcd-ca-key + // etcd-ca-key decoded, err = base64.StdEncoding.DecodeString(bootstrap.ETCDServerCAKey.Content) if err != nil { return err diff --git a/pkg/controller/cluster/server/config.go b/pkg/controller/cluster/server/config.go index 70bd8da7..178d2b4d 100644 --- a/pkg/controller/cluster/server/config.go +++ b/pkg/controller/cluster/server/config.go @@ -3,12 +3,14 @@ package server import ( "fmt" + "k8s.io/apimachinery/pkg/util/sets" + + v1 "k8s.io/api/core/v1" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" "github.com/rancher/k3k/pkg/controller" "github.com/rancher/k3k/pkg/controller/cluster/agent" - v1 "k8s.io/api/core/v1" - metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" - "k8s.io/apimachinery/pkg/util/sets" ) func (s *Server) Config(init bool, serviceIP string) (*v1.Secret, error) { diff --git a/pkg/controller/cluster/server/ingress.go b/pkg/controller/cluster/server/ingress.go index 0d041012..7e7cf1ea 100644 --- a/pkg/controller/cluster/server/ingress.go +++ b/pkg/controller/cluster/server/ingress.go @@ -3,11 +3,13 @@ package server import ( "context" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - "github.com/rancher/k3k/pkg/controller" + "k8s.io/utils/ptr" + networkingv1 "k8s.io/api/networking/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" - "k8s.io/utils/ptr" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + "github.com/rancher/k3k/pkg/controller" ) const ( diff --git a/pkg/controller/cluster/server/server.go b/pkg/controller/cluster/server/server.go index 2087584f..30d3d202 100644 --- a/pkg/controller/cluster/server/server.go +++ b/pkg/controller/cluster/server/server.go @@ -8,17 +8,19 @@ import ( "strings" "text/template" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - "github.com/rancher/k3k/pkg/controller" - "github.com/rancher/k3k/pkg/controller/cluster/agent" - apps "k8s.io/api/apps/v1" - v1 "k8s.io/api/core/v1" "k8s.io/apimachinery/pkg/api/resource" - metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/types" "k8s.io/apimachinery/pkg/util/intstr" "k8s.io/utils/ptr" "sigs.k8s.io/controller-runtime/pkg/client" + + apps "k8s.io/api/apps/v1" + v1 "k8s.io/api/core/v1" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + "github.com/rancher/k3k/pkg/controller" + "github.com/rancher/k3k/pkg/controller/cluster/agent" ) const ( diff --git a/pkg/controller/cluster/server/service.go b/pkg/controller/cluster/server/service.go index 7d96e722..8d69828a 100644 --- a/pkg/controller/cluster/server/service.go +++ b/pkg/controller/cluster/server/service.go @@ -1,11 +1,13 @@ package server import ( - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - "github.com/rancher/k3k/pkg/controller" + "k8s.io/apimachinery/pkg/util/intstr" + v1 "k8s.io/api/core/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" - "k8s.io/apimachinery/pkg/util/intstr" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + "github.com/rancher/k3k/pkg/controller" ) func Service(cluster *v1alpha1.Cluster) *v1.Service { diff --git a/pkg/controller/cluster/status.go b/pkg/controller/cluster/status.go index cce215f6..c85b1d7c 100644 --- a/pkg/controller/cluster/status.go +++ b/pkg/controller/cluster/status.go @@ -3,11 +3,13 @@ package cluster import ( "errors" + "k8s.io/apimachinery/pkg/api/meta" + + v1 "k8s.io/api/core/v1" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" "github.com/rancher/k3k/pkg/controller/cluster/server/bootstrap" - v1 "k8s.io/api/core/v1" - "k8s.io/apimachinery/pkg/api/meta" - metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" ) const ( diff --git a/pkg/controller/cluster/token.go b/pkg/controller/cluster/token.go index a8650b41..a431951e 100644 --- a/pkg/controller/cluster/token.go +++ b/pkg/controller/cluster/token.go @@ -6,15 +6,17 @@ import ( "encoding/hex" "fmt" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - "github.com/rancher/k3k/pkg/controller" + "k8s.io/apimachinery/pkg/types" + "sigs.k8s.io/controller-runtime/pkg/client" + "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil" + v1 "k8s.io/api/core/v1" apierrors "k8s.io/apimachinery/pkg/api/errors" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" - "k8s.io/apimachinery/pkg/types" ctrl "sigs.k8s.io/controller-runtime" - "sigs.k8s.io/controller-runtime/pkg/client" - "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + "github.com/rancher/k3k/pkg/controller" ) func (c *ClusterReconciler) token(ctx context.Context, cluster *v1alpha1.Cluster) (string, error) { diff --git a/pkg/controller/controller.go b/pkg/controller/controller.go index eaaae838..7a7c6d82 100644 --- a/pkg/controller/controller.go +++ b/pkg/controller/controller.go @@ -7,8 +7,9 @@ import ( "strings" "time" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" "k8s.io/apimachinery/pkg/util/wait" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" ) const ( diff --git a/pkg/controller/kubeconfig/kubeconfig.go b/pkg/controller/kubeconfig/kubeconfig.go index 20a03619..2b159680 100644 --- a/pkg/controller/kubeconfig/kubeconfig.go +++ b/pkg/controller/kubeconfig/kubeconfig.go @@ -7,19 +7,21 @@ import ( "slices" "time" + "github.com/sirupsen/logrus" + "k8s.io/apimachinery/pkg/types" + "k8s.io/apiserver/pkg/authentication/user" + "sigs.k8s.io/controller-runtime/pkg/client" + certutil "github.com/rancher/dynamiclistener/cert" + v1 "k8s.io/api/core/v1" + networkingv1 "k8s.io/api/networking/v1" + clientcmdapi "k8s.io/client-go/tools/clientcmd/api" + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" "github.com/rancher/k3k/pkg/controller" "github.com/rancher/k3k/pkg/controller/certs" "github.com/rancher/k3k/pkg/controller/cluster/server" "github.com/rancher/k3k/pkg/controller/cluster/server/bootstrap" - "github.com/sirupsen/logrus" - v1 "k8s.io/api/core/v1" - networkingv1 "k8s.io/api/networking/v1" - "k8s.io/apimachinery/pkg/types" - "k8s.io/apiserver/pkg/authentication/user" - clientcmdapi "k8s.io/client-go/tools/clientcmd/api" - "sigs.k8s.io/controller-runtime/pkg/client" ) type KubeConfig struct { diff --git a/pkg/controller/policy/namespace.go b/pkg/controller/policy/namespace.go index f2288f2f..a74d53e4 100644 --- a/pkg/controller/policy/namespace.go +++ b/pkg/controller/policy/namespace.go @@ -3,13 +3,15 @@ package policy import ( "context" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - v1 "k8s.io/api/core/v1" - networkingv1 "k8s.io/api/networking/v1" "k8s.io/apimachinery/pkg/labels" "k8s.io/apimachinery/pkg/selection" - ctrl "sigs.k8s.io/controller-runtime" "sigs.k8s.io/controller-runtime/pkg/client" + + v1 "k8s.io/api/core/v1" + networkingv1 "k8s.io/api/networking/v1" + ctrl "sigs.k8s.io/controller-runtime" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" ) // reconcileNamespacePodSecurityLabels will update the labels of the namespace to reconcile the PSA level specified in the VirtualClusterPolicy diff --git a/pkg/controller/policy/networkpolicy.go b/pkg/controller/policy/networkpolicy.go index 6aa9a9f3..02ac1939 100644 --- a/pkg/controller/policy/networkpolicy.go +++ b/pkg/controller/policy/networkpolicy.go @@ -3,14 +3,16 @@ package policy import ( "context" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - k3kcontroller "github.com/rancher/k3k/pkg/controller" + "sigs.k8s.io/controller-runtime/pkg/client" + v1 "k8s.io/api/core/v1" networkingv1 "k8s.io/api/networking/v1" apierrors "k8s.io/apimachinery/pkg/api/errors" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" ctrl "sigs.k8s.io/controller-runtime" - "sigs.k8s.io/controller-runtime/pkg/client" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + k3kcontroller "github.com/rancher/k3k/pkg/controller" ) func (c *VirtualClusterPolicyReconciler) reconcileNetworkPolicy(ctx context.Context, namespace string, policy *v1alpha1.VirtualClusterPolicy) error { diff --git a/pkg/controller/policy/policy.go b/pkg/controller/policy/policy.go index 6b9d5344..779883d2 100644 --- a/pkg/controller/policy/policy.go +++ b/pkg/controller/policy/policy.go @@ -5,22 +5,24 @@ import ( "errors" "reflect" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - k3kcontroller "github.com/rancher/k3k/pkg/controller" - v1 "k8s.io/api/core/v1" - networkingv1 "k8s.io/api/networking/v1" - apierrors "k8s.io/apimachinery/pkg/api/errors" - metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/types" "k8s.io/client-go/util/workqueue" - ctrl "sigs.k8s.io/controller-runtime" "sigs.k8s.io/controller-runtime/pkg/client" "sigs.k8s.io/controller-runtime/pkg/controller" "sigs.k8s.io/controller-runtime/pkg/event" "sigs.k8s.io/controller-runtime/pkg/handler" "sigs.k8s.io/controller-runtime/pkg/manager" "sigs.k8s.io/controller-runtime/pkg/reconcile" + + v1 "k8s.io/api/core/v1" + networkingv1 "k8s.io/api/networking/v1" + apierrors "k8s.io/apimachinery/pkg/api/errors" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + ctrl "sigs.k8s.io/controller-runtime" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + k3kcontroller "github.com/rancher/k3k/pkg/controller" ) const ( diff --git a/pkg/controller/policy/policy_suite_test.go b/pkg/controller/policy/policy_suite_test.go index 03ea70b3..ce4b536e 100644 --- a/pkg/controller/policy/policy_suite_test.go +++ b/pkg/controller/policy/policy_suite_test.go @@ -6,17 +6,18 @@ import ( "testing" "github.com/go-logr/zapr" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - "github.com/rancher/k3k/pkg/controller/policy" - "go.uber.org/zap" + "k8s.io/apimachinery/pkg/runtime" + "sigs.k8s.io/controller-runtime/pkg/client" + "sigs.k8s.io/controller-runtime/pkg/envtest" + appsv1 "k8s.io/api/apps/v1" corev1 "k8s.io/api/core/v1" networkingv1 "k8s.io/api/networking/v1" - "k8s.io/apimachinery/pkg/runtime" ctrl "sigs.k8s.io/controller-runtime" - "sigs.k8s.io/controller-runtime/pkg/client" - "sigs.k8s.io/controller-runtime/pkg/envtest" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + "github.com/rancher/k3k/pkg/controller/policy" . "github.com/onsi/ginkgo/v2" . "github.com/onsi/gomega" @@ -35,7 +36,6 @@ var ( ) var _ = BeforeSuite(func() { - By("bootstrapping test environment") testEnv = &envtest.Environment{ CRDDirectoryPaths: []string{filepath.Join("..", "..", "..", "charts", "k3k", "crds")}, diff --git a/pkg/controller/policy/policy_test.go b/pkg/controller/policy/policy_test.go index 38f75a04..46a1bc95 100644 --- a/pkg/controller/policy/policy_test.go +++ b/pkg/controller/policy/policy_test.go @@ -5,26 +5,25 @@ import ( "reflect" "time" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" - "github.com/rancher/k3k/pkg/controller/policy" + "k8s.io/apimachinery/pkg/api/resource" + "k8s.io/apimachinery/pkg/types" + "k8s.io/utils/ptr" - k3kcontroller "github.com/rancher/k3k/pkg/controller" v1 "k8s.io/api/core/v1" networkingv1 "k8s.io/api/networking/v1" apierrors "k8s.io/apimachinery/pkg/api/errors" - "k8s.io/apimachinery/pkg/api/resource" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" - "k8s.io/apimachinery/pkg/types" - "k8s.io/utils/ptr" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + k3kcontroller "github.com/rancher/k3k/pkg/controller" + "github.com/rancher/k3k/pkg/controller/policy" . "github.com/onsi/ginkgo/v2" . "github.com/onsi/gomega" ) var _ = Describe("VirtualClusterPolicy Controller", Label("controller"), Label("VirtualClusterPolicy"), func() { - Context("creating a VirtualClusterPolicy", func() { - It("should have the 'shared' allowedMode", func() { policy := newPolicy(v1alpha1.VirtualClusterPolicySpec{}) Expect(policy.Spec.AllowedMode).To(Equal(v1alpha1.SharedClusterMode)) @@ -53,7 +52,6 @@ var _ = Describe("VirtualClusterPolicy Controller", Label("controller"), Label(" }) When("bound to a namespace", func() { - var namespace *v1.Namespace BeforeEach(func() { diff --git a/pkg/log/zap.go b/pkg/log/zap.go index 1e5599d4..f84d91e8 100644 --- a/pkg/log/zap.go +++ b/pkg/log/zap.go @@ -6,6 +6,7 @@ import ( "github.com/virtual-kubelet/virtual-kubelet/log" "go.uber.org/zap" "go.uber.org/zap/zapcore" + ctrlruntimezap "sigs.k8s.io/controller-runtime/pkg/log/zap" ) @@ -21,7 +22,7 @@ func (l *Logger) WithError(err error) log.Logger { return l } -func (l *Logger) WithField(string, interface{}) log.Logger { +func (l *Logger) WithField(string, any) log.Logger { return l } diff --git a/tests/cluster_network_test.go b/tests/cluster_network_test.go index 2e085da7..18e854aa 100644 --- a/tests/cluster_network_test.go +++ b/tests/cluster_network_test.go @@ -6,7 +6,6 @@ import ( ) var _ = When("two virtual clusters are installed", Label("e2e"), func() { - var ( cluster1 *VirtualCluster cluster2 *VirtualCluster @@ -23,7 +22,6 @@ var _ = When("two virtual clusters are installed", Label("e2e"), func() { }) It("can create pods in each of them that are isolated", func() { - pod1Cluster1, pod1Cluster1IP := cluster1.NewNginxPod("") pod2Cluster1, pod2Cluster1IP := cluster1.NewNginxPod("") pod1Cluster2, pod1Cluster2IP := cluster2.NewNginxPod("") diff --git a/tests/cluster_status_test.go b/tests/cluster_status_test.go index e2f4a002..95511f92 100644 --- a/tests/cluster_status_test.go +++ b/tests/cluster_status_test.go @@ -4,19 +4,21 @@ import ( "context" "time" - . "github.com/onsi/ginkgo/v2" - . "github.com/onsi/gomega" + "k8s.io/apimachinery/pkg/api/meta" + "sigs.k8s.io/controller-runtime/pkg/client" + + corev1 "k8s.io/api/core/v1" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" "github.com/rancher/k3k/pkg/controller/cluster" "github.com/rancher/k3k/pkg/controller/policy" - corev1 "k8s.io/api/core/v1" - "k8s.io/apimachinery/pkg/api/meta" - metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" - "sigs.k8s.io/controller-runtime/pkg/client" + + . "github.com/onsi/ginkgo/v2" + . "github.com/onsi/gomega" ) var _ = When("a cluster's status is tracked", Label("e2e"), func() { - var ( namespace *corev1.Namespace vcp *v1alpha1.VirtualClusterPolicy diff --git a/tests/cluster_test.go b/tests/cluster_test.go index 12967d1f..44136964 100644 --- a/tests/cluster_test.go +++ b/tests/cluster_test.go @@ -8,16 +8,17 @@ import ( "strings" "time" - . "github.com/onsi/ginkgo/v2" - . "github.com/onsi/gomega" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" corev1 "k8s.io/api/core/v1" v1 "k8s.io/apimachinery/pkg/apis/meta/v1" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + + . "github.com/onsi/ginkgo/v2" + . "github.com/onsi/gomega" ) var _ = When("k3k is installed", Label("e2e"), func() { It("is in Running status", func() { - // check that the controller is running Eventually(func() bool { opts := v1.ListOptions{LabelSelector: "app.kubernetes.io/name=k3k"} @@ -43,7 +44,6 @@ var _ = When("k3k is installed", Label("e2e"), func() { }) var _ = When("a ephemeral cluster is installed", Label("e2e"), func() { - var virtualCluster *VirtualCluster BeforeEach(func() { @@ -116,7 +116,6 @@ var _ = When("a ephemeral cluster is installed", Label("e2e"), func() { }) var _ = When("a dynamic cluster is installed", func() { - var virtualCluster *VirtualCluster BeforeEach(func() { diff --git a/tests/common_test.go b/tests/common_test.go index 919c5fcb..44250edb 100644 --- a/tests/common_test.go +++ b/tests/common_test.go @@ -8,19 +8,21 @@ import ( "sync" "time" + "k8s.io/client-go/kubernetes" + "k8s.io/client-go/rest" + "k8s.io/client-go/tools/clientcmd" + "k8s.io/client-go/tools/remotecommand" + "k8s.io/kubectl/pkg/scheme" + "k8s.io/utils/ptr" + + corev1 "k8s.io/api/core/v1" + v1 "k8s.io/apimachinery/pkg/apis/meta/v1" + clientcmdapi "k8s.io/client-go/tools/clientcmd/api" + "github.com/rancher/k3k/k3k-kubelet/translate" "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" "github.com/rancher/k3k/pkg/controller/certs" "github.com/rancher/k3k/pkg/controller/kubeconfig" - corev1 "k8s.io/api/core/v1" - v1 "k8s.io/apimachinery/pkg/apis/meta/v1" - "k8s.io/client-go/kubernetes" - "k8s.io/client-go/rest" - "k8s.io/client-go/tools/clientcmd" - clientcmdapi "k8s.io/client-go/tools/clientcmd/api" - "k8s.io/client-go/tools/remotecommand" - "k8s.io/kubectl/pkg/scheme" - "k8s.io/utils/ptr" . "github.com/onsi/ginkgo/v2" . "github.com/onsi/gomega" diff --git a/tests/k8s_restclientgetter_test.go b/tests/k8s_restclientgetter_test.go index 588b5f7a..fb30e01d 100644 --- a/tests/k8s_restclientgetter_test.go +++ b/tests/k8s_restclientgetter_test.go @@ -3,10 +3,11 @@ package k3k_test import ( "k8s.io/apimachinery/pkg/api/meta" "k8s.io/client-go/discovery" - memory "k8s.io/client-go/discovery/cached" "k8s.io/client-go/rest" "k8s.io/client-go/restmapper" "k8s.io/client-go/tools/clientcmd" + + memory "k8s.io/client-go/discovery/cached" ) type RESTClientGetter struct { diff --git a/tests/tests_suite_test.go b/tests/tests_suite_test.go index 1bf10ea2..14a82ac1 100644 --- a/tests/tests_suite_test.go +++ b/tests/tests_suite_test.go @@ -12,16 +12,11 @@ import ( "time" "github.com/go-logr/zapr" - . "github.com/onsi/ginkgo/v2" - . "github.com/onsi/gomega" - "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" "github.com/testcontainers/testcontainers-go" "github.com/testcontainers/testcontainers-go/modules/k3s" "go.uber.org/zap" "helm.sh/helm/v3/pkg/action" "helm.sh/helm/v3/pkg/chart/loader" - corev1 "k8s.io/api/core/v1" - metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime" "k8s.io/client-go/kubernetes" "k8s.io/client-go/rest" @@ -29,6 +24,14 @@ import ( "k8s.io/client-go/tools/remotecommand" "sigs.k8s.io/controller-runtime/pkg/client" "sigs.k8s.io/controller-runtime/pkg/log" + + corev1 "k8s.io/api/core/v1" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + + "github.com/rancher/k3k/pkg/apis/k3k.io/v1alpha1" + + . "github.com/onsi/ginkgo/v2" + . "github.com/onsi/gomega" ) func TestTests(t *testing.T) { @@ -96,7 +99,7 @@ func installK3kChart(kubeconfig []byte) { releaseName := "k3k" releaseNamespace := "k3k-system" - err = actionConfig.Init(restClientGetter, releaseNamespace, os.Getenv("HELM_DRIVER"), func(format string, v ...interface{}) { + err = actionConfig.Init(restClientGetter, releaseNamespace, os.Getenv("HELM_DRIVER"), func(format string, v ...any) { GinkgoWriter.Printf("helm debug: "+format+"\n", v...) }) Expect(err).To(Not(HaveOccurred())) @@ -140,7 +143,7 @@ var _ = AfterSuite(func() { Expect(err).To(Not(HaveOccurred())) logfile := path.Join(os.TempDir(), "k3s.log") - err = os.WriteFile(logfile, logs, 0644) + err = os.WriteFile(logfile, logs, 0o644) Expect(err).To(Not(HaveOccurred())) GinkgoWriter.Println("k3s logs written to: " + logfile) @@ -189,7 +192,7 @@ func writeLogs(filename string, logs io.ReadCloser) { Expect(err).To(Not(HaveOccurred())) tempfile := path.Join(os.TempDir(), filename) - err = os.WriteFile(tempfile, []byte(logsStr), 0644) + err = os.WriteFile(tempfile, []byte(logsStr), 0o644) Expect(err).To(Not(HaveOccurred())) GinkgoWriter.Println("logs written to: " + filename)