mirror of
https://github.com/bloomberg/goldpinger.git
synced 2026-05-24 09:32:45 +00:00
Address PR #169 review: DeletePeerMetrics only removed the "ping" call_type label set, leaving stale "check" samples from CheckAllPods in /metrics after a peer rolls. goldpingerResponseTimePeersHistogram is observed at two sites — Pinger (pinger.go:56, "ping") and CheckAllPods via GetLabeledPeersCallsTimer (client.go:209, "check") — so both must be pruned. Missed on the first pass because I traced the Pinger observation (the hot path) and did not separately check for the "check" label value emitted from the /check_all handler. Tests now seed both call_types before teardown so either gap regresses. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Cooper Ry Lees <me@cooperlees.com>