mirror of
https://github.com/fluxcd/flagger.git
synced 2026-04-15 06:57:34 +00:00
Sanskar Jaiswal
757d90121b
Modify `canary.IsPrimaryReady()` and `canary.Initialize()` to return a boolean indicating if the error is retriable. Modify the scheduler to rollback the analysis and mark the Canary object as failed if the above two functions or `canary.IsCanaryRead()` returns false along with an error. Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
138 lines
4.3 KiB
Go
138 lines
4.3 KiB
Go
/*
|
|
Copyright 2020 The Flux authors
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package canary
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
appsv1 "k8s.io/api/apps/v1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
|
|
flaggerv1 "github.com/fluxcd/flagger/pkg/apis/flagger/v1beta1"
|
|
)
|
|
|
|
func TestDaemonSetController_IsReady(t *testing.T) {
|
|
dc := daemonsetConfigs{name: "podinfo", label: "name", labelValue: "podinfo"}
|
|
mocks := newDaemonSetFixture(dc)
|
|
_, err := mocks.controller.Initialize(mocks.canary)
|
|
require.NoError(t, err)
|
|
|
|
_, err = mocks.controller.IsPrimaryReady(mocks.canary)
|
|
require.NoError(t, err)
|
|
|
|
_, err = mocks.controller.IsCanaryReady(mocks.canary)
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
func TestDaemonSetController_isDaemonSetReady(t *testing.T) {
|
|
dc := daemonsetConfigs{name: "podinfo", label: "name", labelValue: "podinfo"}
|
|
mocks := newDaemonSetFixture(dc)
|
|
cd := &flaggerv1.Canary{}
|
|
|
|
// observed generation is less than desired generation
|
|
ds := &appsv1.DaemonSet{Status: appsv1.DaemonSetStatus{}}
|
|
ds.Status.ObservedGeneration--
|
|
retryable, err := mocks.controller.isDaemonSetReady(cd, ds, 100)
|
|
require.Error(t, err)
|
|
require.True(t, retryable)
|
|
|
|
// succeeded
|
|
ds = &appsv1.DaemonSet{Status: appsv1.DaemonSetStatus{
|
|
UpdatedNumberScheduled: 1,
|
|
DesiredNumberScheduled: 1,
|
|
NumberAvailable: 1,
|
|
}}
|
|
retryable, err = mocks.controller.isDaemonSetReady(cd, ds, 100)
|
|
require.NoError(t, err)
|
|
require.True(t, retryable)
|
|
|
|
// deadline exceeded
|
|
ds = &appsv1.DaemonSet{Status: appsv1.DaemonSetStatus{
|
|
UpdatedNumberScheduled: 0,
|
|
DesiredNumberScheduled: 1,
|
|
}}
|
|
cd.Status.LastTransitionTime = metav1.Now()
|
|
cd.Spec.ProgressDeadlineSeconds = int32p(-1e6)
|
|
retryable, err = mocks.controller.isDaemonSetReady(cd, ds, 100)
|
|
require.Error(t, err)
|
|
require.False(t, retryable)
|
|
|
|
// only newCond not satisfied
|
|
ds = &appsv1.DaemonSet{Status: appsv1.DaemonSetStatus{
|
|
UpdatedNumberScheduled: 0,
|
|
DesiredNumberScheduled: 1,
|
|
NumberAvailable: 1,
|
|
}}
|
|
cd.Spec.ProgressDeadlineSeconds = int32p(1e6)
|
|
retryable, err = mocks.controller.isDaemonSetReady(cd, ds, 100)
|
|
require.Error(t, err)
|
|
require.True(t, retryable)
|
|
require.True(t, strings.Contains(err.Error(), "new pods"))
|
|
|
|
// only availableCond not satisfied
|
|
ds = &appsv1.DaemonSet{Status: appsv1.DaemonSetStatus{
|
|
UpdatedNumberScheduled: 1,
|
|
DesiredNumberScheduled: 1,
|
|
NumberAvailable: 0,
|
|
}}
|
|
retryable, err = mocks.controller.isDaemonSetReady(cd, ds, 100)
|
|
require.Error(t, err)
|
|
require.True(t, retryable)
|
|
require.True(t, strings.Contains(err.Error(), "available"))
|
|
}
|
|
|
|
func TestDaemonSetController_isDaemonSetReady_readyThreshold(t *testing.T) {
|
|
dc := daemonsetConfigs{name: "podinfo", label: "name", labelValue: "podinfo"}
|
|
mocks := newDaemonSetFixture(dc)
|
|
cd := &flaggerv1.Canary{}
|
|
|
|
// succeeded
|
|
ds := &appsv1.DaemonSet{Status: appsv1.DaemonSetStatus{
|
|
UpdatedNumberScheduled: 1,
|
|
DesiredNumberScheduled: 1,
|
|
NumberAvailable: 1,
|
|
}}
|
|
retryable, err := mocks.controller.isDaemonSetReady(cd, ds, 50)
|
|
require.NoError(t, err)
|
|
require.True(t, retryable)
|
|
|
|
// waiting for updated ones to be available, 50% available, ok
|
|
ds = &appsv1.DaemonSet{Status: appsv1.DaemonSetStatus{
|
|
UpdatedNumberScheduled: 4,
|
|
DesiredNumberScheduled: 4,
|
|
NumberAvailable: 2,
|
|
}}
|
|
retryable, err = mocks.controller.isDaemonSetReady(cd, ds, 50)
|
|
require.NoError(t, err)
|
|
require.True(t, retryable)
|
|
|
|
// waiting for updated ones to be available, less than 50% available
|
|
ds = &appsv1.DaemonSet{Status: appsv1.DaemonSetStatus{
|
|
UpdatedNumberScheduled: 4,
|
|
DesiredNumberScheduled: 4,
|
|
NumberAvailable: 1,
|
|
}}
|
|
cd.Status.LastTransitionTime = metav1.Now()
|
|
cd.Spec.ProgressDeadlineSeconds = int32p(1e6)
|
|
retryable, err = mocks.controller.isDaemonSetReady(cd, ds, 50)
|
|
require.Error(t, err)
|
|
require.True(t, retryable)
|
|
require.True(t, strings.Contains(err.Error(), "available"))
|
|
}
|