This should avoid frequent "Operation cannot be fulfilled" errors from
polluting Canary resource events and logs.
Signed-off-by: Aurel Canciu <aurel.canciu@nexhealth.com>
Modify `canary.IsPrimaryReady()` and `canary.Initialize()` to return a
boolean indicating if the error is retriable. Modify the scheduler to
rollback the analysis and mark the Canary object as failed if the above
two functions or `canary.IsCanaryRead()` returns false along with an
error.
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Without this, the canary replicas are updated twice:
to 1 replica then after a few seconds to the value of HPA minReplicas.
In some cases, when updated to 1 replica (before updated by HPA
controller to the minReplicas), it's considered ready: 1 of 1 (readyThreshold 100%),
and the canary weight is advanced to receive traffic with less capacity
than expected.
Co-Authored-By: Joshua Gibeon <joshuagibeon7719@gmail.com>
Co-authored-by: Sanskar Jaiswal <hey@aryan.lol>
Signed-off-by: Andy Librian <andylibrian@gmail.com>
Signed-off-by: Karl Heins <karlheins@northwesternmutual.com>
Support updating primary Deployment/DaemonSet/HPA/Service labels and annotations after first-time rollout
Copying of Configmaps and Secrets managed through Flagger should now
follow the same label prefix filtering rules as for the workloads.
Extends: #709
Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
add e2e tests istio
clean up comment from review
add e2e tests istio
clean up comment from review
clean up logging statement
add e2e tests istio
clean up comment from review
clean up logging statement
add log statement on e2e iteration
add e2e tests istio
clean up comment from review
clean up logging statement
add log statement on e2e iteration
extend timeout for finalizing
add e2e tests istio
clean up comment from review
clean up logging statement
add log statement on e2e iteration
extend timeout for finalizing
add phase to kustomize crd
add e2e tests istio
clean up comment from review
clean up logging statement
add log statement on e2e iteration
extend timeout for finalizing
add phase to kustomize crd
revert timeout on circleci
vs and svc checks for istio e2e tests
fix fmt errors and tests
add get statement in e2e test
add get statement in e2e test
add namespace to e2e
use only selector for service revert
rebase and squash
fix fmt issues
revert Dockerfile
revert go.mod and go.sum
introduction of finalizer
introduction of finalizer
remove test for finalizer add istio tests
fix fmt issues
revert go.mod and go.sum
revert Dockerfile and main.go
fmt deployment controller
introduction of finalizer
rebase and squash
fix fmt issues
revert Dockerfile
revert go.mod and go.sum
introduction of finalizer
introduction of finalizer
remove test for finalizer add istio tests
fix fmt issues
revert go.mod and go.sum
revert Dockerfile and main.go
fmt deployment controller
add unit tests for finalizing
introduction of finalizer
rebase and squash
fix fmt issues
revert Dockerfile
revert go.mod and go.sum
introduction of finalizer
introduction of finalizer
remove test for finalizer add istio tests
fix fmt issues
revert go.mod and go.sum
revert Dockerfile and main.go
fmt deployment controller
run fmt to clean up formatting
review changes
add kubectl annotation
add kubectl annotation support
introduction of finalizer
introduction of finalizer
rebase and squash
fix fmt issues
revert Dockerfile
revert go.mod and go.sum
introduction of finalizer
introduction of finalizer
remove test for finalizer add istio tests
fix fmt issues
revert go.mod and go.sum
revert Dockerfile and main.go
fmt deployment controller
introduction of finalizer
rebase and squash
fix fmt issues
revert Dockerfile
revert go.mod and go.sum
introduction of finalizer
introduction of finalizer
remove test for finalizer add istio tests
fix fmt issues
revert go.mod and go.sum
revert Dockerfile and main.go
fmt deployment controller
add unit tests for finalizing
introduction of finalizer
rebase and squash
fix fmt issues
revert Dockerfile
revert go.mod and go.sum
introduction of finalizer
introduction of finalizer
remove test for finalizer add istio tests
fix fmt issues
revert go.mod and go.sum
revert Dockerfile and main.go
fmt deployment controller
run fmt to clean up formatting
review changes
introduction of finalizer
introduction of finalizer
rebase and squash
fix fmt issues
revert Dockerfile
revert go.mod and go.sum
introduction of finalizer
introduction of finalizer
remove test for finalizer add istio tests
fix fmt issues
revert go.mod and go.sum
revert Dockerfile and main.go
fmt deployment controller
introduction of finalizer
rebase and squash
fix fmt issues
revert Dockerfile
revert go.mod and go.sum
introduction of finalizer
introduction of finalizer
remove test for finalizer add istio tests
fix fmt issues
revert go.mod and go.sum
revert Dockerfile and main.go
fmt deployment controller
add unit tests for finalizing
introduction of finalizer
rebase and squash
fix fmt issues
revert Dockerfile
revert go.mod and go.sum
introduction of finalizer
introduction of finalizer
remove test for finalizer add istio tests
fix fmt issues
revert go.mod and go.sum
revert Dockerfile and main.go
fmt deployment controller
run fmt to clean up formatting
review changes
- add analysis field to Canary spec
- deprecate canaryAnalysis filed (to be removed in the next API version)
- maintain backwards compatibility with v1alpha3 by using spec.canaryAnalysis if spec.analysis is nil
- set analysis threshold default value to 1
Niklas Ott
Aurel Canciu
Sanskar Jaiswal
miguelvalerio
ta924@yahoo.com
Sanskar Jaiswal
Stefan Prodan
Moscagus
Somtochi Onyekwere
Karl Heins
xiaobing.meng
Marcus Rodan
Aurel Canciu
Fernando Teixeira
Daniel Albuquerque
Forrest Thomas
sayboras
mathetake
Tanner Altares