github/flagger
1
0
Fork 0
mirror of https://github.com/fluxcd/flagger.git synced 2026-03-03 18:20:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

warn when mesh/metrics provider or canary target type isn't valid

Browse Source 
fixes #1872

Signed-off-by: Mara Furland <mara@fur.land>
This commit is contained in:
Mara Furland
2026-02-13 15:28:09 -05:00
parent d4cc9bf616
commit fd26b1414b
4 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/controller/scheduler_metrics.go
View File

@@ -74,7 +74,7 @@ func (c *Controller) checkMetricProviderAvailability(canary *flaggerv1.Canary) e
credentials = secret.Data
}
factory := providers.Factory{}
factory := providers.NewFactory(c.logger)
provider, err := factory.Provider(metric.Interval, template.Spec.Provider, credentials, c.kubeConfig)
if err != nil {
return fmt.Errorf("metric template %s.%s provider %s error: %v",
@@ -292,7 +292,7 @@ func (c *Controller) runMetricChecks(canary *flaggerv1.Canary) bool {
credentials = secret.Data
}
factory := providers.Factory{}
factory := providers.NewFactory(c.logger)
provider, err := factory.Provider(metric.Interval, template.Spec.Provider, credentials, c.kubeConfig)
if err != nil {
c.recordEventErrorf(canary, "Metric template %s.%s provider %s error: %v",