github/flagger
1
0
Fork 0
mirror of https://github.com/fluxcd/flagger.git synced 2026-04-15 06:57:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change builtin metrics to work with Istio >= 1.5

Browse Source
This commit is contained in:
stefanprodan
2020-06-17 10:13:29 +03:00
parent 6f65f6096d
commit e8ca5f270b
4 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
docs/gitbook/dev/upgrade-guide.md
View File

@@ -49,7 +49,7 @@ Istio 1.5 comes with a breaking change for Flagger uses. In Istio telemetry v2 t
`istio_request_duration_seconds_bucket` has been removed and replaced with `istio_request_duration_milliseconds_bucket`
and this breaks the `request-duration` metric check.
You can create a metric template using the new duration metric like this:
If are using **Istio 1.4**, you can create a metric template using the old duration metric like this:
```yaml
apiVersion: flagger.app/v1beta1
@@ -66,7 +66,7 @@ spec:
0.99,
sum(
rate(
istio_request_duration_milliseconds_bucket{
istio_request_duration_seconds_bucket{
reporter="destination",
destination_workload_namespace="{{ namespace }}",
destination_workload=~"{{ target }}"
@@ -85,6 +85,6 @@ metrics:
name: latency
namespace: istio-system
thresholdRange:
max: 500
max: 0.500
interval: 1m
```