github/flagger
1
0
Fork 0
mirror of https://github.com/fluxcd/flagger.git synced 2026-03-02 09:40:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change builtin metrics to work with Istio >= 1.5

Browse Source
This commit is contained in:
stefanprodan
2020-06-17 10:13:29 +03:00
parent 6f65f6096d
commit e8ca5f270b
4 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
docs/gitbook/dev/upgrade-guide.md
View File

@@ -49,7 +49,7 @@ Istio 1.5 comes with a breaking change for Flagger uses. In Istio telemetry v2 t
`istio_request_duration_seconds_bucket` has been removed and replaced with `istio_request_duration_milliseconds_bucket`
and this breaks the `request-duration` metric check.
You can create a metric template using the new duration metric like this:
If are using **Istio 1.4**, you can create a metric template using the old duration metric like this:
```yaml
apiVersion: flagger.app/v1beta1
@@ -66,7 +66,7 @@ spec:
0.99,
sum(
rate(
istio_request_duration_milliseconds_bucket{
istio_request_duration_seconds_bucket{
reporter="destination",
destination_workload_namespace="{{ namespace }}",
destination_workload=~"{{ target }}"
@@ -85,6 +85,6 @@ metrics:
name: latency
namespace: istio-system
thresholdRange:
max: 500
max: 0.500
interval: 1m
```

6
docs/gitbook/tutorials/istio-progressive-delivery.md
View File

@@ -6,7 +6,7 @@ This guide shows you how to use Istio and Flagger to automate canary deployments
## Prerequisites
Flagger requires a Kubernetes cluster **v1.11** or newer and Istio **v1.0** or newer.
Flagger requires a Kubernetes cluster **v1.11** or newer and Istio **v1.5** or newer.
Install Istio with telemetry support and Prometheus:
@@ -14,7 +14,7 @@ Install Istio with telemetry support and Prometheus:
istioctl manifest apply --set profile=default
```
Install Flagger using Kustomize (kubectl 1.14) in the `istio-system` namespace:
Install Flagger using Kustomize (kubectl >= 1.14) in the `istio-system` namespace:
```bash
kubectl apply -k github.com/weaveworks/flagger//kustomize/istio
@@ -149,7 +149,7 @@ spec:
cmd: "hey -z 1m -q 10 -c 2 http://podinfo-canary.test:9898/"
```
**Note** that when using Istio 1.5 you have to replace the `request-duration`
**Note** that when using Istio 1.4 you have to replace the `request-duration`
with a [metric template](https://docs.flagger.app/dev/upgrade-guide#istio-telemetry-v2).
Save the above resource as podinfo-canary.yaml and then apply it: