From 647eb8102169b00bdf597eedc481e3fb34c3a4b4 Mon Sep 17 00:00:00 2001 From: Gijs van Dulmen Date: Mon, 27 Apr 2020 09:46:13 +0200 Subject: [PATCH 1/2] Fix naming but keep structs --- pkg/notifier/rocket_test.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/notifier/rocket_test.go b/pkg/notifier/rocket_test.go index 085e63f1..7ad99cc1 100644 --- a/pkg/notifier/rocket_test.go +++ b/pkg/notifier/rocket_test.go @@ -10,7 +10,7 @@ import ( "github.com/stretchr/testify/require" ) -func TestSlack_Post(t *testing.T) { +func TestRocket_Post(t *testing.T) { fields := []Field{ {Name: "name1", Value: "value1"}, {Name: "name2", Value: "value2"}, @@ -28,9 +28,9 @@ func TestSlack_Post(t *testing.T) { })) defer ts.Close() - slack, err := NewSlack(ts.URL, "test", "test") + rocket, err := NewRocket(ts.URL, "test", "test") require.NoError(t, err) - err = slack.Post("podinfo", "test", "test", fields, "error") + err = rocket.Post("podinfo", "test", "test", fields, "error") require.NoError(t, err) } From 2b7a95fee546962cc257064c9e349d2ac3aadf02 Mon Sep 17 00:00:00 2001 From: Gijs van Dulmen Date: Mon, 27 Apr 2020 13:13:46 +0200 Subject: [PATCH 2/2] Fix slack naming as well in tests --- pkg/notifier/slack_test.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/notifier/slack_test.go b/pkg/notifier/slack_test.go index 23e9f232..a235bb6b 100644 --- a/pkg/notifier/slack_test.go +++ b/pkg/notifier/slack_test.go @@ -10,7 +10,7 @@ import ( "github.com/stretchr/testify/require" ) -func TestRocket_Post(t *testing.T) { +func TestSlack_Post(t *testing.T) { fields := []Field{ {Name: "name1", Value: "value1"}, {Name: "name2", Value: "value2"}, @@ -28,10 +28,10 @@ func TestRocket_Post(t *testing.T) { })) defer ts.Close() - rocket, err := NewRocket(ts.URL, "test", "test") + slack, err := NewSlack(ts.URL, "test", "test") require.NoError(t, err) - err = rocket.Post("podinfo", "test", "test", fields, "error") + err = slack.Post("podinfo", "test", "test", fields, "error") require.NoError(t, err) }