add e2e tests istio

add e2e tests istio

clean up comment from review

add e2e tests istio

clean up comment from review

clean up logging statement

add e2e tests istio

clean up comment from review

clean up logging statement

add log statement on e2e iteration

add e2e tests istio

clean up comment from review

clean up logging statement

add log statement on e2e iteration

extend timeout for finalizing

add e2e tests istio

clean up comment from review

clean up logging statement

add log statement on e2e iteration

extend timeout for finalizing

add phase to kustomize crd

add e2e tests istio

clean up comment from review

clean up logging statement

add log statement on e2e iteration

extend timeout for finalizing

add phase to kustomize crd

revert timeout on circleci

vs and svc checks for istio e2e tests

fix fmt errors and tests

add get statement in e2e test

add get statement in e2e test

add namespace to e2e

use only selector for service revert

pkg/controller/controller.go

@@ -140,7 +140,7 @@ func NewController(
 				ctrl.logger.Infof("%s.%s opting out, deleting finalizers", newCanary.Name, newCanary.Namespace)
 				err := ctrl.removeFinalizer(&newCanary, finalizer)
 				if err != nil {
-					ctrl.logger.Warnf("Failed to finalizers for %s.%s", oldCanary.Name, oldCanary.Namespace)
+					ctrl.logger.Warnf("Failed to remove finalizers for %s.%s", oldCanary.Name, oldCanary.Namespace)
 					return
 				}
 			}

pkg/controller/finalizer.go

@@ -43,7 +43,7 @@ func (c *Controller) finalize(old interface{}) error {
 			c.logger.Warnf("%s.%s failed due to %s not found", r.Name, r.Namespace, r.Spec.TargetRef.Kind)
 			return nil
 		}
-		c.logger.Errorf("%s.%s failed due to %s", r.Name, r.Namespace, err)
+		c.logger.Debugf("%s.%s failed due to %s", r.Name, r.Namespace, err)
 		return err
 	} else {
 		//Ensure that targetRef has met a ready state
@@ -163,7 +163,8 @@ func (c *Controller) addFinalizer(canary *flaggerv1.Canary, finalizerString stri
 	})
 
 	if err != nil {
-		return ex.Wrap(err, "Remove finalizer failed")
+		c.logger.Errorf("Failed to add finalizer %s", err)
+		return ex.Wrap(err, "Add finalizer failed")
 	}
 	return nil
 }

pkg/controller/finalizer_test.go

@@ -5,6 +5,7 @@ import (
 
 	flaggerv1 "github.com/weaveworks/flagger/pkg/apis/flagger/v1beta1"
 	fakeFlagger "github.com/weaveworks/flagger/pkg/client/clientset/versioned/fake"
+	"github.com/weaveworks/flagger/pkg/logger"
 	"k8s.io/apimachinery/pkg/runtime"
 	k8sTesting "k8s.io/client-go/testing"
 
@@ -41,10 +42,16 @@ func TestFinalizer_addFinalizer(t *testing.T) {
 	cs.PrependReactor("update", "canaries", func(action k8sTesting.Action) (handled bool, ret runtime.Object, err error) {
 		return true, nil, mockError
 	})
+
+	logger, _ := logger.NewLogger("debug")
 	m := fixture{
 		canary:        newDeploymentTestCanary(),
 		flaggerClient: cs,
-		ctrl:          &Controller{flaggerClient: cs},
+		ctrl: &Controller{
+			flaggerClient: cs,
+			logger:        logger,
+		},
+		logger: logger,
 	}
 
 	tables := []struct {