From c812dcffc178820f63eb8baa956f3002289c93fa Mon Sep 17 00:00:00 2001 From: miguelvalerio Date: Tue, 27 Jun 2023 19:47:30 +0100 Subject: [PATCH] fix traefik request-duration metric Signed-off-by: miguelvalerio --- pkg/metrics/observers/traefik.go | 2 +- pkg/metrics/observers/traefik_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/metrics/observers/traefik.go b/pkg/metrics/observers/traefik.go index af4fa1cd..2bbf2982 100644 --- a/pkg/metrics/observers/traefik.go +++ b/pkg/metrics/observers/traefik.go @@ -54,7 +54,7 @@ var traefikQueries = map[string]string{ }[{{ interval }}] ) ) by (le) - )`, + ) * 1000`, } type TraefikObserver struct { diff --git a/pkg/metrics/observers/traefik_test.go b/pkg/metrics/observers/traefik_test.go index 51086bbf..63b3141f 100644 --- a/pkg/metrics/observers/traefik_test.go +++ b/pkg/metrics/observers/traefik_test.go @@ -85,7 +85,7 @@ func TestTraefikObserver_GetRequestSuccessRate(t *testing.T) { } func TestTraefikObserver_GetRequestDuration(t *testing.T) { - expected := ` histogram_quantile( 0.99, sum( rate( traefik_service_request_duration_seconds_bucket{ service=~"default-podinfo-canary-[0-9a-zA-Z-]+@kubernetescrd" }[1m] ) ) by (le) )` + expected := ` histogram_quantile( 0.99, sum( rate( traefik_service_request_duration_seconds_bucket{ service=~"default-podinfo-canary-[0-9a-zA-Z-]+@kubernetescrd" }[1m] ) ) by (le) ) * 1000` ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { promql := r.URL.Query()["query"][0]