From a2b58d59ab5d0bb43b9277fabf84000adfdc3f59 Mon Sep 17 00:00:00 2001 From: David Young Date: Mon, 20 Sep 2021 10:51:18 +1200 Subject: [PATCH] [docs] update promql query for istio request duration A minor issue I stumbled across while learning how to drive Flagger, is that the docs still use `istio_request_duration_seconds_bucket` to illustrate the query behind the `request-duration` metric. I understand that this changed with Istio 1.5 (https://github.com/fluxcd/flagger/issues/478), but it seems that in the current version of flagger, the correct metric must already be used, since I'm getting duration metrics out of Istio 1.10 :) This change simply makes the docs clearer for those of us trying to understand exactly what `request-duration` entails! Signed-off-by: David Young --- docs/gitbook/faq.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/gitbook/faq.md b/docs/gitbook/faq.md index 09dc60dc..b7a583be 100644 --- a/docs/gitbook/faq.md +++ b/docs/gitbook/faq.md @@ -446,7 +446,7 @@ Istio query: histogram_quantile(0.99, sum( irate( - istio_request_duration_seconds_bucket{ + istio_request_duration_milliseconds_bucket{ reporter="destination", destination_workload=~"$workload", destination_workload_namespace=~"$namespace"