github/flagger
1
0
Fork 0
mirror of https://github.com/fluxcd/flagger.git synced 2026-02-14 18:10:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: do not evaluate incomplete samples from datadog

Browse Source 
Signed-off-by: Markus Dobel <markus.dobel@epicompany.eu>
This commit is contained in:
Markus Dobel
2025-02-12 18:02:52 +01:00
parent 660ed7486b
commit 2c4b7a69a2
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/metrics/providers/datadog.go
View File

@@ -143,16 +143,20 @@ func (p *DatadogProvider) RunQuery(query string) (float64, error) {
return 0, fmt.Errorf("invalid response: %s: %w", string(b), ErrNoValuesFound)
}
// in case of more than one series in the response, pick the first time series from the response
pl := res.Series[0].Pointlist
if len(pl) < 1 {
return 0, fmt.Errorf("invalid response: %s: %w", string(b), ErrNoValuesFound)
}
vs := pl[len(pl)-1]
// pick the first (oldest) timestamp/value pair from the time series, at the beginning of the interval
// must not pick the newest one from the end of the interval, since it almost always contains an incomplete bucket
vs := pl[0]
if len(vs) < 1 {
return 0, fmt.Errorf("invalid response: %s: %w", string(b), ErrNoValuesFound)
}
// return the second element of the pair: the value
return vs[1], nil
}

2
pkg/metrics/providers/datadog_test.go
View File

@@ -75,7 +75,7 @@ func TestDatadogProvider_RunQuery(t *testing.T) {
assert.GreaterOrEqual(t, to, now)
}
json := fmt.Sprintf(`{"series": [{"pointlist": [[1577232000000,29325.102158814265],[1577318400000,56294.46758591842],[1577404800000,%f]]}]}`, expected)
json := fmt.Sprintf(`{"series": [{"pointlist": [[1577232000000,%f],[1577318400000,56294.46758591842],[1577404800000,29325.102158814265]]}]}`, expected)
w.Write([]byte(json))
}))
defer ts.Close()