From 836f46131f23a0080450afdd1429f9ede4ce2879 Mon Sep 17 00:00:00 2001 From: Devin Canterberry Date: Wed, 17 Aug 2022 12:08:20 -0700 Subject: [PATCH] =?UTF-8?q?=F0=9F=9A=A6=20Hard-coding=20the=20"before"=20c?= =?UTF-8?q?hart=20URL=20in=20the=20PR=20diff=20GitHub=20action?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit While this may not be strictly necessary, it's the correct resolution enough of the time that the clarity of explicitly stating the "before" is, I think, worth it. --- .github/workflows/pr_diff.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pr_diff.yaml b/.github/workflows/pr_diff.yaml index aae7594..52f6a42 100644 --- a/.github/workflows/pr_diff.yaml +++ b/.github/workflows/pr_diff.yaml @@ -1,4 +1,5 @@ name: PR Diff for Helm chart + on: pull_request_target: @@ -37,7 +38,7 @@ jobs: --set s3.bucket=abc --set s3.encrypt=abc ) - helm template --debug ${OPTIONS[@]} --output-dir before ${{ github.server_url }}/${{ github.repository }}/archive/refs/heads/${{ github.base_ref }}.tar.gz + helm template --debug ${OPTIONS[@]} --output-dir before https://github.com/twuni/docker-registry.helm/archive/refs/heads/main.tar.gz helm template --debug ${OPTIONS[@]} --output-dir after . # https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#multiline-strings echo 'HELM_DIFF<> $GITHUB_ENV