From 760bacab344a7bfd625c8439b3816ba76d3d7419 Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Wed, 4 Feb 2026 12:38:37 +0100 Subject: [PATCH] format(TestPromClientControllerSync_ClientCreation): indent the code by two tabs --- pkg/descheduler/descheduler_test.go | 120 ++++++++++++++-------------- 1 file changed, 60 insertions(+), 60 deletions(-) diff --git a/pkg/descheduler/descheduler_test.go b/pkg/descheduler/descheduler_test.go index cc80cf5ef..77a984fa9 100644 --- a/pkg/descheduler/descheduler_test.go +++ b/pkg/descheduler/descheduler_test.go @@ -1968,76 +1968,76 @@ func TestPromClientControllerSync_ClientCreation(t *testing.T) { for _, tc := range testCases { t.Run(tc.name, func(t *testing.T) { - ctx, cancel := context.WithCancel(context.TODO()) - defer cancel() - setup := setupPromClientControllerTest(ctx, tc.objects, newPrometheusConfig()) + ctx, cancel := context.WithCancel(context.TODO()) + defer cancel() + setup := setupPromClientControllerTest(ctx, tc.objects, newPrometheusConfig()) - // Set additional test-specific fields - setup.ctrl.currentPrometheusAuthToken = tc.currentAuthToken - if tc.currentAuthToken != "" { - setup.ctrl.previousPrometheusClientTransport = &http.Transport{} - } - - // Mock createPrometheusClient - clientCreated := false - if tc.createPrometheusClientFunc != nil { - setup.ctrl.createPrometheusClient = func(url, token string) (promapi.Client, *http.Transport, error) { - client, transport, err := tc.createPrometheusClientFunc(url, token) - if err == nil { - clientCreated = true + // Set additional test-specific fields + setup.ctrl.currentPrometheusAuthToken = tc.currentAuthToken + if tc.currentAuthToken != "" { + setup.ctrl.previousPrometheusClientTransport = &http.Transport{} } - return client, transport, err - } - } - // Call sync - err := setup.ctrl.sync() + // Mock createPrometheusClient + clientCreated := false + if tc.createPrometheusClientFunc != nil { + setup.ctrl.createPrometheusClient = func(url, token string) (promapi.Client, *http.Transport, error) { + client, transport, err := tc.createPrometheusClientFunc(url, token) + if err == nil { + clientCreated = true + } + return client, transport, err + } + } - // Verify error expectations - if tc.expectedErr != nil { - if err == nil { - t.Errorf("Expected error %q but got none", tc.expectedErr) - } else if err.Error() != tc.expectedErr.Error() { - t.Errorf("Expected error %q but got %q", tc.expectedErr, err.Error()) - } - } else { - if err != nil { - t.Errorf("Expected no error but got: %v", err) - } - } + // Call sync + err := setup.ctrl.sync() - // Verify client creation expectations - if tc.expectClientCreated && !clientCreated { - t.Errorf("Expected prometheus client to be created but it wasn't") - } - if !tc.expectClientCreated && clientCreated { - t.Errorf("Expected prometheus client not to be created but it was") - } + // Verify error expectations + if tc.expectedErr != nil { + if err == nil { + t.Errorf("Expected error %q but got none", tc.expectedErr) + } else if err.Error() != tc.expectedErr.Error() { + t.Errorf("Expected error %q but got %q", tc.expectedErr, err.Error()) + } + } else { + if err != nil { + t.Errorf("Expected no error but got: %v", err) + } + } - // Verify token cleared expectations - if tc.expectCurrentTokenCleared && setup.ctrl.currentPrometheusAuthToken != "" { - t.Errorf("Expected current auth token to be cleared but it wasn't") - } + // Verify client creation expectations + if tc.expectClientCreated && !clientCreated { + t.Errorf("Expected prometheus client to be created but it wasn't") + } + if !tc.expectClientCreated && clientCreated { + t.Errorf("Expected prometheus client not to be created but it was") + } - // Verify previous transport cleared expectations - if tc.expectPreviousTransportCleared && setup.ctrl.previousPrometheusClientTransport != nil { - t.Errorf("Expected previous transport to be cleared but it wasn't") - } + // Verify token cleared expectations + if tc.expectCurrentTokenCleared && setup.ctrl.currentPrometheusAuthToken != "" { + t.Errorf("Expected current auth token to be cleared but it wasn't") + } - // Verify promClient cleared when secret not found - if tc.expectPreviousTransportCleared && setup.ctrl.promClient != nil { - t.Errorf("Expected promClient to be cleared but it wasn't") - } + // Verify previous transport cleared expectations + if tc.expectPreviousTransportCleared && setup.ctrl.previousPrometheusClientTransport != nil { + t.Errorf("Expected previous transport to be cleared but it wasn't") + } - // Verify token updated when client created - if tc.expectClientCreated && len(tc.objects) > 0 { - if secret, ok := tc.objects[0].(*v1.Secret); ok && secret.Data != nil { - expectedToken := string(secret.Data[prometheusAuthTokenSecretKey]) - if setup.ctrl.currentPrometheusAuthToken != expectedToken { - t.Errorf("Expected current auth token to be %q but got %q", expectedToken, setup.ctrl.currentPrometheusAuthToken) + // Verify promClient cleared when secret not found + if tc.expectPreviousTransportCleared && setup.ctrl.promClient != nil { + t.Errorf("Expected promClient to be cleared but it wasn't") + } + + // Verify token updated when client created + if tc.expectClientCreated && len(tc.objects) > 0 { + if secret, ok := tc.objects[0].(*v1.Secret); ok && secret.Data != nil { + expectedToken := string(secret.Data[prometheusAuthTokenSecretKey]) + if setup.ctrl.currentPrometheusAuthToken != expectedToken { + t.Errorf("Expected current auth token to be %q but got %q", expectedToken, setup.ctrl.currentPrometheusAuthToken) + } + } } - } - } }) } }