Files
deprecated-helm-charts/stable/jenkins/ci
Torsten Walter b02ae3f484 [stable/jenkins] helm chart best practices (#13136)
* naming conventions - master keys

Renamed all `Master.*` keys to match
[helm chart naming conventions](https://helm.sh/docs/chart_best_practices/#naming-conventions)

Signed-off-by: Torsten Walter <mail@torstenwalter.de>

* renamed all `NetworkPolicy.*` keys

Signed-off-by: Torsten Walter <mail@torstenwalter.de>

* renamed all `Agent.*` keys

Signed-off-by: Torsten Walter <mail@torstenwalter.de>

* renamed all `Persistence.*` keys

Signed-off-by: Torsten Walter <mail@torstenwalter.de>

* cleanup setting resources

Signed-off-by: Torsten Walter <mail@torstenwalter.de>

* follow RBAC best practices

https://helm.sh/docs/chart_best_practices/#role-based-access-control

Signed-off-by: Torsten Walter <mail@torstenwalter.de>

* only render rollingUpdate if persistence is disabled

Signed-off-by: Torsten Walter <mail@torstenwalter.de>

* configure securityRealm and authorizationStrategy via values file

Before those have been surrounded via if/else and value was only set
in case it has been defined within values.yaml

The if/else check can be avoided by directly configuring the default value.

Signed-off-by: Torsten Walter <mail@torstenwalter.de>

* quote all strings

as recommended in https://helm.sh/docs/chart_best_practices/#make-types-clear

Signed-off-by: Torsten Walter <mail@torstenwalter.de>

* add standard labels for resources

added [standard labels](https://helm.sh/docs/chart_best_practices/#standard-labels):

- app.kubernetes.io/name
- helm.sh/chart
- app.kubernetes.io/managed-by
- app.kubernetes.io/instance

Signed-off-by: Torsten Walter <mail@torstenwalter.de>

* fail if old values are used

THis checks if keys with the old prefixes are set and fails template
rendering in that case to prevent breaking updates.

Signed-off-by: Torsten Walter <mail@torstenwalter.de>

* fixed labels and selectors

Forgot to update some labels. Also the label selectors are
updated now.

Signed-off-by: Torsten Walter <mail@torstenwalter.de>

* test different values

Signed-off-by: Torsten Walter <mail@torstenwalter.de>

* finer grained checks for deprecated values

Signed-off-by: Torsten Walter <mail@torstenwalter.de>

* updated OWNERS

Signed-off-by: Torsten Walter <mail@torstenwalter.de>

* added newline at end of file

Signed-off-by: Torsten Walter <mail@torstenwalter.de>

* renamed ci/*-values.yaml to comply with conventions

Signed-off-by: Torsten Walter <mail@torstenwalter.de>
2019-04-22 04:57:44 -07:00
..