github/deprecated-helm-charts
1
0
Fork 0
mirror of https://github.com/helm/charts.git synced 2026-09-05 12:27:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
5,156 Commits 10 Branches 0 Tags
c1576743facf7273bad38d3f376c6022ea687f6b
Commit Graph
15 Commits
Author SHA1 Message Date
Scott Rigby 4dd8cdc6bd Example ingress best practices for review guidelines (#7590) 
Signed-off-by: Scott Rigby <scott@r6by.com>
 2018-09-06 15:55:40 -07:00
Maxime Guyot 956490df46 Replace CLA by DCO in review guidelines (#7559) 
Signed-off-by: Maxime Guyot <Miouge1@users.noreply.github.com>
 2018-09-06 11:12:03 -07:00
Paul Czarkowski eb54bc88f0 [Documentation] Add HPA best practices to review guidelines. (#7562) 
* [Documentation] Add HPA best practices to review guidelines.

After reviewing the nginx-ingress and spark charts which both have HPA's
defined I am making the following recommendations based on the
nginx-ingress chart specifically (after #7560) be added to the
review guidelines.

Signed-off-by: Paul Czarkowski <username.taken@gmail.com>

* fixed accidental deletion of pvc.yaml

Signed-off-by: Paul Czarkowski <username.taken@gmail.com>
 2018-09-06 08:28:08 -07:00
Pete Brown f3bfe90401 Fix urls to charts and helm repos (#7312) 
* Fix urls to charts and helm repos

* Fix name of chart-maintainers team
 2018-08-23 09:43:22 -07:00
Scott Rigby fd54977079 Update README to change k8s member step (#6779) 
* After repo move to helm/helm, update steps for Owning and Maintaining A Chart

* Change repo URL from kubernetes/helm to helm/helm everywhere above chart directories (those may be separate PRs)

* Fix earlier missing apostrophe and incorrect case

* Add missing k8s/ > helm/ string changes
 2018-08-14 13:39:45 -07:00
cheyang 21ae071fd8 fix typo in REVIEW_GUIDELINES.md (#5308) 2018-04-29 05:59:16 -07:00
Rob Kernick e067fdd423 Add review guidelines around pvcs (#4223) 
* Add review guidelines around pvcs

* Updates to pvc guidelines

* Updates to match existing best practices and examples
 2018-03-23 08:06:01 -07:00
Reinhard Nägele b5c3e51568 Enable testing charts with test values (#4157) 
* Refactor and fix shellcheck issues

* Make constants readonly and uppercase

* Remove .editorconfig

* Enable testing charts with test values

* Remove dummy chart
 2018-03-22 06:57:07 -07:00
Kai Chen f47993df93 Improve Chart Review Guidelines documentation (#3536) 2018-02-02 21:41:04 -08:00
Dhilip 964cdd503f update Review Guidelines for workloads (#3334) 
* update Review Guidelilnes for workloads

Initial update with Best Practises.

* Fix review comments

Apply review comments

* Remove examples

examples to be handled separately.
 2018-01-25 07:12:17 -08:00
Vic Iglesias 1eae17fca5 Add mechanism for cc'ing maintainers + nit commas 2017-12-13 13:26:22 -08:00
Matt Farina 112544e84a Adding review process docs 2017-12-13 16:17:08 -05:00
Reinhard Nägele 77b7ca03a4 Update REVIEW_GUIDELINES.md (#2836) 2017-11-22 21:27:26 +01:00
Reinhard Nägele 925a214a46 Add notes on configuration and compatibility (#2777) 2017-11-20 09:59:28 -05:00
Reinhard Nägele 1e12dcec5c Add review guidelines (#2774) 2017-11-17 11:02:56 -05:00