From f5f2db3abe8cd0b9cc096f56ec9ef6726b538869 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20Daba=C5=A1inskas?= Date: Sun, 28 Jul 2019 20:47:53 +0800 Subject: [PATCH] [stable/docker-registry] Add namespace name to the port forward tip (#15827) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Add namespace name to the port forward tip Show namespace name in port-forward tip, fixes copy/paste error: $ kubectl port-forward $POD_NAME 8080:5000 Error from server (NotFound): pods "registry-docker-registry-798dfccf5f-gc824" not found $ kubectl -n registry port-forward registry-docker-registry-798dfccf5f-gc824 8080:5000 Forwarding from 127.0.0.1:8080 -> 5000 This approach used in other charts, for example https://github.com/helm/charts/blob/master/stable/kubernetes-dashboard/templates/NOTES.txt Signed-off-by: Tomas DabaĊĦinskas * bump chart version Signed-off-by: David J. M. Karlsen --- stable/docker-registry/Chart.yaml | 2 +- stable/docker-registry/templates/NOTES.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/stable/docker-registry/Chart.yaml b/stable/docker-registry/Chart.yaml index 3a1fd0bc4a..dc187d0f01 100644 --- a/stable/docker-registry/Chart.yaml +++ b/stable/docker-registry/Chart.yaml @@ -1,7 +1,7 @@ apiVersion: v1 description: A Helm chart for Docker Registry name: docker-registry -version: 1.8.0 +version: 1.8.1 appVersion: 2.7.1 home: https://hub.docker.com/_/registry/ icon: https://hub.docker.com/public/images/logos/mini-logo.svg diff --git a/stable/docker-registry/templates/NOTES.txt b/stable/docker-registry/templates/NOTES.txt index 16bcf538d3..4a9152b57c 100644 --- a/stable/docker-registry/templates/NOTES.txt +++ b/stable/docker-registry/templates/NOTES.txt @@ -15,5 +15,5 @@ {{- else if contains "ClusterIP" .Values.service.type }} export POD_NAME=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "app={{ template "docker-registry.name" . }},release={{ .Release.Name }}" -o jsonpath="{.items[0].metadata.name}") echo "Visit http://127.0.0.1:8080 to use your application" - kubectl port-forward $POD_NAME 8080:5000 + kubectl -n {{ .Release.Namespace }} port-forward $POD_NAME 8080:5000 {{- end }}