From f589ca7e56c0f246a930be3b85d74e80aa28f87a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Rodr=C3=ADguez=20Hern=C3=A1ndez?= Date: Tue, 28 May 2019 19:20:26 +0200 Subject: [PATCH] [stable/orangehrm] Use immutable tags (#14204) * Bump chart version Signed-off-by: Carlos Rodriguez Hernandez * [stable/orangehrm] Use immutable tags Signed-off-by: Carlos Rodriguez Hernandez --- stable/orangehrm/Chart.yaml | 2 +- stable/orangehrm/README.md | 8 +++++++- stable/orangehrm/templates/NOTES.txt | 7 +++++++ stable/orangehrm/values.yaml | 2 +- 4 files changed, 16 insertions(+), 3 deletions(-) diff --git a/stable/orangehrm/Chart.yaml b/stable/orangehrm/Chart.yaml index a8c11291d1..4da87c83d2 100644 --- a/stable/orangehrm/Chart.yaml +++ b/stable/orangehrm/Chart.yaml @@ -1,6 +1,6 @@ apiVersion: v1 name: orangehrm -version: 4.3.2 +version: 4.3.3 appVersion: 4.3.1-0 description: OrangeHRM is a free HR management system that offers a wealth of modules to suit the needs of your business. diff --git a/stable/orangehrm/README.md b/stable/orangehrm/README.md index 9c04a27732..49c86ddb07 100644 --- a/stable/orangehrm/README.md +++ b/stable/orangehrm/README.md @@ -53,7 +53,7 @@ The following table lists the configurable parameters of the OrangeHRM chart and | `global.imagePullSecrets` | Global Docker registry secret names as an array | `[]` (does not add image pull secrets to deployed pods) | | `image.registry` | OrangeHRM image registry | `docker.io` | | `image.repository` | OrangeHRM Image name | `bitnami/orangehrm` | -| `image.tag` | OrangeHRM Image tag | `{VERSION}` | +| `image.tag` | OrangeHRM Image tag | `{TAG_NAME}` | | `image.pullPolicy` | Image pull policy | `Always` if `imageTag` is `latest`, else `IfNotPresent` | | `image.pullSecrets` | Specify docker-registry secret names as an array | `[]` (does not add image pull secrets to deployed pods) | | `orangehrmUsername` | User of the application | `user` | @@ -133,6 +133,12 @@ $ helm install --name my-release -f values.yaml stable/orangehrm > **Tip**: You can use the default [values.yaml](values.yaml) +### [Rolling VS Immutable tags](https://docs.bitnami.com/containers/how-to/understand-rolling-tags-containers/) + +It is strongly recommended to use immutable tags in a production environment. This ensures your deployment does not change automatically if the same tag is updated with a different image. + +Bitnami will release a new chart updating its containers if a new version of the main container, significant changes, or critical vulnerabilities exist. + ## Persistence The [Bitnami OrangeHRM](https://github.com/bitnami/bitnami-docker-orangehrm) image stores the OrangeHRM data and configurations at the `/bitnami/orangehrm` and `/bitnami/apache` paths of the container. diff --git a/stable/orangehrm/templates/NOTES.txt b/stable/orangehrm/templates/NOTES.txt index 5ffc4029a9..ee726dbca6 100644 --- a/stable/orangehrm/templates/NOTES.txt +++ b/stable/orangehrm/templates/NOTES.txt @@ -47,3 +47,10 @@ host. To configure OrangeHRM to use and external database host: helm upgrade {{ .Release.Name }} --set service.type={{ .Values.service.type }},mariadb.enabled=false,externalDatabase.host=YOUR_EXTERNAL_DATABASE_HOST stable/orangehrm {{- end }} + +{{- if and (contains "bitnami/" .Values.image.repository) (not (.Values.image.tag | regexFind "-r\\d+$")) }} + +WARNING: Rolling tag detected ({{ .Values.image.repository }}:{{ .Values.image.tag }}), please note that it is strongly recommended to avoid using rolling tags in a production environment. ++info https://docs.bitnami.com/containers/how-to/understand-rolling-tags-containers/ + +{{- end }} diff --git a/stable/orangehrm/values.yaml b/stable/orangehrm/values.yaml index 075b3bed70..763e8fdb27 100644 --- a/stable/orangehrm/values.yaml +++ b/stable/orangehrm/values.yaml @@ -13,7 +13,7 @@ image: registry: docker.io repository: bitnami/orangehrm - tag: 4.3.1-0 + tag: 4.3.1-0-debian-9-r5 ## Specify a imagePullPolicy ## Defaults to 'Always' if image tag is 'latest', else set to 'IfNotPresent' ## ref: http://kubernetes.io/docs/user-guide/images/#pre-pulling-images