From f0e1294b670036cf4eaf63164658ae8fddd86271 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Rodr=C3=ADguez=20Hern=C3=A1ndez?= Date: Tue, 28 May 2019 23:58:58 +0200 Subject: [PATCH] [stable/ghost] Use immutable tags (#14215) * Bump chart version Signed-off-by: Carlos Rodriguez Hernandez * [stable/ghost] Use immutable tags Signed-off-by: Carlos Rodriguez Hernandez --- stable/ghost/Chart.yaml | 2 +- stable/ghost/README.md | 8 +++++++- stable/ghost/templates/NOTES.txt | 7 +++++++ stable/ghost/values.yaml | 2 +- 4 files changed, 16 insertions(+), 3 deletions(-) diff --git a/stable/ghost/Chart.yaml b/stable/ghost/Chart.yaml index 2577559804..ef688d76c2 100644 --- a/stable/ghost/Chart.yaml +++ b/stable/ghost/Chart.yaml @@ -1,6 +1,6 @@ apiVersion: v1 name: ghost -version: 6.7.14 +version: 6.7.15 appVersion: 2.23.0 description: A simple, powerful publishing platform that allows you to share your stories with the world keywords: diff --git a/stable/ghost/README.md b/stable/ghost/README.md index bfc597f7fa..40fc62465b 100644 --- a/stable/ghost/README.md +++ b/stable/ghost/README.md @@ -53,7 +53,7 @@ The following table lists the configurable parameters of the Ghost chart and the | `global.imagePullSecrets` | Global Docker registry secret names as an array | `[]` (does not add image pull secrets to deployed pods) | | `image.registry` | Ghost image registry | `docker.io` | | `image.repository` | Ghost Image name | `bitnami/ghost` | -| `image.tag` | Ghost Image tag | `{VERSION}` | +| `image.tag` | Ghost Image tag | `{TAG_NAME}` | | `image.pullPolicy` | Image pull policy | `Always` if `imageTag` is `latest`, else `IfNotPresent` | | `image.pullSecrets` | Specify docker-registry secret names as an array | `[]` (does not add image pull secrets to deployed pods) | | `volumePermissions.image.registry` | Init container volume-permissions image registry | `docker.io` | @@ -146,6 +146,12 @@ $ helm install --name my-release -f values.yaml stable/ghost > **Tip**: You can use the default [values.yaml](values.yaml) +### [Rolling VS Immutable tags](https://docs.bitnami.com/containers/how-to/understand-rolling-tags-containers/) + +It is strongly recommended to use immutable tags in a production environment. This ensures your deployment does not change automatically if the same tag is updated with a different image. + +Bitnami will release a new chart updating its containers if a new version of the main container, significant changes, or critical vulnerabilities exist. + ## Using an existing database Sometimes you may want to have Ghost connect to an external database rather than installing one inside your cluster, e.g. to use a managed database service, or use run a single database server for all your applications. To do this, the chart allows you to specify credentials for an external database under the [`externalDatabase` parameter](#configuration). You should also disable the MariaDB installation with the `mariadb.enabled` option. For example: diff --git a/stable/ghost/templates/NOTES.txt b/stable/ghost/templates/NOTES.txt index ffcff11dce..a692651e34 100644 --- a/stable/ghost/templates/NOTES.txt +++ b/stable/ghost/templates/NOTES.txt @@ -56,3 +56,10 @@ host. To configure Ghost with the URL of your service: echo Email: {{ .Values.ghostEmail }} echo Password: $(kubectl get secret --namespace {{ .Release.Namespace }} {{ template "ghost.fullname" . }} -o jsonpath="{.data.ghost-password}" | base64 --decode) {{- end }} + +{{- if and (contains "bitnami/" .Values.image.repository) (not (.Values.image.tag | regexFind "-r\\d+$")) }} + +WARNING: Rolling tag detected ({{ .Values.image.repository }}:{{ .Values.image.tag }}), please note that it is strongly recommended to avoid using rolling tags in a production environment. ++info https://docs.bitnami.com/containers/how-to/understand-rolling-tags-containers/ + +{{- end }} diff --git a/stable/ghost/values.yaml b/stable/ghost/values.yaml index 71474fd776..916188ae4e 100644 --- a/stable/ghost/values.yaml +++ b/stable/ghost/values.yaml @@ -13,7 +13,7 @@ image: registry: docker.io repository: bitnami/ghost - tag: 2.23.0 + tag: 2.23.0-debian-9-r1 ## Specify a imagePullPolicy ## Defaults to 'Always' if image tag is 'latest', else set to 'IfNotPresent' ## ref: http://kubernetes.io/docs/user-guide/images/#pre-pulling-images