From f026a7785fc4c2c1644fa930bb3870d3a538ffde Mon Sep 17 00:00:00 2001 From: Austin Orth Date: Sat, 1 Feb 2020 03:51:20 -0500 Subject: [PATCH] [stable/gocd] Quote ingress host (#20477) * [stable/gocd] Quote ingress host When using a wildcard DNS name for host, such as *.example.com, Helm fails with a yaml parsing error. Added quote function to allow use of wildcard. Signed-off-by: Austin Orth * [stable/gocd] Bump Chart version Signed-off-by: Austin Orth * [stable/gocd] Ingress api version change Changed version of api for ingress to networking.k8s.io/v1beta1. Signed-off-by: Austin Orth * [stable/gocd] Updated changelog Updated the changelog with relevant commits for this patch version. Signed-off-by: Austin Orth --- stable/gocd/CHANGELOG.md | 4 ++++ stable/gocd/Chart.yaml | 2 +- stable/gocd/templates/ingress.yaml | 4 ++-- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/stable/gocd/CHANGELOG.md b/stable/gocd/CHANGELOG.md index 7c040037c3..d788f29263 100644 --- a/stable/gocd/CHANGELOG.md +++ b/stable/gocd/CHANGELOG.md @@ -1,3 +1,7 @@ +### 1.22.1 +* [b856007](https://github.com/kubernetes/charts/commit/b856007): Ingress version api change +* [e2f27a9](https://github.com/kubernetes/charts/commit/e2f27a9): Quote ingress host + ### 1.22.0 * [bcd9825](https://github.com/kubernetes/charts/commit/bcd9825): Bump up GoCD Version to 20.1.0 ### 1.21.0 diff --git a/stable/gocd/Chart.yaml b/stable/gocd/Chart.yaml index 11bc592491..aca5175641 100644 --- a/stable/gocd/Chart.yaml +++ b/stable/gocd/Chart.yaml @@ -1,7 +1,7 @@ apiVersion: v1 name: gocd home: https://www.gocd.org/ -version: 1.22.0 +version: 1.22.1 appVersion: 20.1.0 description: GoCD is an open-source continuous delivery server to model and visualize complex workflows with ease. icon: https://gocd.github.io/assets/images/go-icon-black-192x192.png diff --git a/stable/gocd/templates/ingress.yaml b/stable/gocd/templates/ingress.yaml index aef48da5da..7a7cef3b53 100644 --- a/stable/gocd/templates/ingress.yaml +++ b/stable/gocd/templates/ingress.yaml @@ -1,6 +1,6 @@ {{- if .Values.server.enabled }} {{- if .Values.server.ingress.enabled -}} -apiVersion: extensions/v1beta1 +apiVersion: networking.k8s.io/v1beta1 kind: Ingress metadata: name: {{ template "gocd.fullname" . }}-server @@ -19,7 +19,7 @@ spec: {{ $dot := .}} rules: {{- range $host := .Values.server.ingress.hosts }} - - host: {{ $host }} + - host: {{ $host | quote }} http: paths: - backend: