From e163767afcee06dafa4f4b66a6e2e45e6cac0e8a Mon Sep 17 00:00:00 2001
From: Adnan Abdulhussein <adnan@prydoni.us>
Date: Tue, 5 Sep 2017 00:08:48 +0100
Subject: [PATCH] add common chart to incubator (#1611)

* add common chart to incubator

moving the common chart to incubator so we can actively work on it

* Excuse incubator/common from tests
---
 incubator/common/.helmignore                  |  21 +
 incubator/common/Chart.yaml                   |  10 +
 incubator/common/README.md                    | 832 ++++++++++++++++++
 incubator/common/templates/_chartref.tpl      |  14 +
 incubator/common/templates/_configmap.yaml    |   9 +
 incubator/common/templates/_container.yaml    |  15 +
 incubator/common/templates/_deployment.yaml   |  18 +
 incubator/common/templates/_envvar.tpl        |  19 +
 incubator/common/templates/_fullname.tpl      |  39 +
 incubator/common/templates/_ingress.yaml      |  27 +
 incubator/common/templates/_metadata.yaml     |  10 +
 .../templates/_metadata_annotations.tpl       |  18 +
 .../common/templates/_metadata_labels.tpl     |  28 +
 incubator/common/templates/_name.tpl          |  29 +
 .../templates/_persistentvolumeclaim.yaml     |  21 +
 incubator/common/templates/_secret.yaml       |  10 +
 incubator/common/templates/_service.yaml      |  17 +
 incubator/common/templates/_util.tpl          |  15 +
 incubator/common/templates/_volume.tpl        |  22 +
 incubator/common/values.yaml                  |   4 +
 test/changed.sh                               |   4 +-
 21 files changed, 1181 insertions(+), 1 deletion(-)
 create mode 100644 incubator/common/.helmignore
 create mode 100755 incubator/common/Chart.yaml
 create mode 100644 incubator/common/README.md
 create mode 100644 incubator/common/templates/_chartref.tpl
 create mode 100644 incubator/common/templates/_configmap.yaml
 create mode 100644 incubator/common/templates/_container.yaml
 create mode 100644 incubator/common/templates/_deployment.yaml
 create mode 100644 incubator/common/templates/_envvar.tpl
 create mode 100644 incubator/common/templates/_fullname.tpl
 create mode 100644 incubator/common/templates/_ingress.yaml
 create mode 100644 incubator/common/templates/_metadata.yaml
 create mode 100644 incubator/common/templates/_metadata_annotations.tpl
 create mode 100644 incubator/common/templates/_metadata_labels.tpl
 create mode 100644 incubator/common/templates/_name.tpl
 create mode 100644 incubator/common/templates/_persistentvolumeclaim.yaml
 create mode 100644 incubator/common/templates/_secret.yaml
 create mode 100644 incubator/common/templates/_service.yaml
 create mode 100644 incubator/common/templates/_util.tpl
 create mode 100644 incubator/common/templates/_volume.tpl
 create mode 100644 incubator/common/values.yaml

diff --git a/incubator/common/.helmignore b/incubator/common/.helmignore
new file mode 100644
index 0000000000..f0c1319444
--- /dev/null
+++ b/incubator/common/.helmignore
@@ -0,0 +1,21 @@
+# Patterns to ignore when building packages.
+# This supports shell glob matching, relative path matching, and
+# negation (prefixed with !). Only one pattern per line.
+.DS_Store
+# Common VCS dirs
+.git/
+.gitignore
+.bzr/
+.bzrignore
+.hg/
+.hgignore
+.svn/
+# Common backup files
+*.swp
+*.bak
+*.tmp
+*~
+# Various IDEs
+.project
+.idea/
+*.tmproj
diff --git a/incubator/common/Chart.yaml b/incubator/common/Chart.yaml
new file mode 100755
index 0000000000..92f884f8be
--- /dev/null
+++ b/incubator/common/Chart.yaml
@@ -0,0 +1,10 @@
+apiVersion: v1
+description: Common chartbuilding components and helpers
+name: common
+version: 0.0.1
+home: https://helm.sh
+maintainers:
+- name: technosophos
+  email: technosophos@gmail.com
+- name: prydonius
+  email: adnan@bitnami.com
\ No newline at end of file
diff --git a/incubator/common/README.md b/incubator/common/README.md
new file mode 100644
index 0000000000..afdcac53b6
--- /dev/null
+++ b/incubator/common/README.md
@@ -0,0 +1,832 @@
+# Common: The Helm Helper Chart
+
+This chart is designed to make it easier for you to build and maintain Helm
+charts.
+
+It provides utilities that reflect best practices of Kubernetes chart development,
+making it faster for you to write charts.
+
+## Tips
+
+A few tips for working with Common:
+
+- Be careful when using functions that generate random data (like `common.fullname.unique`).
+  They may trigger unwanted upgrades or have other side effects.
+
+In this document, we use `RELEASE-NAME` as the name of the release.
+
+## Resource Kinds
+
+Kubernetes defines a variety of resource kinds, from `Secret` to `StatefulSet`.
+We define some of the most common kinds in a way that lets you easily work with
+them.
+
+The resource kind templates are designed to make it much faster for you to
+define _basic_ versions of these resources. They allow you to extend and modify
+just what you need, without having to copy around lots of boilerplate.
+
+To make use of these templates you must define a template that will extend the
+base template (though it can be empty). The name of this template is then passed
+to the base template, for example:
+
+```yaml
+{{- template "common.service" (list . "mychart.service") -}}
+{{- define "mychart.service" -}}
+## Define overrides for your Service resource here, e.g.
+# metadata:
+#   labels:
+#     custom: label
+# spec:
+#   ports:
+#   - port: 8080
+{{- end -}}
+```
+
+Note that the `common.service` template defines two parameters:
+
+  - The root context (usually `.`)
+  - A template name containing the service definition overrides
+
+A limitation of the Go template library is that a template can only take a
+single argument. The `list` function is used to workaround this by constructing
+a list or array of arguments that is passed to the template.
+
+The `common.service` template is responsible for rendering the templates with
+the root context and merging any overrides. As you can see, this makes it very
+easy to create a basic `Service` resource without having to copy around the
+standard metadata and labels.
+
+Each implemented base resource is described in greater detail below.
+
+### `common.service`
+
+The `common.service` template creates a basic `Service` resource with the
+following defaults:
+
+- Service type (ClusterIP, NodePort, LoadBalancer) made configurable by `.Values.service.type`
+- Named port `http` configured on port 80
+- Selector set to `app: {{ template "common.name" }}, release: {{ .Release.Name | quote }}` to match the default used in the `Deployment` resource
+
+Example template:
+
+```yaml
+{{- template "common.service" (list . "mychart.mail.service") -}}
+{{- define "mychart.mail.service" -}}
+metadata:
+  name: {{ template "common.fullname" . }}-mail # overrides the default name to add a suffix
+  labels:                                       # appended to the labels section
+    protocol: mail
+spec:
+  ports:                                        # composes the `ports` section of the service definition.
+  - name: smtp
+    port: 22
+    targetPort: 22
+  - name: imaps
+    port: 993
+    targetPort: 993
+  selector:                                     # this is appended to the default selector
+    protocol: mail
+{{- end -}}
+---
+{{ template "common.service" (list . "mychart.web.service") -}}
+{{- define "mychart.web.service" -}}
+metadata:
+  name: {{ template "common.fullname" . }}-www  # overrides the default name to add a suffix
+  labels:                                       # appended to the labels section
+    protocol: www
+spec:
+  ports:                                        # composes the `ports` section of the service definition.
+  - name: www
+    port: 80
+    targetPort: 8080
+{{- end -}}
+```
+
+The above template defines _two_ services: a web service and a mail service.
+
+The most important part of a service definition is the `ports` object, which
+defines the ports that this service will listen on. Most of the time,
+`selector` is computed for you. But you can replace it or add to it.
+
+The output of the example above is:
+
+```yaml
+apiVersion: v1
+kind: Service
+metadata:
+  labels:
+    app: service
+    chart: service-0.1.0
+    heritage: Tiller
+    protocol: mail
+    release: release-name
+  name: release-name-service-mail
+spec:
+  ports:
+  - name: smtp
+    port: 22
+    targetPort: 22
+  - name: imaps
+    port: 993
+    targetPort: 993
+  selector:
+    app: service
+    release: release-name
+    protocol: mail
+  type: ClusterIP
+---
+apiVersion: v1
+kind: Service
+metadata:
+  labels:
+    app: service
+    chart: service-0.1.0
+    heritage: Tiller
+    protocol: www
+    release: release-name
+  name: release-name-service-www
+spec:
+  ports:
+  - name: www
+    port: 80
+    targetPort: 8080
+  type: ClusterIP
+```
+
+## `common.deployment`
+
+The `common.deployment` template defines a basic `Deployment`. Underneath the
+hood, it uses `common.container` (see next section).
+
+By default, the pod template within the deployment defines the labels `app: {{ template "common.name" . }}`
+and `release: {{ .Release.Name | quote }` as this is also used as the selector. The
+standard set of labels are not used as some of these can change during upgrades,
+which causes the replica sets and pods to not correctly match.
+
+Example use:
+
+```yaml
+{{- template "common.deployment" (list . "mychart.deployment") -}}
+{{- define "mychart.deployment" -}}
+## Define overrides for your Deployment resource here, e.g.
+spec:
+  replicas: {{ .Values.replicaCount }}
+{{- end -}}
+```
+
+## `common.container`
+
+The `common.container` template creates a basic `Container` spec to be used
+within a `Deployment` or `ReplicaSet`. It holds the following defaults:
+
+- The name is set to the chart name
+- Uses `.Values.image` to describe the image to run, with the following spec:
+  ```yaml
+  image:
+    repository: nginx
+    tag: stable
+    pullPolicy: IfNotPresent
+  ```
+- Exposes the named port `http` as port 80
+- Lays out the compute resources using `.Values.resources`
+
+Example use:
+
+```yaml
+{{- template "common.deployment" (list . "mychart.deployment") -}}
+{{- define "mychart.deployment" -}}
+## Define overrides for your Deployment resource here, e.g.
+spec:
+  template:
+    spec:
+      containers:
+      - {{ template "common.container" (list . "mychart.deployment.container") }}
+{{- end -}}
+{{- define "mychart.deployment.container" -}}
+## Define overrides for your Container here, e.g.
+livenessProbe:
+  httpGet:
+    path: /
+    port: 80
+readinessProbe:
+  httpGet:
+    path: /
+    port: 80
+{{- end -}}
+```
+
+The above example creates a `Deployment` resource which makes use of the
+`common.container` template to populate the PodSpec's container list. The usage
+of this template is similar to the other resources, you must define and
+reference a template that contains overrides for the container object.
+
+The most important part of a container definition is the image you want to run.
+As mentioned above, this is derived from `.Values.image` by default. It is a
+best practice to define the image, tag and pull policy in your charts' values as
+this makes it easy for an operator to change the image registry, or use a
+specific tag or version. Another example of configuration that should be exposed
+to chart operators is the container's required compute resources, as this is
+also very specific to an operators environment. An example `values.yaml` for
+your chart could look like:
+
+```yaml
+image:
+  repository: nginx
+  tag: stable
+  pullPolicy: IfNotPresent
+resources:
+  limits:
+    cpu: 100m
+    memory: 128Mi
+  requests:
+    cpu: 100m
+    memory: 128Mi
+```
+
+The output of running the above values through the earlier template is:
+
+```yaml
+apiVersion: extensions/v1beta1
+kind: Deployment
+metadata:
+  labels:
+    app: deployment
+    chart: deployment-0.1.0
+    heritage: Tiller
+    release: release-name
+  name: release-name-deployment
+spec:
+  template:
+    metadata:
+      labels:
+        app: deployment
+    spec:
+      containers:
+      - image: nginx:stable
+        imagePullPolicy: IfNotPresent
+        livenessProbe:
+          httpGet:
+            path: /
+            port: 80
+        name: deployment
+        ports:
+        - containerPort: 80
+          name: http
+        readinessProbe:
+          httpGet:
+            path: /
+            port: 80
+        resources:
+          limits:
+            cpu: 100m
+            memory: 128Mi
+          requests:
+            cpu: 100m
+            memory: 128Mi
+```
+
+## `common.configmap`
+
+The `common.configmap` template creates an empty `ConfigMap` resource that you
+can override with your configuration.
+
+Example use:
+
+```yaml
+{{- template "common.configmap" (list . "mychart.configmap") -}}
+{{- define "mychart.configmap" -}}
+data:
+  zeus: cat
+  athena: cat
+  julius: cat
+  one: |-
+    {{ .Files.Get "file1.txt" }}
+{{- end -}}
+```
+
+Output:
+
+```yaml
+apiVersion: v1
+data:
+  athena: cat
+  julius: cat
+  one: This is a file.
+  zeus: cat
+kind: ConfigMap
+metadata:
+  labels:
+    app: configmap
+    chart: configmap-0.1.0
+    heritage: Tiller
+    release: release-name
+  name: release-name-configmap
+```
+
+## `common.secret`
+
+The `common.secret` template creates an empty `Secret` resource that you
+can override with your secrets.
+
+Example use:
+
+```yaml
+{{- template "common.secret" (list . "mychart.secret") -}}
+{{- define "mychart.secret" -}}
+data:
+  zeus: {{ print "cat" | b64enc }}
+  athena: {{ print "cat" | b64enc }}
+  julius: {{ print "cat" | b64enc }}
+  one: |-
+    {{ .Files.Get "file1.txt" | b64enc }}
+{{- end -}}
+```
+
+Output:
+
+```yaml
+apiVersion: v1
+data:
+  athena: Y2F0
+  julius: Y2F0
+  one: VGhpcyBpcyBhIGZpbGUuCg==
+  zeus: Y2F0
+kind: Secret
+metadata:
+  labels:
+    app: secret
+    chart: secret-0.1.0
+    heritage: Tiller
+    release: release-name
+  name: release-name-secret
+type: Opaque
+```
+
+## `common.ingress`
+
+The `common.ingress` template is designed to give you a well-defined `Ingress`
+resource, that can be configured using `.Values.ingress`. An example values file
+that can be used to configure the `Ingress` resource is:
+
+```yaml
+ingress:
+  hosts:
+  - chart-example.local
+  annotations:
+    kubernetes.io/ingress.class: nginx
+    kubernetes.io/tls-acme: "true"
+  tls:
+  - secretName: chart-example-tls
+    hosts:
+    - chart-example.local
+```
+
+Example use:
+
+```yaml
+{{- template "common.ingress" (list . "mychart.ingress") -}}
+{{- define "mychart.ingress" -}}
+{{- end -}}
+```
+
+Output:
+
+```yaml
+apiVersion: extensions/v1beta1
+kind: Ingress
+metadata:
+  annotations:
+    kubernetes.io/ingress.class: nginx
+    kubernetes.io/tls-acme: "true"
+  labels:
+    app: ingress
+    chart: ingress-0.1.0
+    heritage: Tiller
+    release: release-name
+  name: release-name-ingress
+spec:
+  rules:
+  - host: chart-example.local
+    http:
+      paths:
+      - backend:
+          serviceName: release-name-ingress
+          servicePort: 80
+        path: /
+  tls:
+  - hosts:
+    - chart-example.local
+    secretName: chart-example-tls
+```
+
+## `common.persistentvolumeclaim`
+
+`common.persistentvolumeclaim` can be used to easily add a
+`PersistentVolumeClaim` resource to your chart that can be configured using
+`.Values.persistence`:
+
+|           Value           |                                               Description                                               |
+| ------------------------- | ------------------------------------------------------------------------------------------------------- |
+| persistence.enabled       | Whether or not to claim a persistent volume. If false, `common.volume.pvc` will use an emptyDir instead |
+| persistence.storageClass  | `StorageClass` name                                                                                     |
+| persistence.accessMode    | Access mode for persistent volume                                                                       |
+| persistence.size          | Size of persistent volume                                                                               |
+| persistence.existingClaim | If defined, `PersistentVolumeClaim` is not created and `common.volume.pvc` helper uses this claim       |
+
+An example values file that can be used to configure the
+`PersistentVolumeClaim` resource is:
+
+```yaml
+persistence:
+  enabled: true
+  storageClass: fast
+  accessMode: ReadWriteOnce
+  size: 8Gi
+```
+
+Example use:
+
+```yaml
+{{- template "common.persistentvolumeclaim" (list . "mychart.persistentvolumeclaim") -}}
+{{- define "mychart.persistentvolumeclaim" -}}
+{{- end -}}
+```
+
+Output:
+
+```yaml
+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+  annotations:
+    volume.beta.kubernetes.io/storage-class: fast
+  labels:
+    app: persistentvolumeclaim
+    chart: persistentvolumeclaim-0.1.0
+    heritage: Tiller
+    release: release-name
+  name: release-name-persistentvolumeclaim
+spec:
+  accessModes:
+  - ReadWriteOnce
+  resources:
+    requests:
+      storage: 8Gi
+```
+
+## Partial API Objects
+
+When writing Kubernetes resources, you may find the following helpers useful to
+construct parts of the spec.
+
+### EnvVar
+
+Use the EnvVar helpers within a container spec to simplify specifying key-value
+environment variables or referencing secrets as values.
+
+Example Use:
+
+```yaml
+{{- template "common.deployment" (list . "mychart.deployment") -}}
+{{- define "mychart.deployment" -}}
+spec:
+  template:
+    spec:
+      containers:
+      - {{ template "common.container" (list . "mychart.deployment.container") }}
+{{- end -}}
+{{- define "mychart.deployment.container" -}}
+{{- $fullname := include "common.fullname" . -}}
+env:
+- {{ template "common.envvar.value" (list "ZEUS" "cat") }}
+- {{ template "common.envvar.secret" (list "ATHENA" "secret-name" "athena") }}
+{{- end -}}
+```
+
+Output:
+
+```yaml
+...
+    spec:
+      containers:
+      - env:
+        - name: ZEUS
+          value: cat
+        - name: ATHENA
+          valueFrom:
+            secretKeyRef:
+              key: athena
+              name: secret-name
+...
+```
+
+### Volume
+
+Use the Volume helpers within a `Deployment` spec to help define ConfigMap and
+PersistentVolumeClaim volumes.
+
+Example Use:
+
+```yaml
+{{- template "common.deployment" (list . "mychart.deployment") -}}
+{{- define "mychart.deployment" -}}
+spec:
+  template:
+    spec:
+      volumes:
+      - {{ template "common.volume.configMap" (list "config" "configmap-name") }}
+      - {{ template "common.volume.pvc" (list "data" "pvc-name" .Values.persistence) }}
+{{- end -}}
+```
+
+Output:
+
+```yaml
+...
+    spec:
+      volumes:
+      - configMap:
+          name: configmap-name
+        name: config
+      - name: data
+        persistentVolumeClaim:
+          claimName: pvc-name
+...
+```
+
+The `common.volume.pvc` helper uses the following configuration from the `.Values.persistence` object:
+
+|           Value           |                      Description                      |
+| ------------------------- | ----------------------------------------------------- |
+| persistence.enabled       | If false, creates an `emptyDir` instead               |
+| persistence.existingClaim | If set, uses this instead of the passed in claim name |
+
+## Utilities
+
+### `common.fullname`
+
+The `common.fullname` template generates a name suitable for the `name:` field
+in Kubernetes metadata. It is used like this:
+
+```yaml
+name: {{ template "common.fullname" . }}
+```
+
+The following different values can influence it:
+
+```yaml
+# By default, fullname uses '{{ .Release.Name }}-{{ .Chart.Name }}'. This
+# overrides that and uses the given string instead.
+fullnameOverride: "some-name"
+
+# This adds a prefix
+fullnamePrefix: "pre-"
+# This appends a suffix
+fullnameSuffix: "-suf"
+
+# Global versions of the above
+global:
+  fullnamePrefix: "pp-"
+  fullnameSuffix: "-ps"
+```
+
+Example output:
+
+```yaml
+---
+# with the values above
+name: pp-pre-some-name-suf-ps
+
+---
+# the default, for release "happy-panda" and chart "wordpress"
+name: happy-panda-wordpress
+```
+
+Output of this function is truncated at 54 characters, which leaves 9 additional
+characters for customized overriding. Thus you can easily extend this name
+in your own charts:
+
+```yaml
+{{- define "my.fullname" -}}
+  {{ template "common.fullname" . }}-my-stuff
+{{- end -}}
+```
+
+### `common.fullname.unique`
+
+The `common.fullname.unique` variant of fullname appends a unique seven-character
+sequence to the end of the common name field.
+
+This takes all of the same parameters as `common.fullname`
+
+Example template:
+
+```yaml
+uniqueName: {{ template "common.fullname.unique" . }}
+```
+
+Example output:
+
+```yaml
+uniqueName: release-name-fullname-jl0dbwx
+```
+
+It is also impacted by the prefix and suffix definitions, as well as by
+`.Values.fullnameOverride`
+
+Note that the effective maximum length of this function is 63 characters, not 54.
+
+### `common.name`
+
+The `common.name` template generates a name suitable for the `app` label. It is used like this:
+
+```yaml
+app: {{ template "common.name" . }}
+```
+
+The following different values can influence it:
+
+```yaml
+# By default, name uses '{{ .Chart.Name }}'. This
+# overrides that and uses the given string instead.
+nameOverride: "some-name"
+
+# This adds a prefix
+namePrefix: "pre-"
+# This appends a suffix
+nameSuffix: "-suf"
+
+# Global versions of the above
+global:
+  namePrefix: "pp-"
+  nameSuffix: "-ps"
+```
+
+Example output:
+
+```yaml
+---
+# with the values above
+name: pp-pre-some-name-suf-ps
+
+---
+# the default, for chart "wordpress"
+name: wordpress
+```
+
+Output of this function is truncated at 54 characters, which leaves 9 additional
+characters for customized overriding. Thus you can easily extend this name
+in your own charts:
+
+```yaml
+{{- define "my.name" -}}
+  {{ template "common.name" . }}-my-stuff
+{{- end -}}
+```
+
+### `common.metadata`
+
+The `common.metadata` helper generates the `metadata:` section of a Kubernetes
+resource.
+
+This takes three objects:
+  - .top: top context
+  - .fullnameOverride: override the fullname with this name
+  - .metadata
+    - .labels: key/value list of labels
+    - .annotations: key/value list of annotations
+    - .hook: name(s) of hook(s)
+
+It generates standard labels, annotations, hooks, and a name field.
+
+Example template:
+
+```yaml
+{{ template "common.metadata" (dict "top" . "metadata" .Values.bio) }}
+---
+{{ template "common.metadata" (dict "top" . "metadata" .Values.pet "fullnameOverride" .Values.pet.fullnameOverride) }}
+```
+
+Example values:
+
+```yaml
+bio:
+  name: example
+  labels:
+    first: matt
+    last: butcher
+    nick: technosophos
+  annotations:
+    format: bio
+    destination: archive
+  hook: pre-install
+
+pet:
+  fullnameOverride: Zeus
+
+```
+
+Example output:
+
+```yaml
+metadata:
+  name: release-name-metadata
+  labels:
+    app: metadata
+    heritage: "Tiller"
+    release: "RELEASE-NAME"
+    chart: metadata-0.1.0
+    first: "matt"
+    last: "butcher"
+    nick: "technosophos"
+  annotations:
+    "destination": "archive"
+    "format": "bio"
+    "helm.sh/hook": "pre-install"
+---
+metadata:
+  name: Zeus
+  labels:
+    app: metadata
+    heritage: "Tiller"
+    release: "RELEASE-NAME"
+    chart: metadata-0.1.0
+  annotations:
+```
+
+Most of the common templates that define a resource type (e.g. `common.configmap`
+or `common.job`) use this to generate the metadata, which means they inherit
+the same `labels`, `annotations`, `nameOverride`, and `hook` fields.
+
+### `common.labelize`
+
+`common.labelize` turns a map into a set of labels.
+
+Example template:
+
+```yaml
+{{- $map := dict "first" "1" "second" "2" "third" "3" -}}
+{{- template "common.labelize" $map -}}
+```
+
+Example output:
+
+```yaml
+first: "1"
+second: "2"
+third: "3"
+```
+
+### `common.labels.standard`
+
+`common.labels.standard` prints the standard set of labels.
+
+Example usage:
+
+```
+{{ template "common.labels.standard" . }}
+```
+
+Example output:
+
+```yaml
+app: labelizer
+heritage: "Tiller"
+release: "RELEASE-NAME"
+chart: labelizer-0.1.0
+```
+
+### `common.hook`
+
+The `common.hook` template is a convenience for defining hooks.
+
+Example template:
+
+```yaml
+{{ template "common.hook" "pre-install,post-install" }}
+```
+
+Example output:
+
+```yaml
+"helm.sh/hook": "pre-install,post-install"
+```
+
+### `common.chartref`
+
+The `common.chartref` helper prints the chart name and version, escaped to be
+legal in a Kubernetes label field.
+
+Example template:
+
+```yaml
+chartref: {{ template "common.chartref" . }}
+```
+
+For the chart `foo` with version `1.2.3-beta.55+1234`, this will render:
+
+```yaml
+chartref: foo-1.2.3-beta.55_1234
+```
+
+(Note that `+` is an illegal character in label values)
diff --git a/incubator/common/templates/_chartref.tpl b/incubator/common/templates/_chartref.tpl
new file mode 100644
index 0000000000..e6c14866fe
--- /dev/null
+++ b/incubator/common/templates/_chartref.tpl
@@ -0,0 +1,14 @@
+{{- /*
+common.chartref prints a chart name and version.
+
+It does minimal escaping for use in Kubernetes labels.
+
+Example output:
+
+  zookeeper-1.2.3
+  wordpress-3.2.1_20170219
+
+*/ -}}
+{{- define "common.chartref" -}}
+  {{- replace "+" "_" .Chart.Version | printf "%s-%s" .Chart.Name -}}
+{{- end -}}
diff --git a/incubator/common/templates/_configmap.yaml b/incubator/common/templates/_configmap.yaml
new file mode 100644
index 0000000000..03dbbf858a
--- /dev/null
+++ b/incubator/common/templates/_configmap.yaml
@@ -0,0 +1,9 @@
+{{- define "common.configmap.tpl" -}}
+apiVersion: v1
+kind: ConfigMap
+{{ template "common.metadata" . }}
+data: {}
+{{- end -}}
+{{- define "common.configmap" -}}
+{{- template "common.util.merge" (append . "common.configmap.tpl") -}}
+{{- end -}}
diff --git a/incubator/common/templates/_container.yaml b/incubator/common/templates/_container.yaml
new file mode 100644
index 0000000000..540eb0e6ab
--- /dev/null
+++ b/incubator/common/templates/_container.yaml
@@ -0,0 +1,15 @@
+{{- define "common.container.tpl" -}}
+name: {{ .Chart.Name }}
+image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
+imagePullPolicy: {{ .Values.image.pullPolicy }}
+ports:
+- name: http
+  containerPort: 80
+resources:
+{{ toYaml .Values.resources | indent 2 }}
+{{- end -}}
+{{- define "common.container" -}}
+{{- /* clear new line so indentation works correctly */ -}}
+{{- println "" -}}
+{{- include "common.util.merge" (append . "common.container.tpl") | indent 8 -}}
+{{- end -}}
diff --git a/incubator/common/templates/_deployment.yaml b/incubator/common/templates/_deployment.yaml
new file mode 100644
index 0000000000..c49dae3eb1
--- /dev/null
+++ b/incubator/common/templates/_deployment.yaml
@@ -0,0 +1,18 @@
+{{- define "common.deployment.tpl" -}}
+apiVersion: extensions/v1beta1
+kind: Deployment
+{{ template "common.metadata" . }}
+spec:
+  template:
+    metadata:
+      labels:
+        app: {{ template "common.name" . }}
+        release: {{ .Release.Name | quote }}
+    spec:
+      containers:
+      -
+{{ include "common.container.tpl" . | indent 8 }}
+{{- end -}}
+{{- define "common.deployment" -}}
+{{- template "common.util.merge" (append . "common.deployment.tpl") -}}
+{{- end -}}
diff --git a/incubator/common/templates/_envvar.tpl b/incubator/common/templates/_envvar.tpl
new file mode 100644
index 0000000000..832b60448b
--- /dev/null
+++ b/incubator/common/templates/_envvar.tpl
@@ -0,0 +1,19 @@
+{{- define "common.envvar.value" -}}
+  {{- $name := index . 0 -}}
+  {{- $value := index . 1 -}}
+
+  name: {{ $name }}
+  value: {{ default "" $value | quote }}
+{{- end -}}
+
+{{- define "common.envvar.secret" -}}
+  {{- $name := index . 0 -}}
+  {{- $secretName := index . 1 -}}
+  {{- $secretKey := index . 2 -}}
+
+  name: {{ $name }}
+  valueFrom:
+    secretKeyRef:
+      name: {{ $secretName }}
+      key: {{ $secretKey }}
+{{- end -}}
diff --git a/incubator/common/templates/_fullname.tpl b/incubator/common/templates/_fullname.tpl
new file mode 100644
index 0000000000..2da6cdf18c
--- /dev/null
+++ b/incubator/common/templates/_fullname.tpl
@@ -0,0 +1,39 @@
+{{- /*
+fullname defines a suitably unique name for a resource by combining
+the release name and the chart name.
+
+The prevailing wisdom is that names should only contain a-z, 0-9 plus dot (.) and dash (-), and should
+not exceed 63 characters.
+
+Parameters:
+
+- .Values.fullnameOverride: Replaces the computed name with this given name
+- .Values.fullnamePrefix: Prefix
+- .Values.global.fullnamePrefix: Global prefix
+- .Values.fullnameSuffix: Suffix
+- .Values.global.fullnameSuffix: Global suffix
+
+The applied order is: "global prefix + prefix + name + suffix + global suffix"
+
+Usage: 'name: "{{- template "common.fullname" . -}}"'
+*/ -}}
+{{- define "common.fullname"}}
+  {{- $global := default (dict) .Values.global -}}
+  {{- $base := default (printf "%s-%s" .Release.Name .Chart.Name) .Values.fullnameOverride -}}
+  {{- $gpre := default "" $global.fullnamePrefix -}}
+  {{- $pre := default "" .Values.fullnamePrefix -}}
+  {{- $suf := default "" .Values.fullnameSuffix -}}
+  {{- $gsuf := default "" $global.fullnameSuffix -}}
+  {{- $name := print $gpre $pre $base $suf $gsuf -}}
+  {{- $name | lower | trunc 54 | trimSuffix "-" -}}
+{{- end -}}
+
+{{- /*
+common.fullname.unique adds a random suffix to the unique name.
+
+This takes the same parameters as common.fullname
+
+*/ -}}
+{{- define "common.fullname.unique" -}}
+  {{ template "common.fullname" . }}-{{ randAlphaNum 7 | lower }}
+{{- end }}
diff --git a/incubator/common/templates/_ingress.yaml b/incubator/common/templates/_ingress.yaml
new file mode 100644
index 0000000000..522ab2425d
--- /dev/null
+++ b/incubator/common/templates/_ingress.yaml
@@ -0,0 +1,27 @@
+{{- define "common.ingress.tpl" -}}
+apiVersion: extensions/v1beta1
+kind: Ingress
+{{ template "common.metadata" . }}
+  {{- if .Values.ingress.annotations }}
+  annotations:
+    {{ include "common.annote" .Values.ingress.annotations | indent 4 }}
+  {{- end }}
+spec:
+  rules:
+  {{- range $host := .Values.ingress.hosts }}
+  - host: {{ $host }}
+    http:
+      paths:
+      - path: /
+        backend:
+          serviceName: {{ template "common.fullname" $ }}
+          servicePort: 80
+  {{- end }}
+  {{- if .Values.ingress.tls }}
+  tls:
+{{ toYaml .Values.ingress.tls | indent 4 }}
+  {{- end -}}
+{{- end -}}
+{{- define "common.ingress" -}}
+{{- template "common.util.merge" (append . "common.ingress.tpl") -}}
+{{- end -}}
diff --git a/incubator/common/templates/_metadata.yaml b/incubator/common/templates/_metadata.yaml
new file mode 100644
index 0000000000..f96ed09fe5
--- /dev/null
+++ b/incubator/common/templates/_metadata.yaml
@@ -0,0 +1,10 @@
+{{- /*
+common.metadata creates a standard metadata header.
+It creates a 'metadata:' section with name and labels.
+*/ -}}
+{{ define "common.metadata" -}}
+metadata:
+  name: {{ template "common.fullname" . }}
+  labels:
+{{ include "common.labels.standard" . | indent 4 -}}
+{{- end -}}
diff --git a/incubator/common/templates/_metadata_annotations.tpl b/incubator/common/templates/_metadata_annotations.tpl
new file mode 100644
index 0000000000..0c3b61c7c0
--- /dev/null
+++ b/incubator/common/templates/_metadata_annotations.tpl
@@ -0,0 +1,18 @@
+{{- /*
+common.hook defines a hook.
+
+This is to be used in a 'metadata.annotations' section.
+
+This should be called as 'template "common.metadata.hook" "post-install"'
+
+Any valid hook may be passed in. Separate multiple hooks with a ",".
+*/ -}}
+{{- define "common.hook" -}}
+"helm.sh/hook": {{printf "%s" . | quote}}
+{{- end -}}
+
+{{- define "common.annote" -}}
+{{- range $k, $v := . }}
+{{ $k | quote }}: {{ $v | quote }}
+{{- end -}}
+{{- end -}}
diff --git a/incubator/common/templates/_metadata_labels.tpl b/incubator/common/templates/_metadata_labels.tpl
new file mode 100644
index 0000000000..15fe00c5f3
--- /dev/null
+++ b/incubator/common/templates/_metadata_labels.tpl
@@ -0,0 +1,28 @@
+{{- /*
+common.labelize takes a dict or map and generates labels.
+
+Values will be quoted. Keys will not.
+
+Example output:
+
+  first: "Matt"
+  last: "Butcher"
+
+*/ -}}
+{{- define "common.labelize" -}}
+{{- range $k, $v := . }}
+{{ $k }}: {{ $v | quote }}
+{{- end -}}
+{{- end -}}
+
+{{- /*
+common.labels.standard prints the standard Helm labels.
+
+The standard labels are frequently used in metadata.
+*/ -}}
+{{- define "common.labels.standard" -}}
+app: {{ template "common.name" . }}
+chart: {{ template "common.chartref" . }}
+heritage: {{ .Release.Service | quote }}
+release: {{ .Release.Name | quote }}
+{{- end -}}
diff --git a/incubator/common/templates/_name.tpl b/incubator/common/templates/_name.tpl
new file mode 100644
index 0000000000..1d42fb0682
--- /dev/null
+++ b/incubator/common/templates/_name.tpl
@@ -0,0 +1,29 @@
+{{- /*
+name defines a template for the name of the chart. It should be used for the `app` label. 
+This is common practice in many Kubernetes manifests, and is not Helm-specific.
+
+The prevailing wisdom is that names should only contain a-z, 0-9 plus dot (.) and dash (-), and should
+not exceed 63 characters.
+
+Parameters:
+
+- .Values.nameOverride: Replaces the computed name with this given name
+- .Values.namePrefix: Prefix
+- .Values.global.namePrefix: Global prefix
+- .Values.nameSuffix: Suffix
+- .Values.global.nameSuffix: Global suffix
+
+The applied order is: "global prefix + prefix + name + suffix + global suffix"
+
+Usage: 'name: "{{- template "common.name" . -}}"'
+*/ -}}
+{{- define "common.name"}}
+  {{- $global := default (dict) .Values.global -}}
+  {{- $base := default .Chart.Name .Values.nameOverride -}}
+  {{- $gpre := default "" $global.namePrefix -}}
+  {{- $pre := default "" .Values.namePrefix -}}
+  {{- $suf := default "" .Values.nameSuffix -}}
+  {{- $gsuf := default "" $global.nameSuffix -}}
+  {{- $name := print $gpre $pre $base $suf $gsuf -}}
+  {{- $name | lower | trunc 54 | trimSuffix "-" -}}
+{{- end -}}
diff --git a/incubator/common/templates/_persistentvolumeclaim.yaml b/incubator/common/templates/_persistentvolumeclaim.yaml
new file mode 100644
index 0000000000..fabfb297dc
--- /dev/null
+++ b/incubator/common/templates/_persistentvolumeclaim.yaml
@@ -0,0 +1,21 @@
+{{- define "common.persistentvolumeclaim.tpl" -}}
+apiVersion: v1
+kind: PersistentVolumeClaim
+{{ template "common.metadata" . }}
+  annotations:
+  {{- if .Values.persistence.storageClass }}
+    volume.beta.kubernetes.io/storage-class: {{ .Values.persistence.storageClass | quote }}
+  {{- end }}
+spec:
+  accessModes:
+    - {{ .Values.persistence.accessMode | quote }}
+  resources:
+    requests:
+      storage: {{ .Values.persistence.size | quote }}
+{{- end -}}
+{{- define "common.persistentvolumeclaim" -}}
+{{- $top := first . -}}
+{{- if and $top.Values.persistence.enabled (not $top.Values.persistence.existingClaim) -}}
+{{- template "common.util.merge" (append . "common.persistentvolumeclaim.tpl") -}}
+{{- end -}}
+{{- end -}}
diff --git a/incubator/common/templates/_secret.yaml b/incubator/common/templates/_secret.yaml
new file mode 100644
index 0000000000..0615d35cb4
--- /dev/null
+++ b/incubator/common/templates/_secret.yaml
@@ -0,0 +1,10 @@
+{{- define "common.secret.tpl" -}}
+apiVersion: v1
+kind: Secret
+{{ template "common.metadata" . }}
+type: Opaque
+data: {}
+{{- end -}}
+{{- define "common.secret" -}}
+{{- template "common.util.merge" (append . "common.secret.tpl") -}}
+{{- end -}}
diff --git a/incubator/common/templates/_service.yaml b/incubator/common/templates/_service.yaml
new file mode 100644
index 0000000000..67379525fe
--- /dev/null
+++ b/incubator/common/templates/_service.yaml
@@ -0,0 +1,17 @@
+{{- define "common.service.tpl" -}}
+apiVersion: v1
+kind: Service
+{{ template "common.metadata" . }}
+spec:
+  type: {{ .Values.service.type }}
+  ports:
+  - name: http
+    port: 80
+    targetPort: http
+  selector:
+    app: {{ template "common.name" . }}
+    release: {{ .Release.Name | quote }}
+{{- end -}}
+{{- define "common.service" -}}
+{{- template "common.util.merge" (append . "common.service.tpl") -}}
+{{- end -}}
diff --git a/incubator/common/templates/_util.tpl b/incubator/common/templates/_util.tpl
new file mode 100644
index 0000000000..49ee376c8c
--- /dev/null
+++ b/incubator/common/templates/_util.tpl
@@ -0,0 +1,15 @@
+{{- /*
+common.util.merge will merge two YAML templates and output the result.
+
+This takes an array of three values:
+- the top context
+- the template name of the overrides (destination)
+- the template name of the base (source)
+
+*/ -}}
+{{- define "common.util.merge" -}}
+{{- $top := first . -}}
+{{- $overrides := fromYaml (include (index . 1) $top) -}}
+{{- $tpl := fromYaml (include (index . 2) $top) -}}
+{{- toYaml (merge $overrides $tpl) -}}
+{{- end -}}
diff --git a/incubator/common/templates/_volume.tpl b/incubator/common/templates/_volume.tpl
new file mode 100644
index 0000000000..521a1f48b0
--- /dev/null
+++ b/incubator/common/templates/_volume.tpl
@@ -0,0 +1,22 @@
+{{- define "common.volume.configMap" -}}
+        {{- $name := index . 0 -}}
+        {{- $configMapName := index . 1 -}}
+
+        name: {{ $name }}
+        configMap:
+          name: {{ $configMapName }}
+{{- end -}}
+
+{{- define "common.volume.pvc" -}}
+        {{- $name := index . 0 -}}
+        {{- $claimName := index . 1 -}}
+        {{- $persistence := index . 2 -}}
+
+        name: {{ $name }}
+        {{- if $persistence.enabled }}
+        persistentVolumeClaim:
+          claimName: {{ $persistence.existingClaim | default $claimName }}
+        {{- else }}
+        emptyDir: {}
+        {{- end -}}
+{{- end -}}
diff --git a/incubator/common/values.yaml b/incubator/common/values.yaml
new file mode 100644
index 0000000000..b7cf514d56
--- /dev/null
+++ b/incubator/common/values.yaml
@@ -0,0 +1,4 @@
+# Default values for commons.
+# This is a YAML-formatted file.
+# Declare name/value pairs to be passed into your templates.
+# name: value
diff --git a/test/changed.sh b/test/changed.sh
index aa100acc1b..40b525897c 100755
--- a/test/changed.sh
+++ b/test/changed.sh
@@ -60,7 +60,9 @@ helm repo add incubator ${INCUBATOR_REPO_URL}
 # Iterate over each of the changed charts
 #    Lint, install and delete
 for directory in ${CHANGED_FOLDERS}; do
-  if [ -d $directory ]; then
+  if [ "$directory" == "incubator/common" ]; then
+    continue
+  elif [ -d $directory ]; then
     CHART_NAME=`echo ${directory} | cut -d '/' -f2`
     RELEASE_NAME="${CHART_NAME:0:7}-${BUILD_NUMBER}"
     CURRENT_RELEASE=${RELEASE_NAME}