From d4714f047609b5dcf5dc2c9a18c51efd5af36b7e Mon Sep 17 00:00:00 2001
From: Dario Blanco <dblancoit@gmail.com>
Date: Thu, 20 Jun 2019 12:36:48 +0200
Subject: [PATCH] [stable/hubot] Add OWNERS file (#14784)

* Add OWNERS file

Signed-off-by: Dario Blanco <dblanco@minddoc.de>

* Replace http for tcp probes

Signed-off-by: Dario Blanco <dblanco@minddoc.de>

* Remove default health coffee script

Signed-off-by: Dario Blanco <dblanco@minddoc.de>

* Remove default health script from README

Signed-off-by: Dario Blanco <dblanco@minddoc.de>
---
 stable/hubot/Chart.yaml                |  2 +-
 stable/hubot/OWNERS                    |  4 +++
 stable/hubot/README.md                 | 43 ++++++++++++--------------
 stable/hubot/templates/deployment.yaml | 10 +++---
 stable/hubot/values.yaml               |  7 +----
 5 files changed, 30 insertions(+), 36 deletions(-)
 create mode 100644 stable/hubot/OWNERS

diff --git a/stable/hubot/Chart.yaml b/stable/hubot/Chart.yaml
index 4e40be9dcb..1ec431bb1c 100644
--- a/stable/hubot/Chart.yaml
+++ b/stable/hubot/Chart.yaml
@@ -1,7 +1,7 @@
 apiVersion: v1
 description: Hubot chatbot for Slack
 name: hubot
-version: 0.0.1
+version: 0.0.2
 appVersion: 0.1.9
 home: https://github.com/mind-doc/hubot
 sources:
diff --git a/stable/hubot/OWNERS b/stable/hubot/OWNERS
new file mode 100644
index 0000000000..3ee6653c63
--- /dev/null
+++ b/stable/hubot/OWNERS
@@ -0,0 +1,4 @@
+approvers:
+- darioblanco
+reviewers:
+- darioblanco
diff --git a/stable/hubot/README.md b/stable/hubot/README.md
index 26a17963a6..ed145a3269 100644
--- a/stable/hubot/README.md
+++ b/stable/hubot/README.md
@@ -7,7 +7,7 @@ Learn more: https://github.com/mind-doc/hubot
 ## TL;DR;
 
 ```bash
-$ helm install stable/hubot
+helm install stable/hubot
 ```
 
 ## Introduction
@@ -24,18 +24,21 @@ cluster using the [Helm](https://helm.sh) package manager.
 To install the chart with the release name `my-release`:
 
 ```bash
-$ helm install --name my-release stable/hubot
+helm install --name my-release stable/hubot
 ```
 
-The command deploys Hubot on the Kubernetes cluster using the default configuration. The [configuration](#configuration) section lists the parameters that can be configured during installation.
+The command deploys Hubot on the Kubernetes cluster using the default configuration.
+The [configuration](#configuration) section lists the parameters that can be
+configured during installation.
 
 ## Uninstalling the Chart
 
 To uninstall/delete the `my-release` deployment:
 
 ```bash
-$ helm delete --purge my-release
+helm delete --purge my-release
 ```
+
 The command removes all the Kubernetes components associated with the chart and deletes the release.
 
 ## Configuration
@@ -65,8 +68,8 @@ Parameter | Description | Default
 `hubot.scripts` | custom hubot scripts | `{ health.coffee: <script content> }`
 `hubot.slackToken` | slack hubot integration token | `''`
 
-
-Specify each parameter using the `--set key=value[,key=value]` argument to `helm install`. For example,
+Specify each parameter using the `--set key=value[,key=value]` argument to `helm install`.
+For example:
 
 ```bash
 $ helm install --name my-release \
@@ -74,7 +77,8 @@ $ helm install --name my-release \
     stable/hubot
 ```
 
-Alternatively, a YAML file that specifies the values for the parameters can be provided while installing the chart. For example,
+Alternatively, a YAML file that specifies the values for the parameters can be
+provided while installing the chart. For example,
 
 ```bash
 # example for staging
@@ -87,11 +91,13 @@ $ helm install --name my-release -f values.yaml stable/hubot
 
 #### Config
 
-With the `hubot.config` parameter you can provide a hash that will be used as environment variables by hubot. These environment variables will be picked by hubot's scripts.
+With the `hubot.config` parameter you can provide a hash that will be used as
+environment variables by hubot. These environment variables will be picked by
+hubot's scripts.
 
 For instance:
 
-```
+```yaml
 hubot:
   config:
     HUBOT_STANDUP_PREPEND: '@channel'
@@ -99,22 +105,13 @@ hubot:
 
 #### Scripts
 
-In addition, you can add your own scripts, which will be created in the scripts folder, with `.js` or `.coffee` format. See [Hubot Scripting](https://hubot.github.com/docs/scripting/).
+In addition, you can add your own scripts, which will be created in the scripts
+folder, with `.js` or `.coffee` format.
+See [Hubot Scripting](https://hubot.github.com/docs/scripting/).
 
-By default, this chart adds a health endpoint so Kubernetes can probe the pod.
+For example:
 
-```
-hubot:
-  scripts:
-    health.coffee: |
-      # Description
-      #   A hubot script that exposes a health endpoint
-      module.exports = (robot) ->
-        robot.router.get '/health', (req, res) -> res.status(200).end()
-```
-
-You can follow the same format for creating your own hubot scripts
-```
+```yaml
 hubot:
   scripts:
     hithere.coffee: |
diff --git a/stable/hubot/templates/deployment.yaml b/stable/hubot/templates/deployment.yaml
index 16d60ce093..389bd76016 100644
--- a/stable/hubot/templates/deployment.yaml
+++ b/stable/hubot/templates/deployment.yaml
@@ -32,13 +32,11 @@ spec:
               containerPort: 8080
               protocol: TCP
           livenessProbe:
-            httpGet:
-              path: /health
-              port: http
+            tcpSocket:
+              port: 8080
           readinessProbe:
-            httpGet:
-              path: /health
-              port: http
+            tcpSocket:
+              port: 8080
           volumeMounts:
             - name: {{ template "hubot.fullname" . }}-scripts
               mountPath: {{ .Values.hubot.scriptsFolder }}
diff --git a/stable/hubot/values.yaml b/stable/hubot/values.yaml
index 465a7a23ec..8917963db3 100644
--- a/stable/hubot/values.yaml
+++ b/stable/hubot/values.yaml
@@ -49,11 +49,6 @@ hubot:
 
   scriptsFolder: /minddocbot/scripts
 
-  scripts:
-    health.coffee: |
-      # Description
-      #   A hubot script that exposes a health endpoint
-      module.exports = (robot) ->
-        robot.router.get '/health', (req, res) -> res.status(200).end()
+  scripts: {}
 
   slackToken: ''