From ba4806aefec2202f6ad312c45704bfa9af194bd3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Rodr=C3=ADguez=20Hern=C3=A1ndez?= Date: Tue, 28 May 2019 20:49:36 +0200 Subject: [PATCH] [stable/mediawiki] Use immutable tags (#14210) * Bump chart version Signed-off-by: Carlos Rodriguez Hernandez * [stable/mediawiki] Use immutable tags Signed-off-by: Carlos Rodriguez Hernandez --- stable/mediawiki/Chart.yaml | 2 +- stable/mediawiki/README.md | 8 +++++++- stable/mediawiki/templates/NOTES.txt | 7 +++++++ stable/mediawiki/values.yaml | 2 +- 4 files changed, 16 insertions(+), 3 deletions(-) diff --git a/stable/mediawiki/Chart.yaml b/stable/mediawiki/Chart.yaml index 327b67fbdb..e127d5f062 100644 --- a/stable/mediawiki/Chart.yaml +++ b/stable/mediawiki/Chart.yaml @@ -1,6 +1,6 @@ apiVersion: v1 name: mediawiki -version: 6.2.1 +version: 6.2.2 appVersion: 1.32.1 description: Extremely powerful, scalable software and a feature-rich wiki implementation that uses PHP to process and display data stored in a database. home: http://www.mediawiki.org/ diff --git a/stable/mediawiki/README.md b/stable/mediawiki/README.md index 1bcc2cc407..590a8e429a 100644 --- a/stable/mediawiki/README.md +++ b/stable/mediawiki/README.md @@ -53,7 +53,7 @@ The following table lists the configurable parameters of the MediaWiki chart and | `global.imagePullSecrets` | Global Docker registry secret names as an array | `[]` (does not add image pull secrets to deployed pods) | | `image.registry` | MediaWiki image registry | `docker.io` | | `image.repository` | MediaWiki Image name | `bitnami/mediawiki` | -| `image.tag` | MediaWiki Image tag | `{VERSION}` | +| `image.tag` | MediaWiki Image tag | `{TAG_NAME}` | | `image.pullPolicy` | Image pull policy | `Always` | | `image.pullSecrets` | Specify docker-registry secret names as an array | `[]` (does not add image pull secrets to deployed pods) | | `mediawikiUser` | User of the application | `user` | @@ -140,6 +140,12 @@ $ helm install --name my-release -f values.yaml stable/mediawiki > **Tip**: You can use the default [values.yaml](values.yaml) +### [Rolling VS Immutable tags](https://docs.bitnami.com/containers/how-to/understand-rolling-tags-containers/) + +It is strongly recommended to use immutable tags in a production environment. This ensures your deployment does not change automatically if the same tag is updated with a different image. + +Bitnami will release a new chart updating its containers if a new version of the main container, significant changes, or critical vulnerabilities exist. + ## Persistence The [Bitnami MediaWiki](https://github.com/bitnami/bitnami-docker-mediawiki) image stores the MediaWiki data and configurations at the `/bitnami/mediawiki` and `/bitnami/apache` paths of the container. diff --git a/stable/mediawiki/templates/NOTES.txt b/stable/mediawiki/templates/NOTES.txt index 306ec85872..d5ae3bb115 100644 --- a/stable/mediawiki/templates/NOTES.txt +++ b/stable/mediawiki/templates/NOTES.txt @@ -59,3 +59,10 @@ host. To configure MediaWiki to use and external database host: helm upgrade {{ .Release.Name }} --set service.type={{ .Values.service.type }},mariadb.enabled=false,externalDatabase.host=YOUR_EXTERNAL_DATABASE_HOST stable/mediawiki {{- end}} + +{{- if and (contains "bitnami/" .Values.image.repository) (not (.Values.image.tag | regexFind "-r\\d+$")) }} + +WARNING: Rolling tag detected ({{ .Values.image.repository }}:{{ .Values.image.tag }}), please note that it is strongly recommended to avoid using rolling tags in a production environment. ++info https://docs.bitnami.com/containers/how-to/understand-rolling-tags-containers/ + +{{- end }} diff --git a/stable/mediawiki/values.yaml b/stable/mediawiki/values.yaml index 07635cafa8..01dfd587dd 100644 --- a/stable/mediawiki/values.yaml +++ b/stable/mediawiki/values.yaml @@ -13,7 +13,7 @@ image: registry: docker.io repository: bitnami/mediawiki - tag: 1.32.1 + tag: 1.32.1-debian-9-r17 ## Specify a imagePullPolicy ## Defaults to 'Always' if image tag is 'latest', else set to 'IfNotPresent' ## ref: http://kubernetes.io/docs/user-guide/images/#pre-pulling-images