From b9ce48d911f99bdcd2eabd43343005cf1fc8fa1e Mon Sep 17 00:00:00 2001 From: Anas Date: Wed, 19 Jun 2019 19:48:39 +0200 Subject: [PATCH] [incubator/buzzfeed-sso] Make auth application ingress path configurable (#14832) * Fix sso-auth app ingress path. Signed-off-by: Anas Ait Said Oubrahim * Bump chart version. Signed-off-by: Anas Ait Said Oubrahim * Make ingress Auth path configurable. Signed-off-by: Anas Ait Said Oubrahim * Document new value. Signed-off-by: Anas Ait Said Oubrahim --- incubator/buzzfeed-sso/Chart.yaml | 2 +- incubator/buzzfeed-sso/README.md | 1 + incubator/buzzfeed-sso/templates/ingress.yaml | 2 +- incubator/buzzfeed-sso/values.yaml | 4 ++++ 4 files changed, 7 insertions(+), 2 deletions(-) diff --git a/incubator/buzzfeed-sso/Chart.yaml b/incubator/buzzfeed-sso/Chart.yaml index bd403fbc9c..4d52096fec 100644 --- a/incubator/buzzfeed-sso/Chart.yaml +++ b/incubator/buzzfeed-sso/Chart.yaml @@ -1,7 +1,7 @@ apiVersion: v1 description: Single sign-on for your Kubernetes services using Google OAuth name: buzzfeed-sso -version: 0.0.6 +version: 0.0.7 appVersion: 1.2.0 home: https://github.com/buzzfeed/sso sources: diff --git a/incubator/buzzfeed-sso/README.md b/incubator/buzzfeed-sso/README.md index 34bc787db0..663db75dcd 100644 --- a/incubator/buzzfeed-sso/README.md +++ b/incubator/buzzfeed-sso/README.md @@ -66,6 +66,7 @@ Parameter | Description | Default `auth.service.type` | type of auth service to create | `ClusterIP` `auth.service.port` | port for the http auth service | `80` `auth.secret` | secrets to be generated randomly with `openssl rand -base64 32 | head -c 32`. | REQUIRED if `auth.customSecret` is not set +`auth.ingressPath` | auth ingress path. | `/` `auth.tls` | tls configuration for central sso auth ingress. | `{}` `auth.customSecret` | the secret key to reuse (avoids secret creation via helm) | REQUIRED if `auth.secret` is not set `proxy.annotations` | extra annotations for proxy pods | `{}` diff --git a/incubator/buzzfeed-sso/templates/ingress.yaml b/incubator/buzzfeed-sso/templates/ingress.yaml index 36aaecb0d4..7aecd5e554 100644 --- a/incubator/buzzfeed-sso/templates/ingress.yaml +++ b/incubator/buzzfeed-sso/templates/ingress.yaml @@ -48,7 +48,7 @@ spec: - host: {{ $authDomain }} http: paths: - - path: / + - path: {{ .Values.auth.ingressPath }} backend: serviceName: {{ $fullName }}-auth servicePort: http diff --git a/incubator/buzzfeed-sso/values.yaml b/incubator/buzzfeed-sso/values.yaml index 1eefb36145..63e9b7f5ca 100644 --- a/incubator/buzzfeed-sso/values.yaml +++ b/incubator/buzzfeed-sso/values.yaml @@ -27,6 +27,10 @@ auth: # cookieSecret: '' # # Or if you do not want to create the secret via helm # customSecret: my-sso-auth-secret + # Auth application ingress path. + # For GKE and AWS ALB ingresses use "/*" + # For Nginx ingress use "/" + ingressPath: / tls: {} # secretName: sso-auth-tls-secret