From b4fdac0e30a82658b95a8ce406ecb9f73afcf2b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Rodr=C3=ADguez=20Hern=C3=A1ndez?= Date: Tue, 28 May 2019 22:25:30 +0200 Subject: [PATCH] [stable/redmine] Use immutable tags (#14192) * Bump chart version Signed-off-by: Carlos Rodriguez Hernandez * [stable/redmine] Use immutable tags Signed-off-by: Carlos Rodriguez Hernandez --- stable/redmine/Chart.yaml | 2 +- stable/redmine/README.md | 8 +++++++- stable/redmine/templates/NOTES.txt | 7 +++++++ stable/redmine/values.yaml | 2 +- 4 files changed, 16 insertions(+), 3 deletions(-) diff --git a/stable/redmine/Chart.yaml b/stable/redmine/Chart.yaml index 43255d758e..40c027fe5c 100644 --- a/stable/redmine/Chart.yaml +++ b/stable/redmine/Chart.yaml @@ -1,6 +1,6 @@ apiVersion: v1 name: redmine -version: 10.0.0 +version: 10.0.1 appVersion: 4.0.3 description: A flexible project management web application. keywords: diff --git a/stable/redmine/README.md b/stable/redmine/README.md index 9f6310a7d2..d39c399b1b 100644 --- a/stable/redmine/README.md +++ b/stable/redmine/README.md @@ -61,7 +61,7 @@ The following table lists the configurable parameters of the Redmine chart and t | `global.imagePullSecrets` | Global Docker registry secret names as an array | `[]` (does not add image pull secrets to deployed pods) | | `image.registry` | Redmine image registry | `docker.io` | | `image.repository` | Redmine image name | `bitnami/redmine` | -| `image.tag` | Redmine image tag | `{VERSION}` | +| `image.tag` | Redmine image tag | `{TAG_NAME}` | | `image.pullPolicy` | Image pull policy | `Always` if `imageTag` is `latest`, else `IfNotPresent` | | `image.pullSecrets` | Specify docker-registry secret names as an array | `[]` (does not add image pull secrets to deployed pods) | | `redmineUsername` | User of the application | `user` | @@ -135,6 +135,12 @@ $ helm install --name my-release -f values.yaml stable/redmine > **Tip**: You can use the default [values.yaml](values.yaml) +### [Rolling VS Immutable tags](https://docs.bitnami.com/containers/how-to/understand-rolling-tags-containers/) + +It is strongly recommended to use immutable tags in a production environment. This ensures your deployment does not change automatically if the same tag is updated with a different image. + +Bitnami will release a new chart updating its containers if a new version of the main container, significant changes, or critical vulnerabilities exist. + ## Replicas Redmine writes uploaded files to a persistent volume. By default that volume diff --git a/stable/redmine/templates/NOTES.txt b/stable/redmine/templates/NOTES.txt index 589917616f..24e55791f9 100644 --- a/stable/redmine/templates/NOTES.txt +++ b/stable/redmine/templates/NOTES.txt @@ -50,3 +50,10 @@ You have 4 alternatives: echo Username: {{ .Values.redmineUsername }} echo Password: $(kubectl get secret --namespace {{ .Release.Namespace }} {{ template "redmine.fullname" . }} -o jsonpath="{.data.redmine-password}" | base64 --decode) {{- end }} + +{{- if and (contains "bitnami/" .Values.image.repository) (not (.Values.image.tag | regexFind "-r\\d+$")) }} + +WARNING: Rolling tag detected ({{ .Values.image.repository }}:{{ .Values.image.tag }}), please note that it is strongly recommended to avoid using rolling tags in a production environment. ++info https://docs.bitnami.com/containers/how-to/understand-rolling-tags-containers/ + +{{- end }} diff --git a/stable/redmine/values.yaml b/stable/redmine/values.yaml index a160d77ace..4090a79439 100644 --- a/stable/redmine/values.yaml +++ b/stable/redmine/values.yaml @@ -13,7 +13,7 @@ image: registry: docker.io repository: bitnami/redmine - tag: 4.0.3 + tag: 4.0.3-debian-9-r31 ## Specify a imagePullPolicy ## Defaults to 'Always' if image tag is 'latest', else set to 'IfNotPresent' ## ref: http://kubernetes.io/docs/user-guide/images/#pre-pulling-images