From a6e32a7b637f86246a1041a74e37a67eb3cc7c97 Mon Sep 17 00:00:00 2001 From: Denis Mikhaylov Date: Sat, 9 Dec 2017 15:23:07 +0300 Subject: [PATCH] [stable/metabase] Make plugins directory configurable (#2722) * Make plugins directory configurable * Make linter happy * Update README.md --- stable/metabase/Chart.yaml | 4 ++-- stable/metabase/README.md | 3 ++- stable/metabase/templates/deployment.yaml | 4 ++++ stable/metabase/values.yaml | 11 ++++++----- 4 files changed, 14 insertions(+), 8 deletions(-) diff --git a/stable/metabase/Chart.yaml b/stable/metabase/Chart.yaml index 3a4c084d8a..7cebb3b404 100644 --- a/stable/metabase/Chart.yaml +++ b/stable/metabase/Chart.yaml @@ -2,8 +2,8 @@ apiVersion: v1 description: The easy, open source way for everyone in your company to ask questions and learn from data. name: metabase -version: 0.2.0 -appVersion: v0.24.2 +version: 0.3.0 +appVersion: v0.26.2 maintainers: - name: pmint93 email: phamminhthanh69@gmail.com diff --git a/stable/metabase/README.md b/stable/metabase/README.md index 43ab4152eb..dd3a793f2a 100644 --- a/stable/metabase/README.md +++ b/stable/metabase/README.md @@ -46,7 +46,7 @@ The following tables lists the configurable parameters of the Metabase chart and |------------------------|------------------------------------------------------------|-------------------| | replicaCount | desired number of controller pods | 1 | | image.repository | controller container image repository | metabase/metabase | -| image.tag | controller container image tag | v0.24.2 | +| image.tag | controller container image tag | v0.26.2 | | image.pullPolicy | controller container image pull policy | IfNotPresent | | listen.host | Listening on a specific network host | 0.0.0.0 | | listen.port | Listening on a specific network port | 3000 | @@ -66,6 +66,7 @@ The following tables lists the configurable parameters of the Metabase chart and | timeZone | Service time zone | UTC | | emojiLogging | Get a funny emoji in service log | true | | javaToolOptions | JVM options | null | +| pluginsDirectory | A directory with Metabase plugins | null | | service.type | ClusterIP, NodePort, or LoadBalancer | ClusterIP | | service.externalPort | Service external port | 80 | | service.internalPort | Service internal port, should be the same as `listen.port` | 3000 | diff --git a/stable/metabase/templates/deployment.yaml b/stable/metabase/templates/deployment.yaml index afb1c6f3ca..170f69f6ea 100644 --- a/stable/metabase/templates/deployment.yaml +++ b/stable/metabase/templates/deployment.yaml @@ -72,6 +72,10 @@ spec: - name: JAVA_TOOL_OPTIONS value: {{ .Values.javaToolOptions | quote }} {{- end }} + {{- if .Values.pluginsDirectory }} + - name: MB_PLUGINS_DIR + value: {{ .Values.pluginsDirectory | quote }} + {{- end }} - name: MB_EMOJI_IN_LOGS value: {{ .Values.emojiLogging | quote }} ports: diff --git a/stable/metabase/values.yaml b/stable/metabase/values.yaml index 3d1242e18a..387e5fc13d 100644 --- a/stable/metabase/values.yaml +++ b/stable/metabase/values.yaml @@ -5,7 +5,7 @@ replicaCount: 1 image: repository: metabase/metabase - tag: v0.24.2 + tag: v0.26.2 pullPolicy: IfNotPresent # Config Jetty web server @@ -43,6 +43,7 @@ password: timeZone: UTC emojiLogging: true # javaToolOptions: +# pluginsDirectory: service: name: metabase @@ -63,13 +64,13 @@ ingress: # hosts: # - metabase.domain.com resources: {} - # We usually recommend not to specify default resources and to leave this as a conscious - # choice for the user. This also increases chances charts run on environments with little - # resources, such as Minikube. If you do want to specify resources, uncomment the following + # We usually recommend not to specify default resources and to leave this as a conscious + # choice for the user. This also increases chances charts run on environments with little + # resources, such as Minikube. If you do want to specify resources, uncomment the following # lines, adjust them as necessary, and remove the curly braces after 'resources:'. # limits: # cpu: 100m # memory: 128Mi - #requests: + # requests: # cpu: 100m # memory: 128Mi