From a347b408df89744948e888b9f57904e73b33face Mon Sep 17 00:00:00 2001 From: Venkata Surya Lolla Date: Fri, 11 Oct 2019 04:53:38 -0400 Subject: [PATCH] [stable/external-dns] adding --aws-prefer-cname to create CNAME records for Kubernetes service or ingress (#17854) * [stable/external-dns] Adding --aws-prefer-cname argument for the external-dns to replace Alias records with CNAME's. Signed-off-by: Venkata Lolla * [stable/external-dns] Adding --aws-prefer-cname argument for the external-dns to replace Alias records with CNAME's. Signed-off-by: Venkata Lolla * [stable/external-dns] Chart version bump and propogated the preferCNAME value in the values-production.yaml file Signed-off-by: Venkata Lolla --- stable/external-dns/Chart.yaml | 2 +- stable/external-dns/README.md | 1 + stable/external-dns/templates/deployment.yaml | 3 +++ stable/external-dns/values-production.yaml | 3 +++ stable/external-dns/values.yaml | 4 +++- 5 files changed, 11 insertions(+), 2 deletions(-) diff --git a/stable/external-dns/Chart.yaml b/stable/external-dns/Chart.yaml index 22cb080da0..4431ded6ec 100644 --- a/stable/external-dns/Chart.yaml +++ b/stable/external-dns/Chart.yaml @@ -1,6 +1,6 @@ apiVersion: v1 name: external-dns -version: 2.8.0 +version: 2.9.0 appVersion: 0.5.17 description: ExternalDNS is a Kubernetes addon that configures public DNS servers with information about exposed Kubernetes services to make them discoverable. keywords: diff --git a/stable/external-dns/README.md b/stable/external-dns/README.md index b1e8eba64a..1f1a289dfd 100644 --- a/stable/external-dns/README.md +++ b/stable/external-dns/README.md @@ -67,6 +67,7 @@ The following table lists the configurable parameters of the external-dns chart | `aws.assumeRoleArn` | When using the AWS provider, assume role by specifying --aws-assume-role to the external-dns daemon | `""` | | `aws.batchChangeSize` | When using the AWS provider, set the maximum number of changes that will be applied in each batch | `1000` | | `aws.zoneTags` | When using the AWS provider, filter for zones with these tags | `[]` | +| `aws.preferCNAME` | When using the AWS provider, replaces Alias recors with CNAME (options: true, false) | `[]` | | `azure.secretName` | When using the Azure provider, set the secret containing the `azure.json` file | `""` | | `azure.resourceGroup` | When using the Azure provider, set the Azure Resource Group | `""` | | `azure.tenantId` | When using the Azure provider, set the Azure Tenant ID | `""` | diff --git a/stable/external-dns/templates/deployment.yaml b/stable/external-dns/templates/deployment.yaml index d13163df28..5d2c8fb3cf 100755 --- a/stable/external-dns/templates/deployment.yaml +++ b/stable/external-dns/templates/deployment.yaml @@ -105,6 +105,9 @@ spec: {{- range .Values.aws.zoneTags }} - --aws-zone-tags={{ . }} {{- end }} + {{- if .Values.aws.preferCNAME }} + - --aws-prefer-cname + {{- end }} # Azure Arguments {{- if eq .Values.provider "azure" }} {{- if .Values.azure.resourceGroup }} diff --git a/stable/external-dns/values-production.yaml b/stable/external-dns/values-production.yaml index ad7b219e2a..96c1dfe5c7 100644 --- a/stable/external-dns/values-production.yaml +++ b/stable/external-dns/values-production.yaml @@ -74,6 +74,9 @@ aws: ## Zone Tag Filter ## zoneTags: [] + ## Enable AWS Prefer CNAME. Available values are: true, false + ## + preferCNAME: "" ## Azure configuration to be set via arguments/env. variables ## diff --git a/stable/external-dns/values.yaml b/stable/external-dns/values.yaml index 7e6f4b48b2..cc5a92d4b1 100644 --- a/stable/external-dns/values.yaml +++ b/stable/external-dns/values.yaml @@ -74,7 +74,9 @@ aws: ## AWS Zone tags ## zoneTags: [] - + ## Enable AWS Prefer CNAME. Available values are: true, false + ## + preferCNAME: "" ## Azure configuration to be set via arguments/env. variables ## azure: