diff --git a/stable/datadog/Chart.yaml b/stable/datadog/Chart.yaml index e2b7cb0d37..db51e33559 100755 --- a/stable/datadog/Chart.yaml +++ b/stable/datadog/Chart.yaml @@ -1,6 +1,6 @@ apiVersion: v1 name: datadog -version: 1.32.1 +version: 1.32.2 appVersion: 6.12.1 description: DataDog Agent keywords: diff --git a/stable/datadog/README.md b/stable/datadog/README.md index 0761ecf237..e1e4687823 100644 --- a/stable/datadog/README.md +++ b/stable/datadog/README.md @@ -298,6 +298,7 @@ helm install --name \ | `kube-state-metrics.serviceAccount.name` | If not set & create is true, use template fullname | | | `clusterAgent.enabled` | Use the cluster-agent for cluster metrics (Kubernetes 1.10+ only) | `false` | | `clusterAgent.token` | A cluster-internal secret for agent-to-agent communication. Must be 32+ characters a-zA-Z | Generates a random value | +| `clusterAgent.tokenExistingSecret` | If set, use the secret with a provided name instead of creating a new one | `nil` | | `clusterAgent.containerName` | The container name for the Cluster Agent | `cluster-agent` | | `clusterAgent.image.repository` | The image repository for the cluster-agent | `datadog/cluster-agent` | | `clusterAgent.image.tag` | The image tag to pull | `1.2.0` | diff --git a/stable/datadog/templates/NOTES.txt b/stable/datadog/templates/NOTES.txt index ef6d1e6f3b..2cc9ecb28e 100644 --- a/stable/datadog/templates/NOTES.txt +++ b/stable/datadog/templates/NOTES.txt @@ -44,13 +44,13 @@ Create an application key at https://app.datadoghq.com/account/settings#api {{- end }} {{- end }} - {{- if not .Values.clusterAgent.token }} + {{- if and (not .Values.clusterAgent.token) (not .Values.clusterAgent.tokenExistingSecret) }} ############################################################################## #### INFO: You did not set a clusterAgent.token #### ############################################################################## -Because you enabled the Cluster Agent but did not provide a token, a random token was generated. +Because you enabled the Cluster Agent but did not either provide a token or a reference to an existing token via '{{ .Values.clusterAgent.tokenExistingSecret }}', a random token was generated. This token is used to secure the communication between the Agents and the Cluster Agent. Make sure to recreate all pods on upgrade (with the --recreate-pods flag) to ensure all diff --git a/stable/datadog/templates/_helpers.tpl b/stable/datadog/templates/_helpers.tpl index d7ef2c5d48..7532307ff8 100644 --- a/stable/datadog/templates/_helpers.tpl +++ b/stable/datadog/templates/_helpers.tpl @@ -48,6 +48,17 @@ Return secret name to be used based on provided values. {{- default $fullName .Values.datadog.appKeyExistingSecret | quote -}} {{- end -}} +{{/* +Return secret name to be used based on provided values. +*/}} +{{- define "clusterAgent.tokenSecretName" -}} +{{- if not .Values.clusterAgent.tokenExistingSecret -}} +{{- include "datadog.fullname" . -}}-cluster-agent +{{- else -}} +{{- .Values.clusterAgent.tokenExistingSecret -}} +{{- end -}} +{{- end -}} + {{/* Return the appropriate apiVersion for RBAC APIs. */}} diff --git a/stable/datadog/templates/agent-clusterchecks-deployment.yaml b/stable/datadog/templates/agent-clusterchecks-deployment.yaml index 78adf29b94..35c536c3a3 100644 --- a/stable/datadog/templates/agent-clusterchecks-deployment.yaml +++ b/stable/datadog/templates/agent-clusterchecks-deployment.yaml @@ -40,7 +40,7 @@ spec: - name: DD_CLUSTER_AGENT_AUTH_TOKEN valueFrom: secretKeyRef: - name: {{ template "datadog.fullname" . }}-cluster-agent + name: {{ template "clusterAgent.tokenSecretName" . }} key: token - name: DD_CLUSTER_AGENT_ENABLED value: {{ .Values.clusterAgent.enabled | quote }} diff --git a/stable/datadog/templates/agent-secret.yaml b/stable/datadog/templates/agent-secret.yaml index 7ee758c2d1..72cae6ae89 100644 --- a/stable/datadog/templates/agent-secret.yaml +++ b/stable/datadog/templates/agent-secret.yaml @@ -1,3 +1,4 @@ +{{- if not .Values.clusterAgent.tokenExistingSecret }} {{- if .Values.clusterAgent.enabled -}} apiVersion: v1 @@ -17,3 +18,5 @@ data: token: {{ randAlphaNum 32 | b64enc | quote }} {{ end }} {{- end }} + +{{ end }} \ No newline at end of file diff --git a/stable/datadog/templates/cluster-agent-deployment.yaml b/stable/datadog/templates/cluster-agent-deployment.yaml index 173a20618f..50a6583062 100644 --- a/stable/datadog/templates/cluster-agent-deployment.yaml +++ b/stable/datadog/templates/cluster-agent-deployment.yaml @@ -116,7 +116,7 @@ spec: - name: DD_CLUSTER_AGENT_AUTH_TOKEN valueFrom: secretKeyRef: - name: {{ template "datadog.fullname" . }}-cluster-agent + name: {{ template "clusterAgent.tokenSecretName" . }} key: token - name: DD_KUBE_RESOURCES_NAMESPACE value: {{ .Release.Namespace }} diff --git a/stable/datadog/templates/container-agent.yaml b/stable/datadog/templates/container-agent.yaml index be22cf70dd..91d1867ddd 100644 --- a/stable/datadog/templates/container-agent.yaml +++ b/stable/datadog/templates/container-agent.yaml @@ -67,7 +67,7 @@ - name: DD_CLUSTER_AGENT_AUTH_TOKEN valueFrom: secretKeyRef: - name: {{ template "datadog.fullname" . }}-cluster-agent + name: {{ template "clusterAgent.tokenSecretName" . }} key: token {{- end }} {{- if .Values.datadog.podLabelsAsTags }} diff --git a/stable/datadog/templates/container-agents.yaml b/stable/datadog/templates/container-agents.yaml index a45089ab4e..199b295611 100644 --- a/stable/datadog/templates/container-agents.yaml +++ b/stable/datadog/templates/container-agents.yaml @@ -94,7 +94,7 @@ - name: DD_CLUSTER_AGENT_AUTH_TOKEN valueFrom: secretKeyRef: - name: {{ template "datadog.fullname" . }}-cluster-agent + name: {{ template "clusterAgent.tokenSecretName" . }} key: token {{- end }} - name: KUBERNETES