From 7d00dc0cb5c196e2a76cb4e61babf6f30d94a977 Mon Sep 17 00:00:00 2001 From: Prateek Agarwal Date: Mon, 6 Nov 2017 17:25:40 +0530 Subject: [PATCH] [stable/prometheus] Add RollingUpdate for Prometheus node-exporter ds (#1861) * [stable/prometheus] Add RollingUpdate for Prometheus node-exporter daemonset By default updateStrategy is `OnDelete` which needs manual deletion of all daemonsets for change to take affect * Add review suggestions * Keep default updateStrategy --- stable/prometheus/Chart.yaml | 2 +- stable/prometheus/templates/node-exporter-daemonset.yaml | 4 ++++ stable/prometheus/values.yaml | 5 +++++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/stable/prometheus/Chart.yaml b/stable/prometheus/Chart.yaml index 618ec3eb0c..974658494c 100755 --- a/stable/prometheus/Chart.yaml +++ b/stable/prometheus/Chart.yaml @@ -1,5 +1,5 @@ name: prometheus -version: 4.6.10 +version: 4.6.11 description: Prometheus is a monitoring system and time series database. home: https://prometheus.io/ icon: https://raw.githubusercontent.com/prometheus/prometheus.github.io/master/assets/prometheus_logo-cb55bb5c346.png diff --git a/stable/prometheus/templates/node-exporter-daemonset.yaml b/stable/prometheus/templates/node-exporter-daemonset.yaml index 50c1142fd6..db04c0749f 100644 --- a/stable/prometheus/templates/node-exporter-daemonset.yaml +++ b/stable/prometheus/templates/node-exporter-daemonset.yaml @@ -10,6 +10,10 @@ metadata: release: {{ .Release.Name }} name: {{ template "prometheus.nodeExporter.fullname" . }} spec: + {{- if .Values.nodeExporter.updateStrategy }} + updateStrategy: +{{ toYaml .Values.nodeExporter.updateStrategy | indent 4 }} + {{- end }} template: metadata: {{- if .Values.nodeExporter.podAnnotations }} diff --git a/stable/prometheus/values.yaml b/stable/prometheus/values.yaml index fc46bfe6de..15dc873e0a 100644 --- a/stable/prometheus/values.yaml +++ b/stable/prometheus/values.yaml @@ -248,6 +248,11 @@ nodeExporter: tag: v0.15.0 pullPolicy: IfNotPresent + ## Custom Update Strategy + ## + updateStrategy: + type: OnDelete + ## Additional node-exporter container arguments ## extraArgs: {}