From 7ac7fcdafa2cb17b9c695b7a53cd01cd1c7110e0 Mon Sep 17 00:00:00 2001 From: Tom Reznik Date: Fri, 13 Apr 2018 07:54:58 +0300 Subject: [PATCH] [stable/nginx-ingress] support imagePullSecrets (#4874) --- stable/nginx-ingress/Chart.yaml | 2 +- stable/nginx-ingress/README.md | 1 + stable/nginx-ingress/templates/controller-daemonset.yaml | 4 ++++ stable/nginx-ingress/templates/controller-deployment.yaml | 4 ++++ .../nginx-ingress/templates/default-backend-deployment.yaml | 4 ++++ stable/nginx-ingress/values.yaml | 5 +++++ 6 files changed, 19 insertions(+), 1 deletion(-) diff --git a/stable/nginx-ingress/Chart.yaml b/stable/nginx-ingress/Chart.yaml index b46c2e0fa0..6063d565db 100755 --- a/stable/nginx-ingress/Chart.yaml +++ b/stable/nginx-ingress/Chart.yaml @@ -1,5 +1,5 @@ name: nginx-ingress -version: 0.13.1 +version: 0.13.2 appVersion: 0.12.0 home: https://github.com/kubernetes/ingress-nginx description: An nginx Ingress controller that uses ConfigMap to store the nginx configuration. diff --git a/stable/nginx-ingress/README.md b/stable/nginx-ingress/README.md index 98f8081787..e43cc59b27 100644 --- a/stable/nginx-ingress/README.md +++ b/stable/nginx-ingress/README.md @@ -135,6 +135,7 @@ Parameter | Description | Default `defaultBackend.service.loadBalancerIP` | IP address to assign to load balancer (if supported) | `""` `defaultBackend.service.loadBalancerSourceRanges` | list of IP CIDRs allowed access to load balancer (if supported) | `[]` `defaultBackend.service.type` | type of default backend service to create | `ClusterIP` +`imagePullSecrets` | name of Secret resource containing private registry credentials | `nil` `rbac.create` | If true, create & use RBAC resources | `false` `rbac.serviceAccountName` | ServiceAccount to be used (ignored if rbac.create=true) | `default` `revisionHistoryLimit` | The number of old history to retain to allow rollback. | `10` diff --git a/stable/nginx-ingress/templates/controller-daemonset.yaml b/stable/nginx-ingress/templates/controller-daemonset.yaml index a314712a4f..981526e550 100644 --- a/stable/nginx-ingress/templates/controller-daemonset.yaml +++ b/stable/nginx-ingress/templates/controller-daemonset.yaml @@ -30,6 +30,10 @@ spec: {{- end }} spec: dnsPolicy: {{ .Values.controller.dnsPolicy }} + {{- if .Values.imagePullSecrets }} + imagePullSecrets: +{{ toYaml .Values.imagePullSecrets | indent 8 }} + {{- end }} containers: - name: {{ template "nginx-ingress.name" . }}-{{ .Values.controller.name }} image: "{{ .Values.controller.image.repository }}:{{ .Values.controller.image.tag }}" diff --git a/stable/nginx-ingress/templates/controller-deployment.yaml b/stable/nginx-ingress/templates/controller-deployment.yaml index cf3f2998f5..b630693458 100644 --- a/stable/nginx-ingress/templates/controller-deployment.yaml +++ b/stable/nginx-ingress/templates/controller-deployment.yaml @@ -31,6 +31,10 @@ spec: {{- end }} spec: dnsPolicy: {{ .Values.controller.dnsPolicy }} + {{- if .Values.imagePullSecrets }} + imagePullSecrets: +{{ toYaml .Values.imagePullSecrets | indent 8 }} + {{- end }} containers: - name: {{ template "nginx-ingress.name" . }}-{{ .Values.controller.name }} image: "{{ .Values.controller.image.repository }}:{{ .Values.controller.image.tag }}" diff --git a/stable/nginx-ingress/templates/default-backend-deployment.yaml b/stable/nginx-ingress/templates/default-backend-deployment.yaml index fa7a54a139..773c6325f6 100644 --- a/stable/nginx-ingress/templates/default-backend-deployment.yaml +++ b/stable/nginx-ingress/templates/default-backend-deployment.yaml @@ -26,6 +26,10 @@ spec: {{ toYaml .Values.defaultBackend.podLabels | indent 8 }} {{- end }} spec: + {{- if .Values.imagePullSecrets }} + imagePullSecrets: +{{ toYaml .Values.imagePullSecrets | indent 8 }} + {{- end }} containers: - name: {{ template "nginx-ingress.name" . }}-{{ .Values.defaultBackend.name }} image: "{{ .Values.defaultBackend.image.repository }}:{{ .Values.defaultBackend.image.tag }}" diff --git a/stable/nginx-ingress/values.yaml b/stable/nginx-ingress/values.yaml index b739f7ab7e..96b0338e3c 100644 --- a/stable/nginx-ingress/values.yaml +++ b/stable/nginx-ingress/values.yaml @@ -328,6 +328,11 @@ rbac: create: false serviceAccountName: default +## Optional array of imagePullSecrets containing private registry credentials +## Ref: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/ +imagePullSecrets: [] +# - name: secretName + # TCP service key:value pairs # Ref: https://github.com/kubernetes/contrib/tree/master/ingress/controllers/nginx/examples/tcp ##