From 75cc0afd11d6e101016ab8619e5535fdaf8d6772 Mon Sep 17 00:00:00 2001 From: Adnan Abdulhussein Date: Sun, 12 Feb 2017 20:23:40 -0800 Subject: [PATCH] Describe skipped deployment exception (#558) Some charts (e.g. minecraft, ghost) skip creating their deployment resource if a required value is not provided. In these cases, instructions on providing the value are provided in the release's notes that describe how to proceed with the installation. --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c03ee47148..cee42a0dc0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -34,7 +34,7 @@ This repository is used by Chart developers for maintaining the official charts * All Chart dependencies should also be submitted independently * Must pass the linter (`helm lint`) * Must successfully launch with default values (`helm install .`) - * All pods go to the running state + * All pods go to the running state (or NOTES.txt provides further instructions if a required value is missing e.g. [minecraft](https://github.com/kubernetes/charts/blob/master/stable/minecraft/templates/NOTES.txt#L3)) * All services have at least one endpoint * Must include source GitHub repositories for images used in the Chart * Images should not have any major security vulnerabilities