From 72568bf06eab898786dbc65d5e12fa438da49c1e Mon Sep 17 00:00:00 2001 From: Kent Rancourt Date: Tue, 23 May 2017 00:37:24 -0400 Subject: [PATCH] Fix Traefik chart versioning scheme (#1082) --- stable/traefik/Chart.yaml | 8 ++++---- stable/traefik/README.md | 19 +++++++++++++++++++ 2 files changed, 23 insertions(+), 4 deletions(-) diff --git a/stable/traefik/Chart.yaml b/stable/traefik/Chart.yaml index 44814bde78..f2533fba13 100755 --- a/stable/traefik/Chart.yaml +++ b/stable/traefik/Chart.yaml @@ -1,7 +1,7 @@ apiVersion: v1 name: traefik -# Lock step with the Traefik version, appended with -a, -b, etc. to denote versions of the chart -version: 1.2.1-b +version: 1.3.0 +appVersion: 1.2.1 description: A Traefik based Kubernetes ingress controller with Let's Encrypt support keywords: - traefik @@ -13,7 +13,7 @@ sources: - https://github.com/containous/traefik - https://github.com/krancour/charts/tree/master/traefik maintainers: -- name: Deis - email: engineering@deis.com +- name: Kent Rancourt + email: kent.rancourt@microsoft.com engine: gotpl icon: http://traefik.io/traefik.logo.png diff --git a/stable/traefik/README.md b/stable/traefik/README.md index 97ae688b6b..eb82320337 100644 --- a/stable/traefik/README.md +++ b/stable/traefik/README.md @@ -23,6 +23,25 @@ external load balancer (e.g. AWS or GKE) - You control DNS for the domain(s) you intend to route through Traefik - __Suggested:__ PV provisioner support in the underlying infrastructure +## A Quick Note on Versioning + +Up until version 1.2.1-b of this chart, the semantic version of the chart was +kept in-sync with the semantic version of the (default) version of Traefik +installed by the chart. A dash and a letter were appended to Traefik's +semantic version to indicate incrementally improved versions of the chart +itself. For example, chart version 1.2.1-a and 1.2.1-b _both_ provide Traefik +1.2.1, but 1.2.1-b is a chart that is incrementally improved in some way from +its immediate predecessor-- 1.2.1-a. + +This convention, in practice, suffered from a few problems, not the least of +which was that it defied what was permitted by +[semver 2.0.0](http://semver.org/spec/v2.0.0.html). This, in turn, lead to some +difficulty in Helm understanding the versions of this chart. + +Beginning with version 1.3.0 of this chart, the version references _only_ +the revision of the chart itself. The `appVersion` field in `chart.yaml` now +conveys information regarding the revision of Traefik that the chart provides. + ## Installing the Chart To install the chart with the release name `my-release`: