From 651f4c576c653e8633fe0c69e10e734efafc406e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?N=C3=A9stor=20Salceda?= Date: Fri, 10 Jan 2020 18:36:35 +0100 Subject: [PATCH] [stable/sysdig] Remove auditLog.clusterIP value (#20041) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We don't need to use clusterIP in advance: * If using webhook, we can deploy the agent and then configure webhook to post audit logs to the clusterIP. * If using AuditSink, we can rely on KubeDNS for reaching the service. Signed-off-by: Néstor Salceda --- stable/sysdig/CHANGELOG.md | 7 +++++++ stable/sysdig/Chart.yaml | 2 +- stable/sysdig/README.md | 1 - stable/sysdig/templates/auditsink.yaml | 6 +++++- stable/sysdig/templates/service.yaml | 1 - stable/sysdig/values.yaml | 2 -- 6 files changed, 13 insertions(+), 6 deletions(-) diff --git a/stable/sysdig/CHANGELOG.md b/stable/sysdig/CHANGELOG.md index ef9708597a..c2d4545f82 100644 --- a/stable/sysdig/CHANGELOG.md +++ b/stable/sysdig/CHANGELOG.md @@ -3,6 +3,13 @@ This file documents all notable changes to Sysdig Helm Chart. The release numbering uses [semantic versioning](http://semver.org). +## v1.7.1 + +### Major changes + +* Remove the auditLog.clusterIP dependency. Using dynamic backend allows to + rely on DNS queries. + ## v1.7.0 ### Major changes diff --git a/stable/sysdig/Chart.yaml b/stable/sysdig/Chart.yaml index 6c31c308b4..95cb2efe25 100755 --- a/stable/sysdig/Chart.yaml +++ b/stable/sysdig/Chart.yaml @@ -1,6 +1,6 @@ apiVersion: v1 name: sysdig -version: 1.7.0 +version: 1.7.1 appVersion: 0.94.0 description: Sysdig Monitor and Secure agent keywords: diff --git a/stable/sysdig/README.md b/stable/sysdig/README.md index b1e4b3bd5f..473c6f8db5 100644 --- a/stable/sysdig/README.md +++ b/stable/sysdig/README.md @@ -64,7 +64,6 @@ The following table lists the configurable parameters of the Sysdig chart and th | `sysdig.settings` | Settings for agent's configuration file | ` ` | | `secure.enabled` | Enable Sysdig Secure | `true` | | `auditLog.enabled` | Enable K8s audit log support for Sysdig Secure | `false` | -| `auditLog.clusterIP` | ClusterIP address where Sysdig will listen to K8s audit log events | ` ` | | `auditLog.auditServerUrl` | The URL where Sysdig Agent listens for K8s audit log events | `0.0.0.0` | | `auditLog.auditServerPort` | Port where Sysdig Agent listens for K8s audit log events | `7765` | | `auditLog.dynamicBackend.enabled` | Deploy the Audit Sink where Sysdig listens for K8s audit log events | `false` | diff --git a/stable/sysdig/templates/auditsink.yaml b/stable/sysdig/templates/auditsink.yaml index 36f1014f24..e58fee185c 100644 --- a/stable/sysdig/templates/auditsink.yaml +++ b/stable/sysdig/templates/auditsink.yaml @@ -19,5 +19,9 @@ spec: qps: 10 burst: 15 clientConfig: - url: http://{{ required "A valid .Values.auditLog.clusterIP entry required" .Values.auditLog.clusterIP }}:{{ .Values.auditLog.auditServerPort }}/k8s_audit + service: + namespace: {{ .Release.Namespace }} + name: {{ template "sysdig.fullname" . }} + port: {{ .Values.auditLog.auditServerPort }} + path: /k8s_audit {{- end }} diff --git a/stable/sysdig/templates/service.yaml b/stable/sysdig/templates/service.yaml index d15db65e47..6c009c1f19 100644 --- a/stable/sysdig/templates/service.yaml +++ b/stable/sysdig/templates/service.yaml @@ -11,7 +11,6 @@ metadata: spec: selector: app: {{ template "sysdig.fullname" .}} - clusterIP: {{ required "A valid .Values.auditLog.clusterIP entry required" .Values.auditLog.clusterIP }} ports: - protocol: TCP port: {{ .Values.auditLog.auditServerPort }} diff --git a/stable/sysdig/values.yaml b/stable/sysdig/values.yaml index b181ef6f0d..b656920298 100644 --- a/stable/sysdig/values.yaml +++ b/stable/sysdig/values.yaml @@ -114,8 +114,6 @@ secure: auditLog: # true here activates the K8s Audit Log feature for Sysdig Secure enabled: false - # Required: You need to specify a clusterIP for the service which listens to K8s audit events - clusterIP: auditServerUrl: 0.0.0.0 auditServerPort: 7765