From 5bcd4594aac7ffee519646db3d03569939049da4 Mon Sep 17 00:00:00 2001 From: Michael Klishin Date: Thu, 19 Apr 2018 05:53:59 +0900 Subject: [PATCH] [rabbitmq] Use a safe cluster_formation.node_cleanup.only_log_warning value (#4823) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * [rabbitmq] Use a safe cluster_formation.node_cleanup.only_log_warning value This chart ended up adopting an unfortunate value used in the example that ships with the K8S peer discovery plugin [1]. The goal was never to recommend it to all users, as the docs are pretty clear on that automatic node cleanup can have dangerous side effects when nodes go offline temporarily, e.g. as in [3]. Kudos to Petr Šebek for pointing this out on rabbitmq-users [4]. 1. https://github.com/rabbitmq/rabbitmq-peer-discovery-k8s/blob/b309d641ce7ccf135d02fb39254e8c67c98d3a63/examples/k8s_statefulsets/rabbitmq_statefulsets.yaml#L40 2. http://www.rabbitmq.com/cluster-formation.html#node-health-checks-and-cleanup 3. https://groups.google.com/d/msg/rabbitmq-users/wuOfzEywHXo/vm3n1VsfBgAJ 4. https://groups.google.com/forum/#!msg/rabbitmq-users/wuOfzEywHXo/k8z_HWIkBgAJ * Correct a comment typo * [rabbitmq] Bump version to 1.3.2 Apparently this is an accepted practice for this repo and not doing so will make CI fail. --- stable/rabbitmq-ha/Chart.yaml | 2 +- stable/rabbitmq-ha/templates/configmap.yaml | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/stable/rabbitmq-ha/Chart.yaml b/stable/rabbitmq-ha/Chart.yaml index b77069ac74..0457b7f83d 100644 --- a/stable/rabbitmq-ha/Chart.yaml +++ b/stable/rabbitmq-ha/Chart.yaml @@ -1,7 +1,7 @@ name: rabbitmq-ha apiVersion: v1 appVersion: 3.7.3 -version: 1.3.1 +version: 1.3.2 description: Highly available RabbitMQ cluster, the open source message broker software that implements the Advanced Message Queuing Protocol (AMQP). keywords: diff --git a/stable/rabbitmq-ha/templates/configmap.yaml b/stable/rabbitmq-ha/templates/configmap.yaml index a83caa68c5..fed18f7943 100644 --- a/stable/rabbitmq-ha/templates/configmap.yaml +++ b/stable/rabbitmq-ha/templates/configmap.yaml @@ -58,7 +58,9 @@ data: cluster_formation.k8s.host = kubernetes.default.svc.cluster.local cluster_formation.k8s.address_type = hostname cluster_formation.node_cleanup.interval = 10 - cluster_formation.node_cleanup.only_log_warning = false + # Set to false if automatic cleanup of absent nodes is desired. + # This can be dangerous, see http://www.rabbitmq.com/cluster-formation.html#node-health-checks-and-cleanup. + cluster_formation.node_cleanup.only_log_warning = true cluster_partition_handling = autoheal ## The default "guest" user is only permitted to access the server