From 53d232a16e22fcb2e074cd74979c7623c12812f0 Mon Sep 17 00:00:00 2001 From: Mohamed Hazem Date: Tue, 11 Jun 2019 20:36:22 +0200 Subject: [PATCH] - Make redisAddress value a list instead of comma serparated string (#14696) Signed-off-by: Mohamed Hazem --- stable/prometheus-redis-exporter/Chart.yaml | 2 +- stable/prometheus-redis-exporter/README.md | 2 +- stable/prometheus-redis-exporter/templates/deployment.yaml | 2 +- stable/prometheus-redis-exporter/values.yaml | 3 ++- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/stable/prometheus-redis-exporter/Chart.yaml b/stable/prometheus-redis-exporter/Chart.yaml index b03ff62a3c..d1c965cc47 100644 --- a/stable/prometheus-redis-exporter/Chart.yaml +++ b/stable/prometheus-redis-exporter/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v1 appVersion: 0.28.0 description: Prometheus exporter for Redis metrics name: prometheus-redis-exporter -version: 1.1.0 +version: 2.0.0 home: https://github.com/oliver006/redis_exporter sources: - https://github.com/oliver006/redis_exporter diff --git a/stable/prometheus-redis-exporter/README.md b/stable/prometheus-redis-exporter/README.md index d89783eba1..849246d4e5 100644 --- a/stable/prometheus-redis-exporter/README.md +++ b/stable/prometheus-redis-exporter/README.md @@ -54,7 +54,7 @@ The following table lists the configurable parameters and their default values. | `service.port` | service external port | `9121` | | `service.annotations` | Custom annotations for service | `{}` | | `service.labels` | Additional custom labels for the service | `{}` | -| `redisAddress` | address of one or more redis nodes, comma separated | `redis://myredis:6379` | +| `redisAddress` | A list of addresses of one or more redis nodes | `redis://myredis:6379` | | `annotations` | pod annotations for easier discovery | {} | | `rbac.create` | Specifies whether RBAC resources should be created.| `true` | | `rbac.pspEnabled` | Specifies whether a PodSecurityPolicy should be created.| `true` | diff --git a/stable/prometheus-redis-exporter/templates/deployment.yaml b/stable/prometheus-redis-exporter/templates/deployment.yaml index fb20e47dc7..ed66b1994f 100644 --- a/stable/prometheus-redis-exporter/templates/deployment.yaml +++ b/stable/prometheus-redis-exporter/templates/deployment.yaml @@ -41,7 +41,7 @@ spec: containerPort: 9121 env: - name: REDIS_ADDR - value: {{ .Values.redisAddress }} + value: {{ join "," .Values.redisAddress }} {{- if .Values.env }} {{ toYaml .Values.env | indent 12 }} {{- end }} diff --git a/stable/prometheus-redis-exporter/values.yaml b/stable/prometheus-redis-exporter/values.yaml index 917078e408..0790d82dda 100644 --- a/stable/prometheus-redis-exporter/values.yaml +++ b/stable/prometheus-redis-exporter/values.yaml @@ -32,7 +32,8 @@ service: # prometheus.io/port: "9121" # prometheus.io/scrape: "true" resources: {} -redisAddress: redis://myredis:6379 +redisAddress: + - redis://myredis:6379 annotations: {} # prometheus.io/path: /metrics # prometheus.io/port: "9121"