From 30ca8eff04d58d932db5a370b68f5576734f68c2 Mon Sep 17 00:00:00 2001
From: David Wang <dcwangmit01@gmail.com>
Date: Sun, 14 Jan 2018 08:09:28 -0800
Subject: [PATCH] [incubator/oauth-proxy] Tweaked oauth-proxy deployment
 template to accept boolean extraArgs (#3266)

* Tweaked oauth-proxy deployment template to accept boolean extraArgs

* Prior to this commit, values.yaml extraArgs only allowed setting of
  `key=value` pairs.  However, some oauth2_proxy flags are boolean
  flags with only `key` and no `value`.  In the example below,
  `ssl-insecure-skip-verify` is one such flag.

  extraArgs:
    provider: "oidc"
    ssl-insecure-skip-verify:
    cookie-secure: "true"

* This commit allows boolean flags to be added to extraArgs as shown
  above by `ssl-insecure-skip-verify`.

* Update Chart.yaml
---
 incubator/oauth-proxy/Chart.yaml                | 2 +-
 incubator/oauth-proxy/templates/deployment.yaml | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/incubator/oauth-proxy/Chart.yaml b/incubator/oauth-proxy/Chart.yaml
index db78f87507..f866507419 100644
--- a/incubator/oauth-proxy/Chart.yaml
+++ b/incubator/oauth-proxy/Chart.yaml
@@ -1,5 +1,5 @@
 name: oauth-proxy
-version: 0.1.3
+version: 0.1.4
 appVersion: 2.2
 description: A reverse proxy that provides authentication with Google, Github or other providers
 keywords:
diff --git a/incubator/oauth-proxy/templates/deployment.yaml b/incubator/oauth-proxy/templates/deployment.yaml
index c5d7cea020..faf5a40ebf 100644
--- a/incubator/oauth-proxy/templates/deployment.yaml
+++ b/incubator/oauth-proxy/templates/deployment.yaml
@@ -28,7 +28,11 @@ spec:
         imagePullPolicy: {{ .Values.image.pullPolicy }}
         args:
         {{- range $key, $value := .Values.extraArgs }}
+          {{- if $value }}
           - --{{ $key }}={{ $value }}
+          {{- else }}
+          - --{{ $key }}
+          {{- end }}
         {{- end }}
         env:
         - name: OAUTH2_PROXY_CLIENT_ID