From 2b3b54b80560ef7bebbe73092b1f12be8cd5ba7e Mon Sep 17 00:00:00 2001 From: Alina Ionescu Date: Mon, 17 Dec 2018 18:31:30 +0200 Subject: [PATCH] Added hostAliases option for selenium chart (#8526) * added posiblity to add hostAliases to selenium nodes Signed-off-by: Alina Ionescu * Updatded Chart version Signed-off-by: AlinaIo Signed-off-by: IonescuA --- stable/selenium/Chart.yaml | 2 +- stable/selenium/README.md | 1 + stable/selenium/templates/chrome-deployment.yaml | 2 ++ stable/selenium/templates/chromeDebug-deployment.yaml | 2 ++ stable/selenium/templates/firefox-deployment.yaml | 2 ++ stable/selenium/templates/firefoxDebug-deployment.yaml | 2 ++ stable/selenium/values.yaml | 2 ++ 7 files changed, 12 insertions(+), 1 deletion(-) diff --git a/stable/selenium/Chart.yaml b/stable/selenium/Chart.yaml index 3296a94fc0..859738dbac 100644 --- a/stable/selenium/Chart.yaml +++ b/stable/selenium/Chart.yaml @@ -1,5 +1,5 @@ name: selenium -version: 0.14.0 +version: 0.15.0 appVersion: 3.14.0 description: Chart for selenium grid keywords: diff --git a/stable/selenium/README.md b/stable/selenium/README.md index dc89e76eab..99815f390d 100644 --- a/stable/selenium/README.md +++ b/stable/selenium/README.md @@ -43,6 +43,7 @@ The following table lists the configurable parameters of the Selenium chart and | Parameter | Description | Default | | --------- | ----------- | ------- | | `global.nodeselector` | Node label to be useed globally for scheduling of all images | `nil` | +| `global.hostAliases` | A list of hostAliases, that contains ip and hostnames, to be used globally | `[]` | | `global.affinity` | Deployemnt affinities to be used globally for scheduling of all images | `nil` | | `global.tolerations` | Deployment tolerations to be used globally for scheduling of all images | `nil` | | `hub.image` | The selenium hub image | `selenium/hub` | diff --git a/stable/selenium/templates/chrome-deployment.yaml b/stable/selenium/templates/chrome-deployment.yaml index 21caf88818..6c44afb51a 100644 --- a/stable/selenium/templates/chrome-deployment.yaml +++ b/stable/selenium/templates/chrome-deployment.yaml @@ -88,6 +88,8 @@ spec: {{ if .Values.chrome.volumes -}} {{ toYaml .Values.chrome.volumes | indent 8 }} {{- end }} + hostAliases: +{{ toYaml .Values.global.hostAliases | indent 8 }} nodeSelector: {{- if .Values.chrome.nodeSelector }} {{ toYaml .Values.chrome.nodeSelector | indent 8 }} diff --git a/stable/selenium/templates/chromeDebug-deployment.yaml b/stable/selenium/templates/chromeDebug-deployment.yaml index bc07cdb994..a01bc89045 100644 --- a/stable/selenium/templates/chromeDebug-deployment.yaml +++ b/stable/selenium/templates/chromeDebug-deployment.yaml @@ -90,6 +90,8 @@ spec: {{ if .Values.chromeDebug.volumes -}} {{ toYaml .Values.chromeDebug.volumes | indent 8 }} {{- end }} + hostAliases: +{{ toYaml .Values.global.hostAliases | indent 8 }} nodeSelector: {{- if .Values.chromeDebug.nodeSelector }} {{ toYaml .Values.chromeDebug.nodeSelector | indent 8 }} diff --git a/stable/selenium/templates/firefox-deployment.yaml b/stable/selenium/templates/firefox-deployment.yaml index 6892d89576..9d636e9802 100644 --- a/stable/selenium/templates/firefox-deployment.yaml +++ b/stable/selenium/templates/firefox-deployment.yaml @@ -80,6 +80,8 @@ spec: {{- end }} resources: {{ toYaml .Values.firefox.resources | indent 12 }} + hostAliases: +{{ toYaml .Values.global.hostAliases | indent 8 }} nodeSelector: {{- if .Values.firefox.nodeSelector }} {{ toYaml .Values.firefox.nodeSelector | indent 8 }} diff --git a/stable/selenium/templates/firefoxDebug-deployment.yaml b/stable/selenium/templates/firefoxDebug-deployment.yaml index 7e1c522b48..f6b831b9d9 100644 --- a/stable/selenium/templates/firefoxDebug-deployment.yaml +++ b/stable/selenium/templates/firefoxDebug-deployment.yaml @@ -82,6 +82,8 @@ spec: {{- end }} resources: {{ toYaml .Values.firefoxDebug.resources | indent 12 }} + hostAliases: +{{ toYaml .Values.global.hostAliases | indent 8 }} nodeSelector: {{- if .Values.firefoxDebug.nodeSelector }} {{ toYaml .Values.firefoxDebug.nodeSelector | indent 8 }} diff --git a/stable/selenium/values.yaml b/stable/selenium/values.yaml index af011feede..89d4543143 100644 --- a/stable/selenium/values.yaml +++ b/stable/selenium/values.yaml @@ -4,6 +4,8 @@ global: ## can also be spceifed at chart level see below nodeSelector: # label: value + ## Configure HostAliases + hostAliases: [] affinity: # label: value tolerations: