From c17c0ea9aae9ea701b8b65a5aa8a2d5a2d1e10db Mon Sep 17 00:00:00 2001 From: Bret Fisher Date: Fri, 18 May 2018 07:20:13 -0500 Subject: [PATCH] Remove obsolete MAINTAINER command --- slides/intro/Advanced_Dockerfiles.md | 15 +-------------- slides/intro/Dockerfile_Tips.md | 8 +++----- 2 files changed, 4 insertions(+), 19 deletions(-) diff --git a/slides/intro/Advanced_Dockerfiles.md b/slides/intro/Advanced_Dockerfiles.md index 85d917a8..428370a3 100644 --- a/slides/intro/Advanced_Dockerfiles.md +++ b/slides/intro/Advanced_Dockerfiles.md @@ -34,18 +34,6 @@ In this section, we will see more Dockerfile commands. --- -## The `MAINTAINER` instruction - -The `MAINTAINER` instruction tells you who wrote the `Dockerfile`. - -```dockerfile -MAINTAINER Docker Education Team -``` - -It's optional but recommended. - ---- - ## The `RUN` instruction The `RUN` instruction can be specified in two ways. @@ -428,5 +416,4 @@ ONBUILD COPY . /src ``` * You can't chain `ONBUILD` instructions with `ONBUILD`. -* `ONBUILD` can't be used to trigger `FROM` and `MAINTAINER` - instructions. +* `ONBUILD` can't be used to trigger `FROM` instructions. diff --git a/slides/intro/Dockerfile_Tips.md b/slides/intro/Dockerfile_Tips.md index 2226cea0..2ea68133 100644 --- a/slides/intro/Dockerfile_Tips.md +++ b/slides/intro/Dockerfile_Tips.md @@ -51,9 +51,8 @@ The dependencies are reinstalled every time, because the build system does not k ```bash FROM python -MAINTAINER Docker Education Team -COPY . /src/ WORKDIR /src +COPY . . RUN pip install -qr requirements.txt EXPOSE 5000 CMD ["python", "app.py"] @@ -67,11 +66,10 @@ Adding the dependencies as a separate step means that Docker can cache more effi ```bash FROM python -MAINTAINER Docker Education Team -COPY ./requirements.txt /tmp/requirements.txt +COPY requirements.txt /tmp/requirements.txt RUN pip install -qr /tmp/requirements.txt -COPY . /src/ WORKDIR /src +COPY . . EXPOSE 5000 CMD ["python", "app.py"] ```