From a53a416ef697991b64592bc557520e2eee1fb42c Mon Sep 17 00:00:00 2001
From: Chi-En Wu <jason.wu@hahow.in>
Date: Mon, 4 May 2020 10:28:05 +0800
Subject: [PATCH] refactor: portable sed -i

---
 scripts/bump-version.sh | 28 +++++++++++++++++++---------
 scripts/create-chart.sh | 12 +++++++++++-
 2 files changed, 30 insertions(+), 10 deletions(-)

diff --git a/scripts/bump-version.sh b/scripts/bump-version.sh
index aaab199..66655b4 100755
--- a/scripts/bump-version.sh
+++ b/scripts/bump-version.sh
@@ -28,26 +28,36 @@ PATCH_VERSION=$(echo $CURRENT_VERSION | cut -d '.' -f 3)
 
 if [[ $UPDATED_PART = 'patch' ]]
 then
-    (( PATCH_VERSION++ ))
+  (( PATCH_VERSION++ ))
 elif [[ $UPDATED_PART = 'minor' ]]
 then
-    (( MINOR_VERSION++ ))
-    PATCH_VERSION=0
+  (( MINOR_VERSION++ ))
+  PATCH_VERSION=0
 elif [[ $UPDATED_PART = 'major' ]]
 then
-    (( MAJOR_VERSION ++ ))
-    MINOR_VERSION=0
-    PATCH_VERSION=0
+  (( MAJOR_VERSION ++ ))
+  MINOR_VERSION=0
+  PATCH_VERSION=0
 fi
 
 NEW_VERSION=$MAJOR_VERSION.$MINOR_VERSION.$PATCH_VERSION
 echo "Bumping Version $CURRENT_VERSION => $NEW_VERSION..."
 
+case $(sed --help 2>&1) in
+  *GNU*)
+    SED=(sed -i)
+    ;;
+
+  *)
+    SED=(sed -i "")
+    ;;
+esac
+
 echo "Updating starter/Chart.yaml..."
-sed -i "" "s/^  version: \"$CURRENT_VERSION\"$/  version: \"$NEW_VERSION\"/" $ROOT_PATH/starter/Chart.yaml
+"${SED[@]}" "s/^  version: \"$CURRENT_VERSION\"$/  version: \"$NEW_VERSION\"/" $ROOT_PATH/starter/Chart.yaml
 
 echo "Updating README.md..."
-sed -i "" "/^### Adding Dependency$/,/^### Using Starter$/s;version: $CURRENT_VERSION;version: $NEW_VERSION;" $ROOT_PATH/README.md
+"${SED[@]}" "/^### Adding Dependency$/,/^### Using Starter$/s;version: $CURRENT_VERSION;version: $NEW_VERSION;" $ROOT_PATH/README.md
 
 echo "Updating Chart.yaml..."
-sed -i "" "s/^version: $CURRENT_VERSION$/version: $NEW_VERSION/" $ROOT_PATH/Chart.yaml
+"${SED[@]}" "s/^version: $CURRENT_VERSION$/version: $NEW_VERSION/" $ROOT_PATH/Chart.yaml
diff --git a/scripts/create-chart.sh b/scripts/create-chart.sh
index a3c9209..71d4f15 100755
--- a/scripts/create-chart.sh
+++ b/scripts/create-chart.sh
@@ -10,11 +10,21 @@ fi
 
 CHART_NAME=$1
 
+case $(sed --help 2>&1) in
+  *GNU*)
+    SED=(sed -i)
+    ;;
+
+  *)
+    SED=(sed -i "")
+    ;;
+esac
+
 echo "Creating chart..."
 mkdir "$CHART_NAME"
 curl --proto '=https' --tlsv1.2 -sSf https://codeload.github.com/hahow/common-chart/tar.gz/master | \
   tar -xz -C "$CHART_NAME" --strip=2 common-chart-master/starter
-find "$CHART_NAME" -type f | xargs sed -i "" "s/<CHARTNAME>/$CHART_NAME/g"
+find "$CHART_NAME" -type f | xargs "${SED[@]}" "s/<CHARTNAME>/$CHART_NAME/g"
 
 echo "Building dependencies..."
 helm dep build "$CHART_NAME"