Files
capsule/internal/controllers/resources/global.go
T
fed61d2815 feat: replicating resources upon namespace creation (#2080)
* feat: replicating resources upon namespace creation

This feature enhances the (Global)TenantResource replication by
triggering a replication of resources upon a Namespace creation: this
speeds up the replication of resources without waiting for the
resyncPeriod that could be delayed for several reasons.

Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>

* fix: addressing fix from github copilot

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>

---------

Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>
Co-authored-by: Oliver Bähler <26610571+oliverbaehler@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-08-17 10:51:09 +02:00

607 lines
16 KiB
Go

// Copyright 2020-2026 Project Capsule Authors
// SPDX-License-Identifier: Apache-2.0
package resources
import (
"context"
"fmt"
"reflect"
"strconv"
"github.com/go-logr/logr"
gherrors "github.com/pkg/errors"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/labels"
"k8s.io/apimachinery/pkg/types"
"k8s.io/apimachinery/pkg/util/sets"
"k8s.io/client-go/util/retry"
"sigs.k8s.io/cluster-api/util/patch"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/builder"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
"sigs.k8s.io/controller-runtime/pkg/handler"
ctrllog "sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/predicate"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
capsulev1beta2 "github.com/projectcapsule/capsule/api/v1beta2"
"github.com/projectcapsule/capsule/internal/cache"
"github.com/projectcapsule/capsule/internal/controllers/utils"
"github.com/projectcapsule/capsule/internal/metrics"
"github.com/projectcapsule/capsule/pkg/api"
caperrors "github.com/projectcapsule/capsule/pkg/api/errors"
"github.com/projectcapsule/capsule/pkg/api/meta"
"github.com/projectcapsule/capsule/pkg/api/processor"
"github.com/projectcapsule/capsule/pkg/runtime/configuration"
tenantresourceindexer "github.com/projectcapsule/capsule/pkg/runtime/indexers/tenantresource"
"github.com/projectcapsule/capsule/pkg/runtime/predicates"
)
type globalResourceController struct {
client client.Client
reader client.Reader
log logr.Logger
processor processor.Processor
collector Collector
configuration configuration.Configuration
metrics *metrics.GlobalTenantResourceRecorder
clients impersonatedClientLoader[*capsulev1beta2.GlobalTenantResource]
impersonation *cache.ImpersonationCache
}
func (r *globalResourceController) SetupWithManager(mgr ctrl.Manager, ctrlConfig utils.ControllerOptions) error {
r.client = mgr.GetClient()
r.reader = mgr.GetAPIReader()
r.processor = processor.Processor{
Configuration: r.configuration,
GatherClient: mgr.GetAPIReader(),
AllowCrossNamespaceSelection: true,
Mapper: mgr.GetRESTMapper(),
}
r.collector = NewCollector(
mgr.GetAPIReader(),
mgr.GetRESTMapper(),
)
r.clients = impersonatedClientLoader[*capsulev1beta2.GlobalTenantResource]{
client: r.client,
configuration: r.configuration,
impersonation: r.impersonation,
resolve: globalServiceAccount,
}
return ctrl.NewControllerManagedBy(mgr).
For(
&capsulev1beta2.GlobalTenantResource{},
builder.WithPredicates(
predicate.Or(
predicate.GenerationChangedPredicate{},
predicates.ReconcileRequestedPredicate{},
),
),
).
Watches(
&capsulev1beta2.CapsuleConfiguration{},
handler.EnqueueRequestsFromMapFunc(r.enqueueAllResources),
builder.WithPredicates(
predicates.CapsuleConfigSpecImpersonationChangedPredicate{},
predicates.NamesMatchingPredicate{Names: []string{ctrlConfig.ConfigurationName}},
),
).
Watches(
&capsulev1beta2.GlobalTenantResource{},
handler.EnqueueRequestsFromMapFunc(r.enqueueDependentGlobalTenantResources),
builder.WithPredicates(predicates.DependencyStateChangedPredicate{}),
).
Watches(
&capsulev1beta2.Tenant{},
handler.EnqueueRequestsFromMapFunc(r.enqueueRequestFromTenant),
builder.WithPredicates(predicates.TenantSelectionChangedPredicate{}),
).
WithOptions(ctrlConfig.Runtime.ToControllerOptions()).
Complete(r)
}
func (r *globalResourceController) Reconcile(ctx context.Context, request reconcile.Request) (res reconcile.Result, err error) {
log := ctrllog.FromContext(ctx)
log.V(5).Info("start processing")
tntResource := &capsulev1beta2.GlobalTenantResource{}
if err = r.client.Get(ctx, request.NamespacedName, tntResource); err != nil {
if apierrors.IsNotFound(err) {
log.V(5).Info("Request object not found, could have been deleted after reconcile request")
r.metrics.DeleteMetrics(request.Name)
return reconcile.Result{}, nil
}
return reconcile.Result{}, err
}
requeue := reconcile.Result{
RequeueAfter: jitteredResync(tntResource.Spec.ResyncPeriod.Duration),
}
patchHelper, err := patch.NewHelper(tntResource, r.client)
if err != nil {
return reconcile.Result{}, gherrors.Wrap(err, "failed to init patch helper")
}
var statusErr error
//nolint:dupl
defer func() {
meta.RemoveReconcileTriggerAnnotation(tntResource)
reconcileErr := err
if statusErr != nil {
reconcileErr = statusErr
}
if uerr := r.updateStatus(ctx, tntResource, reconcileErr); uerr != nil {
if caperrors.IgnoreGone(uerr) {
err = nil
return
}
err = fmt.Errorf("cannot update globaltenantresource status: %w", uerr)
return
}
r.metrics.RecordConditions(tntResource)
if e := patchHelper.Patch(ctx, tntResource); e != nil {
if caperrors.IgnoreGone(e) {
err = nil
return
}
res = reconcile.Result{}
err = gherrors.Wrap(e, "failed to patch GlobalTenantResource")
return
}
// Controller-runtime should not receive handled reconciliation errors.
err = nil
}()
// On Deletion these checks are skipped.
//nolint:nestif
if tntResource.DeletionTimestamp.IsZero() {
if tntResource.Spec.IsCordoned() {
log.V(5).Info("global tenant resource cordoned")
return reconcile.Result{}, nil
}
for _, dep := range tntResource.Spec.DependsOn {
d := &capsulev1beta2.GlobalTenantResource{}
if getErr := r.client.Get(ctx, types.NamespacedName{Name: dep.Name.String()}, d); getErr != nil {
if apierrors.IsNotFound(getErr) {
statusErr = fmt.Errorf("dependency %s not found", dep.Name)
} else {
statusErr = getErr
}
return requeue, nil
}
stat := d.Status.Conditions.GetConditionByType(meta.ReadyCondition)
if stat == nil || stat.Status != metav1.ConditionTrue {
statusErr = fmt.Errorf("dependency %s not ready", dep.Name)
return requeue, nil
}
}
}
// Load client must be first since it updates the new serviceaccount used which can then be directly
// posted to the status.
c, loadErr := r.loadClient(ctx, log, tntResource)
if loadErr != nil {
statusErr = gherrors.Wrap(loadErr, "failed to load serviceaccount client")
return requeue, nil
}
// Best-Effort for Updating the status
if updateErr := r.updateReconcilingStatus(ctx, tntResource); updateErr != nil {
if caperrors.IgnoreGone(updateErr) {
return reconcile.Result{}, nil
}
log.Error(updateErr, "failed to update status")
}
if c == nil {
statusErr = fmt.Errorf("received empty client for serviceaccount")
return requeue, nil
}
statusErr = r.reconcile(ctx, c, tntResource)
if len(tntResource.Status.ProcessedItems) > 0 {
controllerutil.AddFinalizer(tntResource, meta.ControllerFinalizer)
} else {
controllerutil.RemoveFinalizer(tntResource, meta.ControllerFinalizer)
}
controllerutil.RemoveFinalizer(tntResource, meta.LegacyResourceFinalizer)
return requeue, nil
}
func (r *globalResourceController) enqueueDependentGlobalTenantResources(
ctx context.Context,
obj client.Object,
) []ctrl.Request {
changed, ok := obj.(*capsulev1beta2.GlobalTenantResource)
if !ok {
return nil
}
var list capsulev1beta2.GlobalTenantResourceList
if err := r.client.List(ctx, &list, client.MatchingFields{tenantresourceindexer.GlobalDependenciesFieldName: changed.Name}); err != nil {
return nil
}
reqs := make([]ctrl.Request, 0, len(list.Items))
for i := range list.Items {
reqs = append(reqs, ctrl.Request{NamespacedName: client.ObjectKeyFromObject(&list.Items[i])})
}
return reqs
}
func (r *globalResourceController) enqueueRequestFromTenant(ctx context.Context, object client.Object) (reqs []reconcile.Request) {
tnt := object.(*capsulev1beta2.Tenant) //nolint:forcetypeassert
resList := capsulev1beta2.GlobalTenantResourceList{}
if err := r.client.List(ctx, &resList); err != nil {
return nil
}
set := sets.NewString()
for _, res := range resList.Items {
tntSelector := res.Spec.TenantSelector
selector, err := metav1.LabelSelectorAsSelector(&tntSelector)
if err != nil {
continue
}
if selector.Matches(labels.Set(tnt.GetLabels())) {
set.Insert(res.GetName())
}
}
// No need of ordered value here
for res := range set {
reqs = append(reqs, reconcile.Request{
NamespacedName: types.NamespacedName{
Name: res,
},
})
}
return reqs
}
//nolint:dupl
func (r *globalResourceController) enqueueAllResources(ctx context.Context, _ client.Object) []reconcile.Request {
var list capsulev1beta2.GlobalTenantResourceList
if err := r.client.List(ctx, &list); err != nil {
r.log.V(1).Error(err, "unable to list GlobalTenantResourceList for config-triggered reconcile")
return nil
}
reqs := make([]reconcile.Request, 0, len(list.Items))
for i := range list.Items {
reqs = append(reqs, reconcile.Request{
NamespacedName: types.NamespacedName{
Name: list.Items[i].Name,
Namespace: list.Items[i].Namespace,
},
})
}
return reqs
}
func (r *globalResourceController) reconcile(
ctx context.Context,
c client.Client,
tntResource *capsulev1beta2.GlobalTenantResource,
) (err error) {
log := ctrllog.FromContext(ctx)
if tntResource.Status.ProcessedItems == nil {
tntResource.Status.ProcessedItems = make([]meta.ObjectReferenceStatus, 0)
}
// Retrieving the list of the Tenants up to the selector provided by the GlobalTenantResource resource.
tntSelector, err := metav1.LabelSelectorAsSelector(&tntResource.Spec.TenantSelector)
if err != nil {
log.Error(err, "cannot create MatchingLabelsSelector for Global filtering")
return err
}
// Use Controller Client.
tntList := capsulev1beta2.TenantList{}
if err = r.reader.List(ctx, &tntList, &client.MatchingLabelsSelector{Selector: tntSelector}); err != nil {
log.Error(err, "cannot list Tenants matching the provided selector")
return err
}
filtered := make([]capsulev1beta2.Tenant, 0, len(tntList.Items))
for _, tnt := range tntList.Items {
if tnt.DeletionTimestamp != nil {
continue
}
filtered = append(filtered, tnt)
}
// Always post the processed items, as they allow users to track errors
defer func() {
tntResource.AssignTenants(filtered)
}()
acc := processor.Accumulator{}
owner := meta.GetLooseOwnerReference(tntResource)
// Gather Resources
if tntResource.DeletionTimestamp.IsZero() {
err := r.gatherResources(
ctx,
c,
log,
tntResource,
tntList,
acc,
)
if err != nil {
return err
}
}
return r.processor.Reconcile(
ctx,
log,
c,
&tntResource.Status.ProcessedItems,
acc,
processor.ProcessorOptions{
FieldOwnerPrefix: getFieldOwner(tntResource.GetName(), tntResource.GetNamespace()),
Prune: *tntResource.Spec.PruningOnDelete,
Adopt: *tntResource.Spec.Settings.Adopt,
Force: *tntResource.Spec.Settings.Force,
Owner: &owner,
})
}
func (r *globalResourceController) gatherResources(
ctx context.Context,
c client.Client,
log logr.Logger,
tntResource *capsulev1beta2.GlobalTenantResource,
tnts capsulev1beta2.TenantList,
acc processor.Accumulator,
) error {
opts := CollectorOptions{
Accumulator: acc,
AllowCrossNamespaceSelection: true,
AllowClusterScopedObjects: true,
}
// Collect Available Generated Items
for resourceIndex, resource := range tntResource.Spec.Resources {
switch tntResource.Spec.Scope {
case api.ResourceScopeNone:
ilog := log.WithValues("tenant", "Cluster", "resource", resourceIndex)
ilog.V(5).Info("replicating once for cluster scope")
clusterTenant := &capsulev1beta2.Tenant{
ObjectMeta: metav1.ObjectMeta{
Name: "None",
},
}
opts.Iterator = NewCollectorIteratorOptions(clusterTenant, nil, resource)
if err := r.collector.Collect(
ctx,
c,
opts,
clusterTenant,
strconv.Itoa(resourceIndex),
resource,
nil,
); err != nil {
return err
}
case api.ResourceScopeTenant:
for _, tnt := range tnts.Items {
ilog := log.WithValues("tenant", tnt.GetName(), "resource", resourceIndex)
ilog.V(5).Info("replicating for each tenant")
opts.Iterator = NewCollectorIteratorOptions(&tnt, nil, resource)
if err := r.collector.Collect(
ctx,
c,
opts,
&tnt,
strconv.Itoa(resourceIndex),
resource,
nil,
); err != nil {
return err
}
}
case api.ResourceScopeNamespace:
for _, tnt := range tnts.Items {
ilog := log.WithValues("tenant", tnt.GetName(), "resource", resourceIndex)
ilog.V(5).Info("replicating for each namespace")
opts.AllowCrossNamespaceSelection = true
objs, err := r.collector.CollectNamespacedItems(ctx, c, opts, resource, nil, tnt)
if err != nil {
return err
}
for g := range objs {
ilog.V(5).Info("found replication source object", "name", g.Name, "namespace", g.Namespace, "kind", g.Kind)
}
namespaces, err := r.collector.selectedTenantNamespaces(ctx, log, tnt, resource)
if err != nil {
return err
}
opts.AllowCrossNamespaceSelection = false
for _, innerNs := range namespaces {
if err := r.collector.CollectForNamespace(
ctx,
c,
opts,
tnt,
strconv.Itoa(resourceIndex),
resource,
objs,
innerNs,
); err != nil {
return err
}
}
}
}
}
return nil
}
func (r *globalResourceController) loadClient(
ctx context.Context,
log logr.Logger,
tntResource *capsulev1beta2.GlobalTenantResource,
) (client.Client, error) {
c, sa, err := r.clients.Load(ctx, log, tntResource)
// The resolved identity is posted to the status even along a failure, as it states
// which ServiceAccount the replication was attempted with.
tntResource.Status.ServiceAccount = sa
if err != nil {
return nil, err
}
return c, nil
}
func (r *globalResourceController) updateReconcilingStatus(ctx context.Context, instance *capsulev1beta2.GlobalTenantResource) error {
return retry.RetryOnConflict(retry.DefaultBackoff, func() (err error) {
latest := &capsulev1beta2.GlobalTenantResource{}
if err = r.reader.Get(ctx, types.NamespacedName{Name: instance.GetName()}, latest); err != nil {
return err
}
if latest.Status.ObservedGeneration == instance.GetGeneration() {
return nil
}
latest.Status.ServiceAccount = instance.Status.ServiceAccount
latest.Status.Conditions.UpdateConditionByType(meta.NewReadyConditionReconcilingReason(instance))
if err := r.client.Status().Update(ctx, latest); err != nil {
if apierrors.IsNotFound(err) {
return nil
}
return err
}
// Keep the in-memory object aligned with what we just wrote.
instance.Status = latest.Status
return nil
})
}
func (r *globalResourceController) updateStatus(ctx context.Context, instance *capsulev1beta2.GlobalTenantResource, reconcileError error) error {
instance.Status.UpdateStats()
return retry.RetryOnConflict(retry.DefaultBackoff, func() (err error) {
latest := &capsulev1beta2.GlobalTenantResource{}
if err = r.reader.Get(ctx, types.NamespacedName{Name: instance.GetName()}, latest); err != nil {
if apierrors.IsNotFound(err) {
return nil
}
return err
}
originalStatus := latest.Status.DeepCopy()
latest.Status = instance.Status
latest.Status.ObservedGeneration = instance.GetGeneration()
// Set Ready Condition
readyCondition := meta.NewReadyCondition(instance)
if reconcileError != nil {
readyCondition.Message = reconcileError.Error()
readyCondition.Status = metav1.ConditionFalse
readyCondition.Reason = meta.FailedReason
}
latest.Status.Conditions.UpdateConditionByType(readyCondition)
// Set Cordoned Condition
cordonedCondition := meta.NewCordonedCondition(instance)
if *instance.Spec.Cordoned {
cordonedCondition.Reason = meta.CordonedReason
cordonedCondition.Message = "is cordoned" //nolint:goconst
cordonedCondition.Status = metav1.ConditionTrue
}
latest.Status.Conditions.UpdateConditionByType(cordonedCondition)
if reflect.DeepEqual(*originalStatus, latest.Status) {
return nil
}
if err := r.client.Status().Update(ctx, latest); err != nil {
return err
}
// Keep the in-memory object aligned with what we just wrote.
instance.Status = latest.Status
return nil
})
}