capsule/pkg/runtime/quota/validation_test.go

// Copyright 2020-2026 Project Capsule Authors
// SPDX-License-Identifier: Apache-2.0

package quota

import (
	"strings"
	"testing"

	corev1 "k8s.io/api/core/v1"
	"k8s.io/apimachinery/pkg/api/resource"
)

func TestValidateHardLimit(t *testing.T) {
	t.Parallel()

	allocated := corev1.ResourceList{
		corev1.ResourceLimitsCPU: resource.MustParse("4"),
	}

	tests := []struct {
		name    string
		hard    corev1.ResourceList
		wantErr string
	}{
		{
			name: "rejects configured limit below allocation",
			hard: corev1.ResourceList{
				corev1.ResourceLimitsCPU: resource.MustParse("3"),
			},
			wantErr: "cannot be reduced to 3 while 4 is allocated",
		},
		{
			name: "allows configured limit equal to allocation",
			hard: corev1.ResourceList{
				corev1.ResourceLimitsCPU: resource.MustParse("4"),
			},
		},
		{
			name: "allows removal of allocated resource",
			hard: corev1.ResourceList{},
		},
	}

	for _, test := range tests {
		t.Run(test.name, func(t *testing.T) {
			t.Parallel()

			err := ValidateHardLimit("spec.quota.hard", test.hard, allocated)
			if test.wantErr == "" {
				if err != nil {
					t.Fatalf("ValidateHardLimit() error = %v", err)
				}

				return
			}

			if err == nil || !strings.Contains(err.Error(), test.wantErr) {
				t.Fatalf("ValidateHardLimit() error = %v, want containing %q", err, test.wantErr)
			}
		})
	}
}

func TestValidateHardLimitScopeChange(t *testing.T) {
	t.Parallel()

	previous := corev1.ResourceList{
		corev1.ResourceLimitsCPU: resource.MustParse("8"),
	}

	tests := []struct {
		name         string
		hard         corev1.ResourceList
		scopeChanged bool
		wantErr      string
	}{
		{
			name: "rejects decrease while scope changes",
			hard: corev1.ResourceList{
				corev1.ResourceLimitsCPU: resource.MustParse("0"),
			},
			scopeChanged: true,
			wantErr:      "cannot be reduced from 8 to 0 while namespace selectors are changing",
		},
		{
			name:         "allows removal while scope changes",
			hard:         corev1.ResourceList{},
			scopeChanged: true,
		},
		{
			name: "allows equal limit while scope changes",
			hard: corev1.ResourceList{
				corev1.ResourceLimitsCPU: resource.MustParse("8"),
			},
			scopeChanged: true,
		},
		{
			name: "allows increase while scope changes",
			hard: corev1.ResourceList{
				corev1.ResourceLimitsCPU: resource.MustParse("10"),
			},
			scopeChanged: true,
		},
		{
			name: "defers unchanged-scope decrease to usage validation",
			hard: corev1.ResourceList{
				corev1.ResourceLimitsCPU: resource.MustParse("0"),
			},
		},
	}

	for _, test := range tests {
		t.Run(test.name, func(t *testing.T) {
			t.Parallel()

			err := ValidateHardLimitScopeChange(
				"spec.quota.hard",
				test.hard,
				previous,
				test.scopeChanged,
			)
			if test.wantErr == "" {
				if err != nil {
					t.Fatalf("ValidateHardLimitScopeChange() error = %v", err)
				}

				return
			}

			if err == nil || !strings.Contains(err.Error(), test.wantErr) {
				t.Fatalf("ValidateHardLimitScopeChange() error = %v, want containing %q", err, test.wantErr)
			}
		})
	}
}